From 0530f9664893b70470f1932b8db887a05612fc06 Mon Sep 17 00:00:00 2001 From: Kev <36553759+forkymcforkface@users.noreply.github.com> Date: Tue, 23 Sep 2025 10:11:17 -0700 Subject: [PATCH] Fix broken Samba user management functions in helper.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Description: This corrects a typo in the helper script that prevented Samba user management from working. Functions were originally defined as EditSmabaUserPassword and AddSmabaUser. Because of the misspelling, they were never called, and Samba passwords were not being set. Changes: Renamed EditSmabaUserPassword → EditSambaUserPassword Renamed AddSmabaUser → AddSambaUser Impact: Samba password changes and user additions will now function correctly. No backward-compatibility issues, since nothing was successfully calling the typo’d functions before. Notes: This resolves a long-standing bug where Samba accounts were not being properly configured. Signed-off-by: Kev <36553759+forkymcforkface@users.noreply.github.com> --- build/sysroot/usr/share/casaos/shell/helper.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build/sysroot/usr/share/casaos/shell/helper.sh b/build/sysroot/usr/share/casaos/shell/helper.sh index c6f576d..3c4759d 100644 --- a/build/sysroot/usr/share/casaos/shell/helper.sh +++ b/build/sysroot/usr/share/casaos/shell/helper.sh @@ -337,11 +337,11 @@ RestartSMBD(){ } # edit user password $1:username -EditSmabaUserPassword(){ +EditSambaUserPassword(){ $sudo_cmd smbpasswd $1 } -AddSmabaUser(){ +AddSambaUser(){ $sudo_cmd useradd $1 $sudo_cmd smbpasswd -a $1 <