rename ivar

adjust name so that it's not that easy to confuse
it with the identificationType. This is only the type of
the identifier.
This commit is contained in:
Stephan Diederich 2013-10-08 23:32:55 +02:00
parent 98bcbcb75f
commit 00ad57b245
4 changed files with 14 additions and 8 deletions

View File

@ -275,8 +275,8 @@ static NSString* const kBITAuthenticatorAuthTokenTypeKey = @"BITAuthenticatorAut
- (NSDictionary*) validationParameters {
NSParameterAssert(self.installationIdentifier);
NSParameterAssert(self.installationIdentifierTypeString);
return @{self.installationIdentifierTypeString : self.installationIdentifier};
NSParameterAssert(self.installationIdentifierParameterString);
return @{self.installationIdentifierParameterString : self.installationIdentifier};
}
+ (BOOL) isValidationResponseValid:(id) response error:(NSError **) error {
@ -639,8 +639,14 @@ static NSString* const kBITAuthenticatorAuthTokenTypeKey = @"BITAuthenticatorAut
return [[NSUserDefaults standardUserDefaults] objectForKey:kBITAuthenticatorLastAuthenticatedVersionKey];
}
- (NSString *)installationIdentifierTypeString {
return [self.class stringForIdentificationType:self.identificationType];
- (NSString *)installationIdentifierParameterString {
switch(self.identificationType) {
case BITAuthenticatorIdentificationTypeHockeyAppEmail:
return @"iuid";
case BITAuthenticatorIdentificationTypeHockeyAppUser: return @"auid";
case BITAuthenticatorIdentificationTypeDevice: return @"udid";
case BITAuthenticatorIdentificationTypeAnonymous: return @"uuid";
}
}
+ (NSString *)stringForIdentificationType:(BITAuthenticatorIdentificationType) identificationType {

View File

@ -50,9 +50,9 @@
@property (nonatomic, copy) NSString *lastAuthenticatedVersion;
/**
* return the string used to identify this app against the HockeyApp backend.
* returns the type of the string stored in installationIdentifierParameterString
*/
@property (nonatomic, copy, readonly) NSString *installationIdentifierTypeString;
@property (nonatomic, copy, readonly) NSString *installationIdentifierParameterString;
/**
* returns the string used to identify this app against the HockeyApp backend.

View File

@ -356,7 +356,7 @@
#if HOCKEYSDK_FEATURE_AUTHENTICATOR
if (_authenticator) {
[_updateManager setInstallationIdentification:[self.authenticator installationIdentifier]];
[_updateManager setInstallationIdentificationType:[self.authenticator installationIdentifierTypeString]];
[_updateManager setInstallationIdentificationType:[self.authenticator installationIdentifierParameterString]];
[_updateManager setInstallationIdentified:[self.authenticator isIdentified]];
}
#endif

View File

@ -111,7 +111,7 @@ static void *kInstallationIdentification = &kInstallationIdentification;
assertThatBool(_sut.isValidated, equalToBool(NO));
assertThat(_sut.authenticationSecret, equalTo(nil));
assertThat(_sut.installationIdentifier, equalTo(nil));
assertThat(_sut.installationIdentifierTypeString, equalTo(@"uuid"));
assertThat(_sut.installationIdentifierParameterString, equalTo(@"uuid"));
}
#pragma mark - General identification tests