ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-17 11:50:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename ivar

Browse Source 
adjust name so that it's not that easy to confuse
it with the identificationType. This is only the type of
the identifier.
This commit is contained in:
Stephan Diederich 2013-10-08 23:32:55 +02:00
parent 98bcbcb75f
commit 00ad57b245
4 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Classes/BITAuthenticator.m
View File

@ -275,8 +275,8 @@ static NSString* const kBITAuthenticatorAuthTokenTypeKey = @"BITAuthenticatorAut
- (NSDictionary*) validationParameters { - (NSDictionary*) validationParameters {
NSParameterAssert(self.installationIdentifier); NSParameterAssert(self.installationIdentifier);
NSParameterAssert(self.installationIdentifierTypeString); NSParameterAssert(self.installationIdentifierParameterString);
return @{self.installationIdentifierTypeString : self.installationIdentifier}; return @{self.installationIdentifierParameterString : self.installationIdentifier};
} }
+ (BOOL) isValidationResponseValid:(id) response error:(NSError **) error { + (BOOL) isValidationResponseValid:(id) response error:(NSError **) error {
@ -639,8 +639,14 @@ static NSString* const kBITAuthenticatorAuthTokenTypeKey = @"BITAuthenticatorAut
return [[NSUserDefaults standardUserDefaults] objectForKey:kBITAuthenticatorLastAuthenticatedVersionKey]; return [[NSUserDefaults standardUserDefaults] objectForKey:kBITAuthenticatorLastAuthenticatedVersionKey];
} }
- (NSString *)installationIdentifierTypeString { - (NSString *)installationIdentifierParameterString {
return [self.class stringForIdentificationType:self.identificationType]; switch(self.identificationType) {
case BITAuthenticatorIdentificationTypeHockeyAppEmail:
return @"iuid";
case BITAuthenticatorIdentificationTypeHockeyAppUser: return @"auid";
case BITAuthenticatorIdentificationTypeDevice: return @"udid";
case BITAuthenticatorIdentificationTypeAnonymous: return @"uuid";
}
} }
+ (NSString *)stringForIdentificationType:(BITAuthenticatorIdentificationType) identificationType { + (NSString *)stringForIdentificationType:(BITAuthenticatorIdentificationType) identificationType {

4
Classes/BITAuthenticator_Private.h
View File

@ -50,9 +50,9 @@
@property (nonatomic, copy) NSString *lastAuthenticatedVersion; @property (nonatomic, copy) NSString *lastAuthenticatedVersion;
/** /**
* return the string used to identify this app against the HockeyApp backend. * returns the type of the string stored in installationIdentifierParameterString
*/ */
@property (nonatomic, copy, readonly) NSString *installationIdentifierTypeString; @property (nonatomic, copy, readonly) NSString *installationIdentifierParameterString;
/** /**
* returns the string used to identify this app against the HockeyApp backend. * returns the string used to identify this app against the HockeyApp backend.

2
Classes/BITHockeyManager.m
View File

@ -356,7 +356,7 @@
#if HOCKEYSDK_FEATURE_AUTHENTICATOR #if HOCKEYSDK_FEATURE_AUTHENTICATOR
if (_authenticator) { if (_authenticator) {
[_updateManager setInstallationIdentification:[self.authenticator installationIdentifier]]; [_updateManager setInstallationIdentification:[self.authenticator installationIdentifier]];
[_updateManager setInstallationIdentificationType:[self.authenticator installationIdentifierTypeString]]; [_updateManager setInstallationIdentificationType:[self.authenticator installationIdentifierParameterString]];
[_updateManager setInstallationIdentified:[self.authenticator isIdentified]]; [_updateManager setInstallationIdentified:[self.authenticator isIdentified]];
} }
#endif #endif

2
Support/HockeySDKTests/BITAuthenticatorTests.m
View File

@ -111,7 +111,7 @@ static void *kInstallationIdentification = &kInstallationIdentification;
assertThatBool(_sut.isValidated, equalToBool(NO)); assertThatBool(_sut.isValidated, equalToBool(NO));
assertThat(_sut.authenticationSecret, equalTo(nil)); assertThat(_sut.authenticationSecret, equalTo(nil));
assertThat(_sut.installationIdentifier, equalTo(nil)); assertThat(_sut.installationIdentifier, equalTo(nil));
assertThat(_sut.installationIdentifierTypeString, equalTo(@"uuid")); assertThat(_sut.installationIdentifierParameterString, equalTo(@"uuid"));
} }
#pragma mark - General identification tests #pragma mark - General identification tests