ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-09-04 03:40:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ASCollectionNode] Add .collectionViewClass to ASCollectionNode+Beta. (#3198)

Browse Source 
Although we may not want to support this property long-term, there are some usages of it
that are difficult to avoid. Specifically because the complexity it adds is both low,
and contained to a small area of the code that would be easy to remove it, it would be
great to support this.

The usage relates to apps that require the Interop protocol, and are architected to expect
a few methods / protocols being implemented on the UICollectionView class itself. It does
not directly override ASCollectionView behaviors. So hypothetically, it would also work
if it were possible to set ASCollectionView's superclass.

Instead, the app is making its own subclass descend from ASCollectionView and use the interop
APIs, even in environments where there are no ASCellNodes ever returned.
This commit is contained in:
appleguy 2017-03-21 09:54:53 -07:00 committed by Adlai Holler
parent d5a84bf7b1
commit 03d9873cb2
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Source/ASCollectionNode+Beta.h
View File

@ -16,6 +16,13 @@ NS_ASSUME_NONNULL_BEGIN
@interface ASCollectionNode (Beta)
/**
* Allows providing a custom subclass of ASCollectionView to be managed by ASCollectionNode.
*
* @default [ASCollectionView class] is used whenever this property is unset or nil.
*/
@property (strong, nonatomic, nullable) Class collectionViewClass;
- (instancetype)initWithFrame:(CGRect)frame collectionViewLayout:(UICollectionViewLayout *)layout layoutFacilitator:(nullable id<ASCollectionViewLayoutFacilitatorProtocol>)layoutFacilitator;
- (void)beginUpdates ASDISPLAYNODE_DEPRECATED_MSG("Use -performBatchUpdates:completion: instead.");

17
Source/ASCollectionNode.mm
View File

@ -100,6 +100,7 @@
@interface ASCollectionNode ()
{
ASDN::RecursiveMutex _environmentStateLock;
Class _collectionViewClass;
}
@property (nonatomic) _ASCollectionPendingState *pendingState;
@end
@ -108,6 +109,20 @@
#pragma mark Lifecycle
- (Class)collectionViewClass
{
return _collectionViewClass ? : [ASCollectionView class];
}
- (void)setCollectionViewClass:(Class)collectionViewClass
{
if (_collectionViewClass != collectionViewClass) {
ASDisplayNodeAssert([collectionViewClass isSubclassOfClass:[ASCollectionView class]] || collectionViewClass == Nil, @"ASCollectionNode requires that .collectionViewClass is an ASCollectionView subclass");
ASDisplayNodeAssert([self isNodeLoaded] == NO, @"ASCollectionNode's .collectionViewClass cannot be changed after the view is loaded");
_collectionViewClass = collectionViewClass;
}
}
- (instancetype)init
{
ASDISPLAYNODE_NOT_DESIGNATED_INITIALIZER();
@ -132,7 +147,7 @@
ASDisplayNodeViewBlock collectionViewBlock = ^UIView *{
// Variable will be unused if event logging is off.
__unused __typeof__(self) strongSelf = weakSelf;
return [[ASCollectionView alloc] _initWithFrame:frame collectionViewLayout:layout layoutFacilitator:layoutFacilitator eventLog:ASDisplayNodeGetEventLog(strongSelf)];
return [[[strongSelf collectionViewClass] alloc] _initWithFrame:frame collectionViewLayout:layout layoutFacilitator:layoutFacilitator eventLog:ASDisplayNodeGetEventLog(strongSelf)];
};
if (self = [super initWithViewBlock:collectionViewBlock didLoadBlock:nil]) {