From 072df8962c8a92bdd37a381f51dda3eb6cd9ed86 Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Wed, 17 Oct 2018 08:02:10 -0700 Subject: [PATCH] Fix mismatch in UIAccessibilityAction selector method (#1169) * Fix mismatch in UIAccessibilityAction selector method * Update changelog --- CHANGELOG.md | 1 + Source/ASDisplayNode+Beta.h | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b7e0430498..d85256b12b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -57,6 +57,7 @@ - Clean up timing of layout tree flattening/ copying of unflattened tree for Weaver. [Michael Zuccarino](https://github.com/mikezucc) [#1157](https://github.com/TextureGroup/Texture/pull/1157) - Fix crash setting attributed text on multiple threads [Michael Schneider](https://github.com/maicki) - [ASTextNode2] Ignore certain text alignments while calculating intrinsic size [Huy Nguyen](https://github.com/nguyenhuy) [#1166](https://github.com/TextureGroup/Texture/pull/1166) +- Fix mismatch in UIAccessibilityAction selector method [Michael Schneider](https://github.com/maicki) [#1169](https://github.com/TextureGroup/Texture/pull/1169) ## 2.7 - Fix pager node for interface coalescing. [Max Wang](https://github.com/wsdwsd0829) [#877](https://github.com/TextureGroup/Texture/pull/877) diff --git a/Source/ASDisplayNode+Beta.h b/Source/ASDisplayNode+Beta.h index e140721cc6..b288372792 100644 --- a/Source/ASDisplayNode+Beta.h +++ b/Source/ASDisplayNode+Beta.h @@ -99,8 +99,11 @@ typedef struct { /** * @abstract Invoked when a user performs a custom action on an accessible node. Nodes that are children of accessibility containers, have * an accessibity label and have an interactive UIAccessibilityTrait will automatically receive custom-action handling. + * + * @return Return a boolean value that determine whether to propagate through the responder chain. + * To halt propagation, return YES; otherwise, return NO. */ -- (void)performAccessibilityCustomAction:(UIAccessibilityCustomAction *)action; +- (BOOL)performAccessibilityCustomAction:(UIAccessibilityCustomAction *)action; /** * @abstract Currently used by ASNetworkImageNode and ASMultiplexImageNode to allow their placeholders to stay if they are loading an image from the network.