From 6763399f00436d177df210bd29248203d7f4a34b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ce=CC=81dric=20Luthi?= Date: Thu, 19 Mar 2015 09:51:25 +0100 Subject: [PATCH 1/2] Add deprecated property for renamed `timeintervalCrashInLastSessionOccurred` --- Classes/BITCrashManager.h | 10 ++++++++-- Classes/BITCrashManager.m | 8 ++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/Classes/BITCrashManager.h b/Classes/BITCrashManager.h index 235995487f..e415ce889c 100644 --- a/Classes/BITCrashManager.h +++ b/Classes/BITCrashManager.h @@ -140,7 +140,7 @@ typedef NS_ENUM(NSUInteger, BITCrashManagerUserInput) { very slow. It is possible to check upon startup if the app crashed before using `didCrashInLastSession` and also how much - time passed between the app launch and the crash using `timeintervalCrashInLastSessionOccurred`. This allows you + time passed between the app launch and the crash using `timeIntervalCrashInLastSessionOccurred`. This allows you to add additional code to your app delaying the app start until the crash has been successfully send if the crash occurred within a critical startup timeframe, e.g. after 10 seconds. The `BITCrashManagerDelegate` protocol provides various delegates to inform the app about it's current status so you can continue the remaining app startup setup @@ -400,7 +400,7 @@ typedef NS_ENUM(NSUInteger, BITCrashManagerUserInput) { @see didCrashInLastSession @see BITCrashManagerDelegate */ -@property (nonatomic, readonly) NSTimeInterval timeintervalCrashInLastSessionOccurred; +@property (nonatomic, readonly) NSTimeInterval timeIntervalCrashInLastSessionOccurred; ///----------------------------------------------------------------------------- @@ -433,4 +433,10 @@ typedef NS_ENUM(NSUInteger, BITCrashManagerUserInput) { */ - (void)generateTestCrash; +///----------------------------------------------------------------------------- +/// @name Deprecated +///----------------------------------------------------------------------------- + +@property (nonatomic, readonly) NSTimeInterval timeintervalCrashInLastSessionOccured DEPRECATED_MSG_ATTRIBUTE("Use the properly spelled property `timeIntervalCrashInLastSessionOccurred` instead."); + @end diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index 35a8f077df..1c4092c942 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -137,7 +137,7 @@ static PLCrashReporterCallbacks plCrashCallbacks = { _crashIdenticalCurrentVersion = YES; _didCrashInLastSession = NO; - _timeintervalCrashInLastSessionOccurred = -1; + _timeIntervalCrashInLastSessionOccurred = -1; _didLogLowMemoryWarning = NO; _approvedCrashReports = [[NSMutableDictionary alloc] init]; @@ -797,7 +797,7 @@ static PLCrashReporterCallbacks plCrashCallbacks = { if (report.systemInfo.timestamp && report.processInfo.processStartTime) { appStartTime = report.processInfo.processStartTime; appCrashTime =report.systemInfo.timestamp; - _timeintervalCrashInLastSessionOccurred = [report.systemInfo.timestamp timeIntervalSinceDate:report.processInfo.processStartTime]; + _timeIntervalCrashInLastSessionOccurred = [report.systemInfo.timestamp timeIntervalSinceDate:report.processInfo.processStartTime]; } } @@ -1521,6 +1521,10 @@ static PLCrashReporterCallbacks plCrashCallbacks = { [self.hockeyAppClient enqeueHTTPOperation:operation]; } +- (NSTimeInterval)timeintervalCrashInLastSessionOccured { + return self.timeIntervalCrashInLastSessionOccurred; +} + @end #endif /* HOCKEYSDK_FEATURE_CRASH_REPORTER */ From 6b79a2fd053c8b906e9650f4a1888feb065e90c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ce=CC=81dric=20Luthi?= Date: Thu, 19 Mar 2015 09:51:58 +0100 Subject: [PATCH 2/2] Add deprecated enum for renamed `BITFeedbackListViewCellPresentatationStyle` --- Classes/BITFeedbackListViewCell.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Classes/BITFeedbackListViewCell.h b/Classes/BITFeedbackListViewCell.h index 8ac0da722b..4320b27c24 100644 --- a/Classes/BITFeedbackListViewCell.h +++ b/Classes/BITFeedbackListViewCell.h @@ -85,4 +85,13 @@ typedef NS_ENUM(NSUInteger, BITFeedbackListViewCellBackgroundStyle) { - (void)setAttachments:(NSArray *)attachments; +///----------------------------------------------------------------------------- +/// @name Deprecated +///----------------------------------------------------------------------------- + +typedef DEPRECATED_MSG_ATTRIBUTE("Use the properly spelled enum `BITFeedbackListViewCellPresentationStyle` instead.") NS_ENUM(NSUInteger, BITFeedbackListViewCellPresentatationStyle) { + BITFeedbackListViewCellPresentatationStyleDefault DEPRECATED_MSG_ATTRIBUTE("Use the properly spelled constant `BITFeedbackListViewCellPresentationStyleDefault` instead.") = 0, + BITFeedbackListViewCellPresentatationStyleOS7 DEPRECATED_MSG_ATTRIBUTE("Use the properly spelled constant `BITFeedbackListViewCellPresentationStyleOS7` instead.") = 1 +}; + @end