From 13c467b2f471897bd31e9afce11d3c2eb1b213bd Mon Sep 17 00:00:00 2001 From: Michael Schneider Date: Thu, 8 Jun 2017 19:45:03 +0200 Subject: [PATCH] Fix internal Linter warnings #trivial (#340) * Fix internal Linter warnings * Remove explicit copy for block as let us just use the default one --- Source/ASDisplayNode+Subclasses.h | 2 +- Source/ASDisplayNode.h | 4 ++-- Source/Details/ASImageProtocols.h | 4 ++-- Source/Layout/ASLayoutElement.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Source/ASDisplayNode+Subclasses.h b/Source/ASDisplayNode+Subclasses.h index 2c8f9a0674..efc9faba46 100644 --- a/Source/ASDisplayNode+Subclasses.h +++ b/Source/ASDisplayNode+Subclasses.h @@ -122,7 +122,7 @@ NS_ASSUME_NONNULL_BEGIN * * @warning Subclasses must not override this; it returns the last cached layout and is never expensive. */ -@property (nullable, nonatomic, readonly, assign) ASLayout *calculatedLayout; +@property (nullable, nonatomic, readonly, strong) ASLayout *calculatedLayout; #pragma mark - View Lifecycle /** @name View Lifecycle */ diff --git a/Source/ASDisplayNode.h b/Source/ASDisplayNode.h index 6b63d44282..b4f52140bd 100644 --- a/Source/ASDisplayNode.h +++ b/Source/ASDisplayNode.h @@ -646,12 +646,12 @@ extern NSInteger const ASDefaultDrawingPriority; #if TARGET_OS_IOS @property (nonatomic, assign, getter=isExclusiveTouch) BOOL exclusiveTouch; // default=NO #endif -@property (nonatomic, assign, nullable) CGColorRef shadowColor; // default=opaque rgb black +@property (nonatomic, nullable) CGColorRef shadowColor; // default=opaque rgb black @property (nonatomic, assign) CGFloat shadowOpacity; // default=0.0 @property (nonatomic, assign) CGSize shadowOffset; // default=(0, -3) @property (nonatomic, assign) CGFloat shadowRadius; // default=3 @property (nonatomic, assign) CGFloat borderWidth; // default=0 -@property (nonatomic, assign, nullable) CGColorRef borderColor; // default=opaque rgb black +@property (nonatomic, nullable) CGColorRef borderColor; // default=opaque rgb black // UIResponder methods // By default these fall through to the underlying view, but can be overridden. diff --git a/Source/Details/ASImageProtocols.h b/Source/Details/ASImageProtocols.h index 9b73b42f39..3fdf321e45 100644 --- a/Source/Details/ASImageProtocols.h +++ b/Source/Details/ASImageProtocols.h @@ -163,7 +163,7 @@ withDownloadIdentifier:(id)downloadIdentifier; /** @abstract A block which receives the cover image. Should be called when the objects cover image is ready. */ -@property (nonatomic, strong, readwrite) void (^coverImageReadyCallback)(UIImage *coverImage); +@property (nonatomic, readwrite) void (^coverImageReadyCallback)(UIImage *coverImage); /** @abstract Returns whether the supplied data contains a supported animated image format. @@ -209,7 +209,7 @@ withDownloadIdentifier:(id)downloadIdentifier; /** @abstract Should be called when playback is ready. */ -@property (nonatomic, strong, readwrite) dispatch_block_t playbackReadyCallback; +@property (nonatomic, readwrite) dispatch_block_t playbackReadyCallback; /** @abstract Return the image at a given index. diff --git a/Source/Layout/ASLayoutElement.h b/Source/Layout/ASLayoutElement.h index 30bb021078..397360a6a5 100644 --- a/Source/Layout/ASLayoutElement.h +++ b/Source/Layout/ASLayoutElement.h @@ -72,7 +72,7 @@ typedef NS_ENUM(NSUInteger, ASLayoutElementType) { /** * @abstract A size constraint that should apply to this ASLayoutElement. */ -@property (nonatomic, assign, readonly) ASLayoutElementStyle *style; +@property (nonatomic, strong, readonly) ASLayoutElementStyle *style; /** * @abstract Returns all children of an object which class conforms to the ASLayoutElement protocol