setNeedsDisplay must be called on main

This commit is contained in:
Shannon Ma
2015-07-31 12:11:19 -07:00
parent f7a4ca45db
commit 15133fdbf7
4 changed files with 58 additions and 20 deletions

View File

@@ -11,6 +11,7 @@
#import <AsyncDisplayKit/_ASDisplayLayer.h>
#import <AsyncDisplayKit/ASAssert.h>
#import <AsyncDisplayKit/ASDisplayNode+Subclasses.h>
#import <AsyncDisplayKit/ASDisplayNodeInternal.h>
#import <AsyncDisplayKit/ASHighlightOverlayLayer.h>
#import <AsyncDisplayKit/ASTextNodeCoreTextAdditions.h>
#import <AsyncDisplayKit/ASTextNodeTextKitHelpers.h>
@@ -202,7 +203,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
_constrainedSize = constrainedSizeForText;
[self _invalidateRenderer];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
CGSize rendererSize = [[self _renderer] size];
// Add shadow padding back
@@ -337,19 +340,21 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
// We need an entirely new renderer
[self _invalidateRenderer];
// Tell the display node superclasses that the cached layout is incorrect now
[self invalidateCalculatedLayout];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
// Tell the display node superclasses that the cached layout is incorrect now
[self invalidateCalculatedLayout];
[self setNeedsDisplay];
[self setNeedsDisplay];
self.accessibilityLabel = _attributedString.string;
self.accessibilityLabel = _attributedString.string;
if (_attributedString.length == 0) {
// We're not an accessibility element by default if there is no string.
self.isAccessibilityElement = NO;
} else {
self.isAccessibilityElement = YES;
}
if (_attributedString.length == 0) {
// We're not an accessibility element by default if there is no string.
self.isAccessibilityElement = NO;
} else {
self.isAccessibilityElement = YES;
}
});
}
#pragma mark - Text Layout
@@ -360,7 +365,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
_exclusionPaths = exclusionPaths;
[self _invalidateRenderer];
[self invalidateCalculatedLayout];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -897,7 +904,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
}
_shadowColor = shadowColor;
[self _invalidateShadower];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -911,7 +920,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
if (!CGSizeEqualToSize(_shadowOffset, shadowOffset)) {
_shadowOffset = shadowOffset;
[self _invalidateShadower];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -925,7 +936,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
if (_shadowOpacity != shadowOpacity) {
_shadowOpacity = shadowOpacity;
[self _invalidateShadower];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -939,7 +952,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
if (_shadowRadius != shadowRadius) {
_shadowRadius = shadowRadius;
[self _invalidateShadower];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -981,7 +996,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
if (_truncationMode != truncationMode) {
_truncationMode = truncationMode;
[self _invalidateRenderer];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -994,8 +1011,10 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
{
if (_maximumLineCount != maximumLineCount) {
_maximumLineCount = maximumLineCount;
[self _invalidateRenderer];
[self _invalidateRenderer];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
}
@@ -1010,7 +1029,9 @@ ASDISPLAYNODE_INLINE CGFloat ceilPixelValue(CGFloat f)
{
_composedTruncationString = [self _prepareTruncationStringForDrawing:[self _composedTruncationString]];
[self _invalidateRenderer];
[self setNeedsDisplay];
ASDisplayNodeRespectThreadAffinityOfNode(self, ^{
[self setNeedsDisplay];
});
}
/**