ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-22 22:25:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Not animated for end updates if animation is already going on within ASTableView

Browse Source 
Fix strange artifacts in ASTableView are visible when changing the device orientation or other animations are going on while calling endUpdates
This commit is contained in:
Michael Schneider
2016-11-22 14:16:35 -08:00
parent 60756a1da5
commit 1f7b838d5e
3 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
AsyncDisplayKit/ASTableView.mm
View File

@@ -21,6 +21,7 @@
#import "ASInternalHelpers.h" #import "ASInternalHelpers.h"
#import "ASLayout.h" #import "ASLayout.h"
#import "_ASDisplayLayer.h" #import "_ASDisplayLayer.h"
#import "_ASCoreAnimationExtras.h"
#import "ASTableNode.h" #import "ASTableNode.h"
#import "ASEqualityHelpers.h" #import "ASEqualityHelpers.h"
#import "ASTableView+Undeprecated.h" #import "ASTableView+Undeprecated.h"
@@ -610,7 +611,7 @@ static NSString * const kCellReuseIdentifier = @"_ASTableViewCell";
} else { } else {
[self beginUpdates]; [self beginUpdates];
[_dataController relayoutAllNodes]; [_dataController relayoutAllNodes];
[self endUpdates]; [self endUpdatesAnimated:(ASDisplayNodeLayerHasAnimations(self.layer) == NO) completion:nil];
} }
} }
@@ -1583,7 +1584,7 @@ static NSString * const kCellReuseIdentifier = @"_ASTableViewCell";
// If the node height changed, trigger a height requery. // If the node height changed, trigger a height requery.
if (oldSize.height != calculatedSize.height) { if (oldSize.height != calculatedSize.height) {
[self beginUpdates]; [self beginUpdates];
[self endUpdates]; [self endUpdatesAnimated:(ASDisplayNodeLayerHasAnimations(self.layer) == NO) completion:nil];
} }
} }
} }

7
AsyncDisplayKit/Private/_ASCoreAnimationExtras.h
View File

@@ -53,4 +53,11 @@ extern UIViewContentMode ASDisplayNodeUIContentModeFromCAContentsGravity(NSStrin
*/ */
extern UIImage *ASDisplayNodeStretchableBoxContentsWithColor(UIColor *color, CGSize innerSize); extern UIImage *ASDisplayNodeStretchableBoxContentsWithColor(UIColor *color, CGSize innerSize);
/**
Checks whether a layer has ongoing animations
@param layer A layer to check if animations are ongoing
@return YES if the layer has ongoing animations, otherwise NO
*/
extern BOOL ASDisplayNodeLayerHasAnimations(CALayer *layer);
ASDISPLAYNODE_EXTERN_C_END ASDISPLAYNODE_EXTERN_C_END

5
AsyncDisplayKit/Private/_ASCoreAnimationExtras.mm
View File

@@ -154,3 +154,8 @@ UIViewContentMode ASDisplayNodeUIContentModeFromCAContentsGravity(NSString *cons
// If asserts disabled, fall back to this // If asserts disabled, fall back to this
return UIViewContentModeScaleToFill; return UIViewContentModeScaleToFill;
} }
BOOL ASDisplayNodeLayerHasAnimations(CALayer *layer)
{
return (layer.animationKeys.count != 0);
}