diff --git a/AsyncDisplayKit.xcodeproj/project.pbxproj b/AsyncDisplayKit.xcodeproj/project.pbxproj index 390bc3e638..7d308871c3 100644 --- a/AsyncDisplayKit.xcodeproj/project.pbxproj +++ b/AsyncDisplayKit.xcodeproj/project.pbxproj @@ -196,7 +196,6 @@ 68FC85EA1CE29C7D00EDD713 /* ASVisibilityProtocols.h in Headers */ = {isa = PBXBuildFile; fileRef = 68FC85E71CE29C7D00EDD713 /* ASVisibilityProtocols.h */; settings = {ATTRIBUTES = (Public, ); }; }; 68FC85EB1CE29C7D00EDD713 /* ASVisibilityProtocols.m in Sources */ = {isa = PBXBuildFile; fileRef = 68FC85E81CE29C7D00EDD713 /* ASVisibilityProtocols.m */; }; 68FC85EC1CE29C7D00EDD713 /* ASVisibilityProtocols.m in Sources */ = {isa = PBXBuildFile; fileRef = 68FC85E81CE29C7D00EDD713 /* ASVisibilityProtocols.m */; }; - 690457F71DB5131A00B5EE68 /* ASLayoutPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 690457F61DB5131A00B5EE68 /* ASLayoutPrivate.h */; }; 6959433E1D70815300B0EE1F /* ASDisplayNodeLayout.mm in Sources */ = {isa = PBXBuildFile; fileRef = 6959433C1D70815300B0EE1F /* ASDisplayNodeLayout.mm */; }; 6959433F1D70815300B0EE1F /* ASDisplayNodeLayout.mm in Sources */ = {isa = PBXBuildFile; fileRef = 6959433C1D70815300B0EE1F /* ASDisplayNodeLayout.mm */; }; 695943401D70815300B0EE1F /* ASDisplayNodeLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 6959433D1D70815300B0EE1F /* ASDisplayNodeLayout.h */; }; @@ -979,7 +978,6 @@ 68FC85E11CE29B7E00EDD713 /* ASTabBarController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ASTabBarController.m; sourceTree = ""; }; 68FC85E71CE29C7D00EDD713 /* ASVisibilityProtocols.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASVisibilityProtocols.h; sourceTree = ""; }; 68FC85E81CE29C7D00EDD713 /* ASVisibilityProtocols.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ASVisibilityProtocols.m; sourceTree = ""; }; - 690457F61DB5131A00B5EE68 /* ASLayoutPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ASLayoutPrivate.h; path = AsyncDisplayKit/Layout/ASLayoutPrivate.h; sourceTree = ""; }; 6959433C1D70815300B0EE1F /* ASDisplayNodeLayout.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ASDisplayNodeLayout.mm; sourceTree = ""; }; 6959433D1D70815300B0EE1F /* ASDisplayNodeLayout.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ASDisplayNodeLayout.h; sourceTree = ""; }; 696FCB301D6E46050093471E /* ASBackgroundLayoutSpecSnapshotTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ASBackgroundLayoutSpecSnapshotTests.mm; sourceTree = ""; }; @@ -1712,7 +1710,6 @@ 9C49C36E1B853957000B0DD5 /* ASStackLayoutElement.h */, ACF6ED161B17843500DA7C62 /* ASStackLayoutSpec.h */, ACF6ED171B17843500DA7C62 /* ASStackLayoutSpec.mm */, - 690457F61DB5131A00B5EE68 /* ASLayoutPrivate.h */, ); name = Layout; path = ..; @@ -1762,7 +1759,6 @@ 9C70F20D1CDBE9CB007D6C76 /* ASDefaultPlayButton.h in Headers */, 68355B411CB57A6C001D4E68 /* ASImageContainerProtocolCategories.h in Headers */, 7630FFA81C9E267E007A7C0E /* ASVideoNode.h in Headers */, - 690457F71DB5131A00B5EE68 /* ASLayoutPrivate.h in Headers */, B350623F1B010EFD0018CF92 /* _ASAsyncTransactionContainer.h in Headers */, B13CA1011C52004900E031AB /* ASCollectionNode+Beta.h in Headers */, 254C6B7E1BF94DF4003EC431 /* ASTextKitTailTruncater.h in Headers */, diff --git a/AsyncDisplayKit/ASDisplayNode.mm b/AsyncDisplayKit/ASDisplayNode.mm index e6ca7b9269..edb1967acf 100644 --- a/AsyncDisplayKit/ASDisplayNode.mm +++ b/AsyncDisplayKit/ASDisplayNode.mm @@ -30,7 +30,7 @@ #import "ASLayoutElementStylePrivate.h" #import "ASInternalHelpers.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" #import "ASLayoutSpec.h" #import "ASCellNode+Internal.h" #import "ASWeakProxy.h" diff --git a/AsyncDisplayKit/Layout/ASAbsoluteLayoutSpec.mm b/AsyncDisplayKit/Layout/ASAbsoluteLayoutSpec.mm index 6b6ff05832..38be927ef6 100644 --- a/AsyncDisplayKit/Layout/ASAbsoluteLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASAbsoluteLayoutSpec.mm @@ -11,7 +11,7 @@ #import "ASAbsoluteLayoutSpec.h" #import "ASLayout.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" #import "ASLayoutSpecUtilities.h" #import "ASLayoutElementStylePrivate.h" diff --git a/AsyncDisplayKit/Layout/ASBackgroundLayoutSpec.mm b/AsyncDisplayKit/Layout/ASBackgroundLayoutSpec.mm index 3020f4cc86..a94c051a6b 100644 --- a/AsyncDisplayKit/Layout/ASBackgroundLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASBackgroundLayoutSpec.mm @@ -10,9 +10,7 @@ #import "ASBackgroundLayoutSpec.h" #import "ASLayoutSpec+Subclasses.h" - #import "ASAssert.h" -#import "ASLayoutPrivate.h" static NSUInteger const kForegroundChildIndex = 0; static NSUInteger const kBackgroundChildIndex = 1; diff --git a/AsyncDisplayKit/Layout/ASInsetLayoutSpec.mm b/AsyncDisplayKit/Layout/ASInsetLayoutSpec.mm index ca20eadc51..156975a17d 100644 --- a/AsyncDisplayKit/Layout/ASInsetLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASInsetLayoutSpec.mm @@ -9,11 +9,9 @@ // #import "ASInsetLayoutSpec.h" - #import "ASAssert.h" - +#import "ASLayoutSpec+Subclasses.h" #import "ASInternalHelpers.h" -#import "ASLayoutPrivate.h" @interface ASInsetLayoutSpec () { diff --git a/AsyncDisplayKit/Layout/ASLayout.mm b/AsyncDisplayKit/Layout/ASLayout.mm index 3b3c4a76b7..b2f992fe11 100644 --- a/AsyncDisplayKit/Layout/ASLayout.mm +++ b/AsyncDisplayKit/Layout/ASLayout.mm @@ -8,11 +8,10 @@ // of patent rights can be found in the PATENTS file in the same directory. // -#import "ASLayoutPrivate.h" - #import "ASDimension.h" #import "ASInternalHelpers.h" #import "ASLayoutSpecUtilities.h" +#import "ASLayoutSpec+Subclasses.h" #import #import "ASObjectDescriptionHelpers.h" diff --git a/AsyncDisplayKit/Layout/ASLayoutPrivate.h b/AsyncDisplayKit/Layout/ASLayoutPrivate.h deleted file mode 100644 index 1a2ac3d388..0000000000 --- a/AsyncDisplayKit/Layout/ASLayoutPrivate.h +++ /dev/null @@ -1,25 +0,0 @@ -// -// ASLayoutPrivate.h -// AsyncDisplayKit -// -// Created by Michael Schneider on 10/17/16. -// Copyright © 2016 Facebook. All rights reserved. -// - -#pragma once - -#import "ASLayout.h" - -/** - * Private header of ASLayout for internal usage in the framework - */ -@interface ASLayout () - -/** - * Position in parent. Default to CGPointNull. - * - * @discussion When being used as a sublayout, this property must not equal CGPointNull. - */ -@property (nonatomic, assign, readwrite) CGPoint position; - -@end diff --git a/AsyncDisplayKit/Layout/ASLayoutSpec+Subclasses.h b/AsyncDisplayKit/Layout/ASLayoutSpec+Subclasses.h index 60c66a9106..84d5a9db35 100644 --- a/AsyncDisplayKit/Layout/ASLayoutSpec+Subclasses.h +++ b/AsyncDisplayKit/Layout/ASLayoutSpec+Subclasses.h @@ -61,4 +61,15 @@ NS_ASSUME_NONNULL_BEGIN @end +@interface ASLayout () + +/** + * Position in parent. Default to CGPointNull. + * + * @discussion When being used as a sublayout, this property must not equal CGPointNull. + */ +@property (nonatomic, assign, readwrite) CGPoint position; + +@end + NS_ASSUME_NONNULL_END diff --git a/AsyncDisplayKit/Layout/ASLayoutSpec.mm b/AsyncDisplayKit/Layout/ASLayoutSpec.mm index fec8c53be7..3aa316aab2 100644 --- a/AsyncDisplayKit/Layout/ASLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASLayoutSpec.mm @@ -11,7 +11,6 @@ #import "ASLayoutSpec.h" #import "ASLayoutSpecPrivate.h" #import "ASLayoutSpec+Subclasses.h" -#import "ASLayoutPrivate.h" #import "ASLayoutElementStylePrivate.h" @implementation ASLayoutSpec diff --git a/AsyncDisplayKit/Layout/ASOverlayLayoutSpec.mm b/AsyncDisplayKit/Layout/ASOverlayLayoutSpec.mm index fb0b939fbf..b38fe83a86 100644 --- a/AsyncDisplayKit/Layout/ASOverlayLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASOverlayLayoutSpec.mm @@ -12,7 +12,7 @@ #import "ASLayoutSpec+Subclasses.h" #import "ASAssert.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" static NSUInteger const kUnderlayChildIndex = 0; static NSUInteger const kOverlayChildIndex = 1; diff --git a/AsyncDisplayKit/Layout/ASRatioLayoutSpec.mm b/AsyncDisplayKit/Layout/ASRatioLayoutSpec.mm index 00c1d584f3..1155af720e 100644 --- a/AsyncDisplayKit/Layout/ASRatioLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASRatioLayoutSpec.mm @@ -17,7 +17,7 @@ #import "ASAssert.h" #import "ASInternalHelpers.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" #pragma mark - ASRatioLayoutSpec diff --git a/AsyncDisplayKit/Layout/ASRelativeLayoutSpec.mm b/AsyncDisplayKit/Layout/ASRelativeLayoutSpec.mm index d8f9bd717a..1072fb443d 100644 --- a/AsyncDisplayKit/Layout/ASRelativeLayoutSpec.mm +++ b/AsyncDisplayKit/Layout/ASRelativeLayoutSpec.mm @@ -13,7 +13,7 @@ #import "ASRelativeLayoutSpec.h" #import "ASInternalHelpers.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" @implementation ASRelativeLayoutSpec diff --git a/AsyncDisplayKit/Private/ASStackBaselinePositionedLayout.mm b/AsyncDisplayKit/Private/ASStackBaselinePositionedLayout.mm index 5c0a86cbe9..081d7cf42c 100644 --- a/AsyncDisplayKit/Private/ASStackBaselinePositionedLayout.mm +++ b/AsyncDisplayKit/Private/ASStackBaselinePositionedLayout.mm @@ -11,7 +11,7 @@ #import "ASStackBaselinePositionedLayout.h" #import "ASLayoutSpecUtilities.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" static CGFloat baselineForItem(const ASStackLayoutSpecStyle &style, const ASLayout *layout) { diff --git a/AsyncDisplayKit/Private/ASStackPositionedLayout.mm b/AsyncDisplayKit/Private/ASStackPositionedLayout.mm index 16fdd9ea1a..f00478b67a 100644 --- a/AsyncDisplayKit/Private/ASStackPositionedLayout.mm +++ b/AsyncDisplayKit/Private/ASStackPositionedLayout.mm @@ -14,7 +14,7 @@ #import "ASInternalHelpers.h" #import "ASLayoutSpecUtilities.h" -#import "ASLayoutPrivate.h" +#import "ASLayoutSpec+Subclasses.h" static CGFloat crossOffset(const ASStackLayoutSpecStyle &style, const ASStackUnpositionedItem &l,