ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-22 22:25:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix retain cycle in basic, cache-less ASNetworkImageNodes

Browse Source 
This should not directly affect more complex apps that don't use the ASBasicImageDownloader.

Also disables the default-on text placeholders, as they churn memory during the measurement pass.
These were intended to be written with pure layers (without using backing stores), so I don't
think it is a reasonable default-on behavior until that is fixed.
This commit is contained in:
Scott Goodson
2015-10-30 22:42:05 -07:00
parent ed63577370
commit 3175ce2fe7
7 changed files with 31 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
AsyncDisplayKit/ASNetworkImageNode.h
View File

@@ -23,10 +23,10 @@
@interface ASNetworkImageNode : ASImageNode
/**
* The designated initializer.
* The designated initializer. Cache and Downloader are WEAK references.
*
* @param cache The object that implements a cache of images for the image node.
* @param downloader The object that implements image downloading for the image node. Must not be nil.
* @param cache The object that implements a cache of images for the image node. Weak reference.
* @param downloader The object that implements image downloading for the image node. Must not be nil. Weak reference.
*
* @discussion If `cache` is nil, the receiver will not attempt to retrieve images from a cache before downloading them.
*