ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-23 06:35:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix retain cycle in basic, cache-less ASNetworkImageNodes

Browse Source 
This should not directly affect more complex apps that don't use the ASBasicImageDownloader.

Also disables the default-on text placeholders, as they churn memory during the measurement pass.
These were intended to be written with pure layers (without using backing stores), so I don't
think it is a reasonable default-on behavior until that is fixed.
This commit is contained in:
Scott Goodson
2015-10-30 22:42:05 -07:00
parent ed63577370
commit 3175ce2fe7
7 changed files with 31 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
AsyncDisplayKit/ASNetworkImageNode.mm
View File

@@ -16,8 +16,8 @@
@interface ASNetworkImageNode ()
{
ASDN::RecursiveMutex _lock;
id<ASImageCacheProtocol> _cache;
id<ASImageDownloaderProtocol> _downloader;
__weak id<ASImageCacheProtocol> _cache;
__weak id<ASImageDownloaderProtocol> _downloader;
// Only access any of these with _lock.
__weak id<ASNetworkImageNodeDelegate> _delegate;
@@ -51,7 +51,7 @@
- (instancetype)init
{
return [self initWithCache:nil downloader:[[ASBasicImageDownloader alloc] init]];
return [self initWithCache:nil downloader:[ASBasicImageDownloader sharedImageDownloader]];
}
- (void)dealloc