From 47b53d9293698b482b95ef42a07060eae9075fa9 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Wed, 4 Mar 2015 11:09:02 -0800 Subject: [PATCH] Stricter build flags for ASDK and tests --- AsyncDisplayKit.xcodeproj/project.pbxproj | 6 ++++++ AsyncDisplayKitTests/ASBatchFetchingTests.m | 18 +++++++++--------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/AsyncDisplayKit.xcodeproj/project.pbxproj b/AsyncDisplayKit.xcodeproj/project.pbxproj index b2a8abd2e5..552133d2ab 100644 --- a/AsyncDisplayKit.xcodeproj/project.pbxproj +++ b/AsyncDisplayKit.xcodeproj/project.pbxproj @@ -966,6 +966,7 @@ GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "AsyncDisplayKit/AsyncDisplayKit-Prefix.pch"; GCC_TREAT_WARNINGS_AS_ERRORS = YES; + GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES; OTHER_CFLAGS = "-Wall"; OTHER_LDFLAGS = "-ObjC"; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -982,6 +983,7 @@ GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "AsyncDisplayKit/AsyncDisplayKit-Prefix.pch"; GCC_TREAT_WARNINGS_AS_ERRORS = YES; + GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES; OTHER_CFLAGS = "-Wall"; OTHER_LDFLAGS = "-ObjC"; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -1005,6 +1007,8 @@ "DEBUG=1", "$(inherited)", ); + GCC_TREAT_WARNINGS_AS_ERRORS = YES; + GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES; INFOPLIST_FILE = "AsyncDisplayKitTests/AsyncDisplayKitTests-Info.plist"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = xctest; @@ -1022,6 +1026,8 @@ ); GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "AsyncDisplayKit/AsyncDisplayKit-Prefix.pch"; + GCC_TREAT_WARNINGS_AS_ERRORS = YES; + GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES; INFOPLIST_FILE = "AsyncDisplayKitTests/AsyncDisplayKitTests-Info.plist"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = xctest; diff --git a/AsyncDisplayKitTests/ASBatchFetchingTests.m b/AsyncDisplayKitTests/ASBatchFetchingTests.m index 3b009cdda3..324f113ec1 100644 --- a/AsyncDisplayKitTests/ASBatchFetchingTests.m +++ b/AsyncDisplayKitTests/ASBatchFetchingTests.m @@ -16,15 +16,15 @@ @implementation ASBatchFetchingTests -#define PASSING_RECT (CGRect){0,0,1,1} -#define PASSING_SIZE (CGSize){1,1} -#define PASSING_POINT (CGPoint){1,1} -#define VERTICAL_RECT(h) (CGRect){0,0,0,h} -#define VERTICAL_SIZE(h) (CGSize){0,h} -#define VERTICAL_OFFSET(y) (CGPoint){0,y} -#define HORIZONTAL_RECT(w) (CGRect){0,0,w,0} -#define HORIZONTAL_SIZE(w) (CGSize){w,0} -#define HORIZONTAL_OFFSET(x) (CGPoint){x,0} +#define PASSING_RECT CGRectMake(0,0,1,1) +#define PASSING_SIZE CGSizeMake(1,1) +#define PASSING_POINT CGPointMake(1,1) +#define VERTICAL_RECT(h) CGRectMake(0,0,0,h) +#define VERTICAL_SIZE(h) CGSizeMake(0,h) +#define VERTICAL_OFFSET(y) CGPointMake(0,y) +#define HORIZONTAL_RECT(w) CGRectMake(0,0,w,0) +#define HORIZONTAL_SIZE(w) CGSizeMake(w,0) +#define HORIZONTAL_OFFSET(x) CGPointMake(x,0) - (void)testBatchNullState { ASBatchContext *context = [[ASBatchContext alloc] init];