From 52091eb5897bf4f8c98962342cdc52765b7b452c Mon Sep 17 00:00:00 2001 From: rcancro <@pinterest.com> Date: Wed, 23 Sep 2015 16:11:46 -0700 Subject: [PATCH] Placeholder bug in ASEditableTextNode When setting a default placeholder and an attributedString before `_textKitComponents.textView` was created, the placeholder and the string were both appearing in the text node. `_updateDisplayingPlaceholder` is called in `setAttributedString`, but since `_textKitComponents.textView` is nil the placeholder was not hidden. Calling `_updateDisplayingPlaceholder` after `_textKitComponents.textView` loads fixes this. --- AsyncDisplayKit/ASEditableTextNode.mm | 1 + 1 file changed, 1 insertion(+) diff --git a/AsyncDisplayKit/ASEditableTextNode.mm b/AsyncDisplayKit/ASEditableTextNode.mm index 5e8156a86a..e6b5399edf 100644 --- a/AsyncDisplayKit/ASEditableTextNode.mm +++ b/AsyncDisplayKit/ASEditableTextNode.mm @@ -143,6 +143,7 @@ _textKitComponents.textView.accessibilityHint = _placeholderTextKitComponents.textStorage.string; configureTextView(_textKitComponents.textView); [self.view addSubview:_textKitComponents.textView]; + [self _updateDisplayingPlaceholder]; } - (CGSize)calculateSizeThatFits:(CGSize)constrainedSize