Disable Text Node Fast Path (#2581)

* Disable text node fast path

* Actually commit the test change

AsyncDisplayKit/TextKit/ASTextKitRenderer.mm

@@ -205,12 +205,15 @@ static NSCharacterSet *_defaultAvoidTruncationCharacterSet()
 
 - (BOOL)canUseFastPath
 {
-  return self.isScaled == NO
+  return NO;
-    && self.usesCustomTruncation == NO
+//  Fast path is temporarily disabled, because it's crashing in production.
-    && self.usesExclusionPaths == NO
+//  NOTE: Remember to re-enable testFastPathTruncation when we re-enable this.
-    // NSAttributedString drawing methods ignore usesLineFragmentOrigin if max line count 1,
+//  return self.isScaled == NO
-    // rendering them useless:
+//    && self.usesCustomTruncation == NO
-    && (_attributes.maximumNumberOfLines != 1 || isinf(_constrainedSize.width));
+//    && self.usesExclusionPaths == NO
+//    // NSAttributedString drawing methods ignore usesLineFragmentOrigin if max line count 1,
+//    // rendering them useless:
+//    && (_attributes.maximumNumberOfLines != 1 || isinf(_constrainedSize.width));
 }
 
 #pragma mark - Drawing

AsyncDisplayKitTests/ASTextNodeSnapshotTests.m

@@ -75,7 +75,8 @@
   ASSnapshotVerifyView(backgroundView, nil);
 }
 
-- (void)testThatFastPathTruncationWorks
+// This test is disabled because the fast-path is disabled.
+- (void)DISABLED_testThatFastPathTruncationWorks
 {
   ASTextNode *textNode = [[ASTextNode alloc] init];
   textNode.attributedText = [[NSAttributedString alloc] initWithString:@"Quality is Important" attributes:@{ NSForegroundColorAttributeName: [UIColor blueColor], NSFontAttributeName: [UIFont italicSystemFontOfSize:24] }];
@@ -87,8 +88,9 @@
 {
   ASTextNode *textNode = [[ASTextNode alloc] init];
   textNode.attributedText = [[NSAttributedString alloc] initWithString:@"Quality is Important" attributes:@{ NSForegroundColorAttributeName: [UIColor blueColor], NSFontAttributeName: [UIFont italicSystemFontOfSize:24] }];
-  [textNode layoutThatFits:ASSizeRangeMake(CGSizeZero, CGSizeMake(100, 50))];
+  // Set exclusion paths to trigger slow path
   textNode.exclusionPaths = @[ [UIBezierPath bezierPath] ];
+  [textNode layoutThatFits:ASSizeRangeMake(CGSizeZero, CGSizeMake(100, 50))];
   ASSnapshotVerifyNode(textNode, nil);
 }