From 657277e90773a4e25f028dd540e2ffd8257abb0e Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Mon, 22 Oct 2012 01:10:58 +0200 Subject: [PATCH] Fix implemented delegates for userid, name and email cause the feedback userUI not to show anything --- Classes/BITFeedbackManager.m | 39 ++++++++++++++++++++++-------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/Classes/BITFeedbackManager.m b/Classes/BITFeedbackManager.m index a25c101a77..e374bc2c00 100644 --- a/Classes/BITFeedbackManager.m +++ b/Classes/BITFeedbackManager.m @@ -228,27 +228,36 @@ - (void)updateAppDefinedUserData { if ([BITHockeyManager sharedHockeyManager].delegate && [[BITHockeyManager sharedHockeyManager].delegate respondsToSelector:@selector(userIDForHockeyManager:componentManager:)]) { - self.userID = [[BITHockeyManager sharedHockeyManager].delegate - userIDForHockeyManager:[BITHockeyManager sharedHockeyManager] - componentManager:self]; - self.requireUserName = BITFeedbackUserDataElementDontShow; - self.requireUserEmail = BITFeedbackUserDataElementDontShow; + NSString *userID = [[BITHockeyManager sharedHockeyManager].delegate + userIDForHockeyManager:[BITHockeyManager sharedHockeyManager] + componentManager:self]; + if (self.userID) { + self.userID = userID; + self.requireUserName = BITFeedbackUserDataElementDontShow; + self.requireUserEmail = BITFeedbackUserDataElementDontShow; + } } if ([BITHockeyManager sharedHockeyManager].delegate && [[BITHockeyManager sharedHockeyManager].delegate respondsToSelector:@selector(userNameForHockeyManager:componentManager:)]) { - self.userName = [[BITHockeyManager sharedHockeyManager].delegate - userNameForHockeyManager:[BITHockeyManager sharedHockeyManager] - componentManager:self]; - self.requireUserName = BITFeedbackUserDataElementDontShow; - self.requireUserEmail = BITFeedbackUserDataElementDontShow; + NSString *userName = [[BITHockeyManager sharedHockeyManager].delegate + userNameForHockeyManager:[BITHockeyManager sharedHockeyManager] + componentManager:self]; + if (userName) { + self.userName = userName; + self.requireUserName = BITFeedbackUserDataElementDontShow; + self.requireUserEmail = BITFeedbackUserDataElementDontShow; + } } if ([BITHockeyManager sharedHockeyManager].delegate && [[BITHockeyManager sharedHockeyManager].delegate respondsToSelector:@selector(userEmailForHockeyManager:componentManager:)]) { - self.userEmail = [[BITHockeyManager sharedHockeyManager].delegate - userEmailForHockeyManager:[BITHockeyManager sharedHockeyManager] - componentManager:self]; - self.requireUserName = BITFeedbackUserDataElementDontShow; - self.requireUserEmail = BITFeedbackUserDataElementDontShow; + NSString *userEmail = [[BITHockeyManager sharedHockeyManager].delegate + userEmailForHockeyManager:[BITHockeyManager sharedHockeyManager] + componentManager:self]; + if (userEmail) { + self.userEmail = userEmail; + self.requireUserName = BITFeedbackUserDataElementDontShow; + self.requireUserEmail = BITFeedbackUserDataElementDontShow; + } } }