From 696f344301b0adca156b3580b14853edc23ff7bb Mon Sep 17 00:00:00 2001 From: Eric Jensen Date: Thu, 20 Sep 2018 07:54:10 -0700 Subject: [PATCH] Fix compilation warnings #trivial (#1132) * Apply recommended warnings * Squelch designated initializer warning in ASViewController * Remove unused compiler flag clang: warning: argument unused during compilation: '-fno-objc-arc-exceptions' [-Wunused-command-line-argument] * Fix warning about overriding an instance variable within a category Instance method 'methodOverrides' in category from _ASDisplayView.o overrides method from class in ASDisplayNode.o --- AsyncDisplayKit.xcodeproj/project.pbxproj | 14 ++++++++++---- .../xcschemes/AsyncDisplayKit.xcscheme | 2 +- Source/ASDisplayNode.mm | 5 +++++ Source/ASViewController.mm | 5 +++++ Source/Details/_ASDisplayView.mm | 14 -------------- Source/Private/ASDisplayNodeInternal.h | 2 +- Texture.podspec | 2 +- 7 files changed, 23 insertions(+), 21 deletions(-) diff --git a/AsyncDisplayKit.xcodeproj/project.pbxproj b/AsyncDisplayKit.xcodeproj/project.pbxproj index bb70ae7d7b..305b392e1c 100644 --- a/AsyncDisplayKit.xcodeproj/project.pbxproj +++ b/AsyncDisplayKit.xcodeproj/project.pbxproj @@ -2128,7 +2128,7 @@ isa = PBXProject; attributes = { CLASSPREFIX = AS; - LastUpgradeCheck = 0820; + LastUpgradeCheck = 0940; ORGANIZATIONNAME = Pinterest; TargetAttributes = { 057D02BE1AC0A66700C7AC3C = { @@ -2586,6 +2586,7 @@ CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; + CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; @@ -2618,7 +2619,9 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; + GCC_WARN_UNKNOWN_PRAGMAS = YES; GCC_WARN_UNUSED_FUNCTION = YES; + GCC_WARN_UNUSED_LABEL = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; ONLY_ACTIVE_ARCH = YES; @@ -2640,6 +2643,7 @@ CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; + CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; @@ -2662,7 +2666,9 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; + GCC_WARN_UNKNOWN_PRAGMAS = YES; GCC_WARN_UNUSED_FUNCTION = YES; + GCC_WARN_UNUSED_LABEL = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; SDKROOT = iphoneos; @@ -2741,7 +2747,6 @@ OTHER_CFLAGS = ( "-Wundef", "-fno-exceptions", - "-fno-objc-arc-exceptions", ); PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = AsyncDisplayKit; @@ -2774,7 +2779,6 @@ OTHER_CFLAGS = ( "-Wundef", "-fno-exceptions", - "-fno-objc-arc-exceptions", ); PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = AsyncDisplayKit; @@ -2797,6 +2801,7 @@ CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; + CLANG_WARN_DOCUMENTATION_COMMENTS = YES; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; @@ -2819,7 +2824,9 @@ GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; + GCC_WARN_UNKNOWN_PRAGMAS = YES; GCC_WARN_UNUSED_FUNCTION = YES; + GCC_WARN_UNUSED_LABEL = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; SDKROOT = iphoneos; @@ -2892,7 +2899,6 @@ OTHER_CFLAGS = ( "-Wundef", "-fno-exceptions", - "-fno-objc-arc-exceptions", ); PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = AsyncDisplayKit; diff --git a/AsyncDisplayKit.xcodeproj/xcshareddata/xcschemes/AsyncDisplayKit.xcscheme b/AsyncDisplayKit.xcodeproj/xcshareddata/xcschemes/AsyncDisplayKit.xcscheme index 8cf72597a3..f06fd13c88 100644 --- a/AsyncDisplayKit.xcodeproj/xcshareddata/xcschemes/AsyncDisplayKit.xcscheme +++ b/AsyncDisplayKit.xcodeproj/xcshareddata/xcschemes/AsyncDisplayKit.xcscheme @@ -1,6 +1,6 @@ #import -#pragma mark - ASDisplayNode - -/** - * Open access to the method overrides struct for ASDisplayView - */ -@implementation ASDisplayNode (ASDisplayNodeMethodOverrides_ASDisplayView) - -- (ASDisplayNodeMethodOverrides)methodOverrides -{ - return _methodOverrides; -} - -@end - #pragma mark - _ASDisplayViewMethodOverrides typedef NS_OPTIONS(NSUInteger, _ASDisplayViewMethodOverrides) diff --git a/Source/Private/ASDisplayNodeInternal.h b/Source/Private/ASDisplayNodeInternal.h index 96b4cb2f4b..5f9092ffaa 100644 --- a/Source/Private/ASDisplayNodeInternal.h +++ b/Source/Private/ASDisplayNodeInternal.h @@ -261,7 +261,7 @@ AS_EXTERN NSString * const ASRenderingEngineDidDisplayNodesScheduledBeforeTimest @property (nullable, nonatomic, readonly) _ASDisplayLayer *asyncLayer; /// Bitmask to check which methods an object overrides. -@property (nonatomic, readonly) ASDisplayNodeMethodOverrides methodOverrides; +- (ASDisplayNodeMethodOverrides)methodOverrides; /** * Invoked before a call to setNeedsLayout to the underlying view diff --git a/Texture.podspec b/Texture.podspec index 0ec19ce157..c64e8df22c 100644 --- a/Texture.podspec +++ b/Texture.podspec @@ -16,7 +16,7 @@ Pod::Spec.new do |spec| # Subspecs spec.subspec 'Core' do |core| - core.compiler_flags = '-fno-exceptions -fno-objc-arc-exceptions' + core.compiler_flags = '-fno-exceptions' core.public_header_files = [ 'Source/*.h', 'Source/Details/**/*.h',