From 7f4b4a2bc27d34a0b6e051a39f6535ee003c8f91 Mon Sep 17 00:00:00 2001 From: Ali <> Date: Sun, 24 Jan 2021 11:56:13 +0400 Subject: [PATCH 1/5] Simplify build scripts --- buildbox/build-telegram.sh | 33 +++++++------------ buildbox/guest-build-telegram.sh | 54 +++++--------------------------- 2 files changed, 18 insertions(+), 69 deletions(-) diff --git a/buildbox/build-telegram.sh b/buildbox/build-telegram.sh index c1e4905153..57ce322f6a 100644 --- a/buildbox/build-telegram.sh +++ b/buildbox/build-telegram.sh @@ -99,30 +99,25 @@ if [ "$BUILD_CONFIGURATION" == "hockeyapp" ] || [ "$BUILD_CONFIGURATION" == "app mkdir -p "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" case "$BUILD_CONFIGURATION" in - "hockeyapp") + "hockeyapp"|"appcenter-experimental"|"appcenter-experimental-2") generate-configuration.sh internal release "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning" "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" ;; + "appstore") + generate-configuration.sh appstore release "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning" "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" + ;; + *) echo "Unknown build configuration $BUILD_CONFIGURATION" exit 1 ;; esac +elif [ "$BUILD_CONFIGURATION" == "verify" ]; then + mkdir -p "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning" + mkdir -p "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" - if [ "$BUILD_CONFIGURATION" == "appstore" ]; then - if [ -z "$TELEGRAM_BUILD_APPSTORE_PASSWORD" ]; then - echo "TELEGRAM_BUILD_APPSTORE_PASSWORD is not set" - exit 1 - fi - if [ -z "$TELEGRAM_BUILD_APPSTORE_TEAM_NAME" ]; then - echo "TELEGRAM_BUILD_APPSTORE_TEAM_NAME is not set" - exit 1 - fi - if [ -z "$TELEGRAM_BUILD_APPSTORE_USERNAME" ]; then - echo "TELEGRAM_BUILD_APPSTORE_USERNAME is not set" - exit 1 - fi - fi + cp -R fake-codesigning/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning/" + cp -R build-system/example-configuration/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration/" fi if [ ! -d "$BUILDBOX_DIR/$CODESIGNING_SUBPATH" ]; then @@ -184,16 +179,10 @@ fi scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/$CODESIGNING_SUBPATH" telegram@"$VM_IP":codesigning_data scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" telegram@"$VM_IP":telegram-configuration -#scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/$CODESIGNING_TEAMS_SUBPATH" telegram@"$VM_IP":codesigning_teams -#if [ "$BUILD_CONFIGURATION" == "verify" ]; then -# ssh -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null telegram@"$VM_IP" -o ServerAliveInterval=60 -t "mkdir -p telegram-ios-shared/fastlane; echo '' > telegram-ios-shared/fastlane/Fastfile" -#else -# scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/transient-data/telegram-ios-shared" telegram@"$VM_IP":telegram-ios-shared -#fi scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/guest-build-telegram.sh" "$BUILDBOX_DIR/transient-data/source.tar" telegram@"$VM_IP": -ssh -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null telegram@"$VM_IP" -o ServerAliveInterval=60 -t "export TELEGRAM_BUILD_APPSTORE_PASSWORD=\"$TELEGRAM_BUILD_APPSTORE_PASSWORD\"; export TELEGRAM_BUILD_APPSTORE_TEAM_NAME=\"$TELEGRAM_BUILD_APPSTORE_TEAM_NAME\"; export TELEGRAM_BUILD_APPSTORE_USERNAME=\"$TELEGRAM_BUILD_APPSTORE_USERNAME\"; export BUILD_NUMBER=\"$BUILD_NUMBER\"; export COMMIT_ID=\"$COMMIT_ID\"; export COMMIT_AUTHOR=\"$COMMIT_AUTHOR\"; export BAZEL_HTTP_CACHE_URL=\"$BAZEL_HTTP_CACHE_URL\"; $GUEST_SHELL -l guest-build-telegram.sh $BUILD_CONFIGURATION" || true +ssh -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null telegram@"$VM_IP" -o ServerAliveInterval=60 -t "export BUILD_NUMBER=\"$BUILD_NUMBER\"; export BAZEL_HTTP_CACHE_URL=\"$BAZEL_HTTP_CACHE_URL\"; $GUEST_SHELL -l guest-build-telegram.sh $BUILD_CONFIGURATION" || true OUTPUT_PATH="build/artifacts" rm -rf "$OUTPUT_PATH" diff --git a/buildbox/guest-build-telegram.sh b/buildbox/guest-build-telegram.sh index d540abab4d..bda9a5930d 100644 --- a/buildbox/guest-build-telegram.sh +++ b/buildbox/guest-build-telegram.sh @@ -7,31 +7,14 @@ if [ -z "BUILD_NUMBER" ]; then exit 1 fi -if [ -z "COMMIT_ID" ]; then - echo "COMMIT_ID is not set" - exit 1 -fi - if [ "$1" == "hockeyapp" ] || [ "$1" == "appcenter-experimental" ] || [ "$1" == "appcenter-experimental-2" ] || [ "$1" == "testinghockeyapp" ]; then CERTS_PATH="$HOME/codesigning_data/certs/enterprise" - #PROFILES_PATH="$HOME/codesigning_data/profiles" elif [ "$1" == "testinghockeyapp-local" ]; then - CERTS_PATH="$HOME/codesigning_data/certs" - PROFILES_PATH="$HOME/codesigning_data/profiles" + CERTS_PATH="$HOME/codesigning_data/certs/enterprise" elif [ "$1" == "appstore" ]; then - if [ -z "$TELEGRAM_BUILD_APPSTORE_PASSWORD" ]; then - echo "TELEGRAM_BUILD_APPSTORE_PASSWORD is not set" - exit 1 - fi - if [ -z "$TELEGRAM_BUILD_APPSTORE_TEAM_NAME" ]; then - echo "TELEGRAM_BUILD_APPSTORE_TEAM_NAME is not set" - exit 1 - fi - CERTS_PATH="$HOME/codesigning_data/certs" - PROFILES_PATH="$HOME/codesigning_data/profiles" + CERTS_PATH="$HOME/codesigning_data/certs/distribution" elif [ "$1" == "verify" ]; then - CERTS_PATH="build-system/fake-codesigning/certs/distribution" - PROFILES_PATH="build-system/fake-codesigning/profiles" + CERTS_PATH="$HOME/codesigning_data/certs/distribution" else echo "Unknown configuration $1" exit 1 @@ -95,47 +78,24 @@ done security set-key-partition-list -S apple-tool:,apple: -k "$MY_KEYCHAIN_PASSWORD" "$MY_KEYCHAIN" -#mkdir -p "$HOME/Library/MobileDevice/Provisioning Profiles" - -#for f in $(ls "$PROFILES_PATH"); do -# PROFILE_PATH="$PROFILES_PATH/$f" -# uuid=`grep UUID -A1 -a "$PROFILE_PATH" | grep -io "[-A-F0-9]\{36\}"` -# cp -f "$PROFILE_PATH" "$HOME/Library/MobileDevice/Provisioning Profiles/$uuid.mobileprovision" -#done - if [ "$1" == "hockeyapp" ] || [ "$1" == "appcenter-experimental" ] || [ "$1" == "appcenter-experimental-2" ]; then - #BUILD_ENV_SCRIPT="../telegram-ios-shared/buildbox/bin/internal.sh" - #APP_TARGET="bazel_app_arm64" - echo "" >> /dev/null + APP_CONFIGURATION="release_arm64" elif [ "$1" == "appstore" ]; then - BUILD_ENV_SCRIPT="../telegram-ios-shared/buildbox/bin/appstore.sh" - APP_TARGET="bazel_app" + APP_CONFIGURATION="release_universal" elif [ "$1" == "verify" ]; then - BUILD_ENV_SCRIPT="build-system/verify.sh" - APP_TARGET="bazel_app" - export CODESIGNING_DATA_PATH="build-system/fake-codesigning" - export CODESIGNING_CERTS_VARIANT="distribution" - export CODESIGNING_PROFILES_VARIANT="appstore" + APP_CONFIGURATION="release_universal" else echo "Unsupported configuration $1" exit 1 fi -if [ "$1" == "appcenter-experimental" ]; then - export APP_CENTER_ID="$APP_CENTER_EXPERIMENTAL_ID" -elif [ "$1" == "appcenter-experimental-2" ]; then - export APP_CENTER_ID="$APP_CENTER_EXPERIMENTAL_2_ID" -fi - -#PATH="$PATH:$(pwd)/tools" BAZEL_HTTP_CACHE_URL="$BAZEL_HTTP_CACHE_URL" LOCAL_CODESIGNING=1 sh "$BUILD_ENV_SCRIPT" make "$APP_TARGET" - python3 build-system/Make/Make.py \ --bazel="$(pwd)/tools/bazel" \ --cacheHost="$BAZEL_HTTP_CACHE_URL" \ build \ --configurationPath="$HOME/telegram-configuration" \ --buildNumber="$BUILD_NUMBER" \ - --configuration=release_arm64 + --configuration="$APP_CONFIGURATION" OUTPUT_PATH="build/artifacts" rm -rf "$OUTPUT_PATH" From bd869d27fdca95b6304bf02c0a618c6116e7e4f5 Mon Sep 17 00:00:00 2001 From: Ali <> Date: Sun, 24 Jan 2021 12:20:37 +0400 Subject: [PATCH 2/5] Fix path --- buildbox/build-telegram.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildbox/build-telegram.sh b/buildbox/build-telegram.sh index 57ce322f6a..e7b15a60a1 100644 --- a/buildbox/build-telegram.sh +++ b/buildbox/build-telegram.sh @@ -61,7 +61,7 @@ if [ "$BUILD_CONFIGURATION" == "hockeyapp" ] || [ "$BUILD_CONFIGURATION" == "app CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" CODESIGNING_TEAMS_SUBPATH="transient-data/teams" elif [ "$BUILD_CONFIGURATION" == "appstore" ]; then - CODESIGNING_SUBPATH="transient-data/codesigning" + CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" CODESIGNING_TEAMS_SUBPATH="transient-data/teams" elif [ "$BUILD_CONFIGURATION" == "verify" ]; then CODESIGNING_SUBPATH="fake-codesigning" From d219fa02a660f443a34487de9e2c03c77ee55e45 Mon Sep 17 00:00:00 2001 From: Ali <> Date: Sun, 24 Jan 2021 21:37:03 +0500 Subject: [PATCH 3/5] Fix codesigning path --- buildbox/build-telegram.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/buildbox/build-telegram.sh b/buildbox/build-telegram.sh index e7b15a60a1..0fcd8d2255 100644 --- a/buildbox/build-telegram.sh +++ b/buildbox/build-telegram.sh @@ -59,12 +59,10 @@ BUILD_CONFIGURATION="$1" if [ "$BUILD_CONFIGURATION" == "hockeyapp" ] || [ "$BUILD_CONFIGURATION" == "appcenter-experimental" ] || [ "$BUILD_CONFIGURATION" == "appcenter-experimental-2" ]; then CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" - CODESIGNING_TEAMS_SUBPATH="transient-data/teams" elif [ "$BUILD_CONFIGURATION" == "appstore" ]; then CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" - CODESIGNING_TEAMS_SUBPATH="transient-data/teams" elif [ "$BUILD_CONFIGURATION" == "verify" ]; then - CODESIGNING_SUBPATH="fake-codesigning" + CODESIGNING_SUBPATH="build-system/fake-codesigning" else echo "Unknown configuration $1" exit 1 From 0419a9e958ba1ff357a01c3f2182f8ec0eae1bd7 Mon Sep 17 00:00:00 2001 From: Ali <> Date: Sun, 24 Jan 2021 22:02:31 +0500 Subject: [PATCH 4/5] Fix more --- buildbox/build-telegram.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildbox/build-telegram.sh b/buildbox/build-telegram.sh index 0fcd8d2255..a7f459f794 100644 --- a/buildbox/build-telegram.sh +++ b/buildbox/build-telegram.sh @@ -114,7 +114,7 @@ elif [ "$BUILD_CONFIGURATION" == "verify" ]; then mkdir -p "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning" mkdir -p "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" - cp -R fake-codesigning/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning/" + cp -R build-system/fake-codesigning/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/telegram-codesigning/" cp -R build-system/example-configuration/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration/" fi From 9b06f02b00480b07dc32a3641faaef50fb101d84 Mon Sep 17 00:00:00 2001 From: Ali <> Date: Mon, 25 Jan 2021 16:32:12 +0500 Subject: [PATCH 5/5] Temp --- .gitlab-ci.yml | 4 ++-- buildbox/build-telegram.sh | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ef4814cd9d..43df4ce6b6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -69,7 +69,7 @@ beta_testflight: - ios_beta stage: build only: - - beta + - beta1 except: - tags script: @@ -86,7 +86,7 @@ deploy_beta_testflight: - ios_beta stage: deploy only: - - beta + - beta1 except: - tags script: diff --git a/buildbox/build-telegram.sh b/buildbox/build-telegram.sh index a7f459f794..30ac3ed9b8 100644 --- a/buildbox/build-telegram.sh +++ b/buildbox/build-telegram.sh @@ -58,9 +58,9 @@ cp "$BAZEL" "tools/bazel" BUILD_CONFIGURATION="$1" if [ "$BUILD_CONFIGURATION" == "hockeyapp" ] || [ "$BUILD_CONFIGURATION" == "appcenter-experimental" ] || [ "$BUILD_CONFIGURATION" == "appcenter-experimental-2" ]; then - CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" + CODESIGNING_SUBPATH="$BUILDBOX_DIR/transient-data/telegram-codesigning/codesigning" elif [ "$BUILD_CONFIGURATION" == "appstore" ]; then - CODESIGNING_SUBPATH="transient-data/telegram-codesigning/codesigning" + CODESIGNING_SUBPATH="$BUILDBOX_DIR/transient-data/telegram-codesigning/codesigning" elif [ "$BUILD_CONFIGURATION" == "verify" ]; then CODESIGNING_SUBPATH="build-system/fake-codesigning" else @@ -118,8 +118,8 @@ elif [ "$BUILD_CONFIGURATION" == "verify" ]; then cp -R build-system/example-configuration/* "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration/" fi -if [ ! -d "$BUILDBOX_DIR/$CODESIGNING_SUBPATH" ]; then - echo "$BUILDBOX_DIR/$CODESIGNING_SUBPATH does not exist" +if [ ! -d "$CODESIGNING_SUBPATH" ]; then + echo "$CODESIGNING_SUBPATH does not exist" exit 1 fi @@ -175,7 +175,7 @@ elif [ "$BUILD_MACHINE" == "macOS" ]; then echo "VM_IP=$VM_IP" fi -scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/$CODESIGNING_SUBPATH" telegram@"$VM_IP":codesigning_data +scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$CODESIGNING_SUBPATH" telegram@"$VM_IP":codesigning_data scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BASE_DIR/$BUILDBOX_DIR/transient-data/build-configuration" telegram@"$VM_IP":telegram-configuration scp -o LogLevel=ERROR -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -pr "$BUILDBOX_DIR/guest-build-telegram.sh" "$BUILDBOX_DIR/transient-data/source.tar" telegram@"$VM_IP":