ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-06-16 05:55:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MTProto-MTContext retain cycle

Browse Source
This commit is contained in:
Ali 2023-11-02 17:31:33 +04:00
parent fb2d16a75e
commit 6e6424729a
2 changed files with 149 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
Telegram/NotificationService/Sources/NotificationService.swift
View File

@ -675,12 +675,10 @@ private final class NotificationServiceHandler {
private let notificationKeyDisposable = MetaDisposable() private let notificationKeyDisposable = MetaDisposable()
private let pollDisposable = MetaDisposable() private let pollDisposable = MetaDisposable()
init?(queue: Queue, updateCurrentContent: @escaping (NotificationContent) -> Void, completed: @escaping () -> Void, payload: [AnyHashable: Any]) { init?(queue: Queue, episode: String, updateCurrentContent: @escaping (NotificationContent) -> Void, completed: @escaping () -> Void, payload: [AnyHashable: Any]) {
//debug_linker_fail_test() //debug_linker_fail_test()
self.queue = queue self.queue = queue
let episode = String(UInt32.random(in: 0 ..< UInt32.max), radix: 16)
guard let appBundleIdentifier = Bundle.main.bundleIdentifier, let lastDotRange = appBundleIdentifier.range(of: ".", options: [.backwards]) else { guard let appBundleIdentifier = Bundle.main.bundleIdentifier, let lastDotRange = appBundleIdentifier.range(of: ".", options: [.backwards]) else {
return nil return nil
} }
@ -1558,7 +1556,8 @@ private final class NotificationServiceHandler {
if !shouldSynchronizeState { if !shouldSynchronizeState {
pollSignal = .complete() pollSignal = .complete()
} else { } else {
stateManager.network.shouldKeepConnection.set(.single(true)) let shouldKeepConnection = stateManager.network.shouldKeepConnection
shouldKeepConnection.set(.single(true))
if peerId.namespace == Namespaces.Peer.CloudChannel { if peerId.namespace == Namespaces.Peer.CloudChannel {
Logger.shared.log("NotificationService \(episode)", "Will poll channel \(peerId)") Logger.shared.log("NotificationService \(episode)", "Will poll channel \(peerId)")
@ -1569,6 +1568,9 @@ private final class NotificationServiceHandler {
peerId: peerId, peerId: peerId,
stateManager: stateManager stateManager: stateManager
) )
|> afterDisposed { [weak shouldKeepConnection] in
shouldKeepConnection?.set(.single(false))
}
} else { } else {
Logger.shared.log("NotificationService \(episode)", "Will perform non-specific getDifference") Logger.shared.log("NotificationService \(episode)", "Will perform non-specific getDifference")
enum ControlError { enum ControlError {
@ -1584,6 +1586,9 @@ private final class NotificationServiceHandler {
} }
} }
|> restartIfError |> restartIfError
|> afterDisposed { [weak shouldKeepConnection] in
shouldKeepConnection?.set(.single(false))
}
pollSignal = signal pollSignal = signal
} }
@ -1670,6 +1675,9 @@ private final class NotificationServiceHandler {
return return
} }
let shouldKeepConnection = stateManager.network.shouldKeepConnection
shouldKeepConnection.set(.single(true))
var fetchStoriesSignal: Signal<Void, NoError> = .single(Void()) var fetchStoriesSignal: Signal<Void, NoError> = .single(Void())
fetchStoriesSignal = _internal_pollPeerStories(postbox: stateManager.postbox, network: stateManager.network, accountPeerId: stateManager.accountPeerId, peerId: peerId) fetchStoriesSignal = _internal_pollPeerStories(postbox: stateManager.postbox, network: stateManager.network, accountPeerId: stateManager.accountPeerId, peerId: peerId)
|> map { _ -> Void in |> map { _ -> Void in
@ -1760,6 +1768,9 @@ private final class NotificationServiceHandler {
} }
} }
) )
|> afterDisposed { [weak shouldKeepConnection] in
shouldKeepConnection?.set(.single(false))
}
let fetchMediaSignal: Signal<Data?, NoError> = .single(nil) let fetchMediaSignal: Signal<Data?, NoError> = .single(nil)
@ -1865,11 +1876,6 @@ private final class NotificationServiceHandler {
} }
} }
let pollSignal: Signal<Never, NoError>
pollSignal = .complete()
stateManager.network.shouldKeepConnection.set(.single(true))
let pollWithUpdatedContent: Signal<NotificationContent, NoError> let pollWithUpdatedContent: Signal<NotificationContent, NoError>
if interactionAuthorId != nil || messageId != nil { if interactionAuthorId != nil || messageId != nil {
pollWithUpdatedContent = stateManager.postbox.transaction { transaction -> NotificationContent in pollWithUpdatedContent = stateManager.postbox.transaction { transaction -> NotificationContent in
@ -1899,13 +1905,8 @@ private final class NotificationServiceHandler {
return content return content
} }
|> then(
pollSignal
|> map { _ -> NotificationContent in }
)
} else { } else {
pollWithUpdatedContent = pollSignal pollWithUpdatedContent = .complete()
|> map { _ -> NotificationContent in }
} }
var updatedContent = initialContent var updatedContent = initialContent
@ -1987,10 +1988,7 @@ private final class NotificationServiceHandler {
} }
let completeRemoval: () -> Void = { let completeRemoval: () -> Void = {
guard let strongSelf = self else { let content = NotificationContent(isLockedMessage: nil)
return
}
var content = NotificationContent(isLockedMessage: nil)
Logger.shared.log("NotificationService \(episode)", "Updating content to \(content)") Logger.shared.log("NotificationService \(episode)", "Updating content to \(content)")
updateCurrentContent(content) updateCurrentContent(content)
@ -2126,12 +2124,16 @@ final class NotificationService: UNNotificationServiceExtension {
private var initialContent: UNNotificationContent? private var initialContent: UNNotificationContent?
private let content = Atomic<NotificationContent?>(value: nil) private let content = Atomic<NotificationContent?>(value: nil)
private var contentHandler: ((UNNotificationContent) -> Void)? private var contentHandler: ((UNNotificationContent) -> Void)?
private var episode: String?
override init() { override init() {
super.init() super.init()
} }
override func didReceive(_ request: UNNotificationRequest, withContentHandler contentHandler: @escaping (UNNotificationContent) -> Void) { override func didReceive(_ request: UNNotificationRequest, withContentHandler contentHandler: @escaping (UNNotificationContent) -> Void) {
let episode = String(UInt32.random(in: 0 ..< UInt32.max), radix: 16)
self.episode = episode
self.initialContent = request.content self.initialContent = request.content
self.contentHandler = contentHandler self.contentHandler = contentHandler
@ -2142,6 +2144,7 @@ final class NotificationService: UNNotificationServiceExtension {
self.impl = QueueLocalObject(queue: queue, generate: { [weak self] in self.impl = QueueLocalObject(queue: queue, generate: { [weak self] in
return BoxedNotificationServiceHandler(value: NotificationServiceHandler( return BoxedNotificationServiceHandler(value: NotificationServiceHandler(
queue: queue, queue: queue,
episode: episode,
updateCurrentContent: { value in updateCurrentContent: { value in
let _ = content.swap(value) let _ = content.swap(value)
}, },
@ -2152,15 +2155,17 @@ final class NotificationService: UNNotificationServiceExtension {
strongSelf.impl = nil strongSelf.impl = nil
if let contentHandler = strongSelf.contentHandler { if let contentHandler = strongSelf.contentHandler {
if let content = content.with({ $0 }) { Logger.shared.log("NotificationService \(episode)", "Complete handling notification")
/*let request = UNNotificationRequest(identifier: UUID().uuidString, content: content.generate(), trigger: .none)
UNUserNotificationCenter.current().add(request)
contentHandler(UNMutableNotificationContent())*/
strongSelf.contentHandler = nil
if let content = content.with({ $0 }) {
contentHandler(content.generate()) contentHandler(content.generate())
} else if let initialContent = strongSelf.initialContent { } else if let initialContent = strongSelf.initialContent {
contentHandler(initialContent) contentHandler(initialContent)
} }
} else {
Logger.shared.log("NotificationService \(episode)", "Attempted to repeatedly complete handling notification")
} }
}, },
payload: request.content.userInfo payload: request.content.userInfo
@ -2170,6 +2175,10 @@ final class NotificationService: UNNotificationServiceExtension {
override func serviceExtensionTimeWillExpire() { override func serviceExtensionTimeWillExpire() {
if let contentHandler = self.contentHandler { if let contentHandler = self.contentHandler {
self.contentHandler = nil
Logger.shared.log("NotificationService \(self.episode ?? "???")", "Completing due to serviceExtensionTimeWillExpire")
if let content = self.content.with({ $0 }) { if let content = self.content.with({ $0 }) {
contentHandler(content.generate()) contentHandler(content.generate())
} else if let initialContent = self.initialContent { } else if let initialContent = self.initialContent {

144
submodules/MtProtoKit/Sources/MTContext.m
View File

@ -141,6 +141,24 @@ static MTDatacenterAuthInfoMapKeyStruct parseAuthInfoMapKeyInteger(NSNumber *key
return parseAuthInfoMapKey([key longLongValue]); return parseAuthInfoMapKey([key longLongValue]);
} }
@interface MTWeakContextChangeListener : NSObject
@property (nonatomic, weak) id<MTContextChangeListener> target;
@end
@implementation MTWeakContextChangeListener
- (instancetype)initWithTarget:(id<MTContextChangeListener>)target {
self = [super init];
if (self != nil) {
_target = target;
}
return self;
}
@end
@interface MTContext () <MTDiscoverDatacenterAddressActionDelegate, MTDatacenterTransferAuthActionDelegate> @interface MTContext () <MTDiscoverDatacenterAddressActionDelegate, MTDatacenterTransferAuthActionDelegate>
{ {
int64_t _uniqueId; int64_t _uniqueId;
@ -160,7 +178,7 @@ static MTDatacenterAuthInfoMapKeyStruct parseAuthInfoMapKeyInteger(NSNumber *key
NSMutableDictionary *_authTokenById; NSMutableDictionary *_authTokenById;
NSMutableArray *_changeListeners; NSMutableArray<MTWeakContextChangeListener *> *_changeListeners;
MTSignal *_discoverBackupAddressListSignal; MTSignal *_discoverBackupAddressListSignal;
@ -463,9 +481,17 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
{ {
[[MTContext contextQueue] dispatchOnQueue:^ [[MTContext contextQueue] dispatchOnQueue:^
{ {
if (![_changeListeners containsObject:changeListener]) bool alreadyContains = false;
{ for (MTWeakContextChangeListener *value in _changeListeners) {
[_changeListeners addObject:changeListener]; id<MTContextChangeListener> target = value.target;
if (target == changeListener) {
alreadyContains = true;
break;
}
}
if (!alreadyContains) {
[_changeListeners addObject:[[MTWeakContextChangeListener alloc] initWithTarget:changeListener]];
} }
}]; }];
} }
@ -474,7 +500,15 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
{ {
[[MTContext contextQueue] dispatchOnQueue:^ [[MTContext contextQueue] dispatchOnQueue:^
{ {
[_changeListeners removeObject:changeListener]; for (NSInteger i = 0; i < _changeListeners.count; i++) {
MTWeakContextChangeListener *value = _changeListeners[i];
id<MTContextChangeListener> target = value.target;
if (target == changeListener) {
[_changeListeners removeObjectAtIndex:i];
break;
}
}
} synchronous:true]; } synchronous:true];
} }
@ -544,21 +578,27 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
_datacenterAddressSetById[@(datacenterId)] = addressSet; _datacenterAddressSetById[@(datacenterId)] = addressSet;
[_keychain setObject:_datacenterAddressSetById forKey:@"datacenterAddressSetById" group:@"persistent"]; [_keychain setObject:_datacenterAddressSetById forKey:@"datacenterAddressSetById" group:@"persistent"];
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray<MTWeakContextChangeListener *> *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (id<MTContextChangeListener> listener in currentListeners) for (MTWeakContextChangeListener *listenerWrapper in changeListeners) {
{ id<MTContextChangeListener> listener = listenerWrapper.target;
if ([listener respondsToSelector:@selector(contextDatacenterAddressSetUpdated:datacenterId:addressSet:)]) if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterAddressSetUpdated:datacenterId:addressSet:)]) {
[listener contextDatacenterAddressSetUpdated:self datacenterId:datacenterId addressSet:addressSet]; [listener contextDatacenterAddressSetUpdated:self datacenterId:datacenterId addressSet:addressSet];
} }
}
}
if (true) { if (true) {
bool shouldReset = previousAddressSetWasEmpty || updateSchemes; bool shouldReset = previousAddressSetWasEmpty || updateSchemes;
for (id<MTContextChangeListener> listener in currentListeners) { for (MTWeakContextChangeListener *listenerWrapper in changeListeners) {
id<MTContextChangeListener> listener = listenerWrapper.target;
if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterTransportSchemesUpdated:datacenterId:shouldReset:)]) { if ([listener respondsToSelector:@selector(contextDatacenterTransportSchemesUpdated:datacenterId:shouldReset:)]) {
[listener contextDatacenterTransportSchemesUpdated:self datacenterId:datacenterId shouldReset:shouldReset]; [listener contextDatacenterTransportSchemesUpdated:self datacenterId:datacenterId shouldReset:shouldReset];
} }
} }
}
} else { } else {
/*for (NSNumber *nMedia in @[@false, @true]) { /*for (NSNumber *nMedia in @[@false, @true]) {
for (NSNumber *nIsProxy in @[@false, @true]) { for (NSNumber *nIsProxy in @[@false, @true]) {
@ -633,14 +673,16 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
_datacenterAddressSetById[@(datacenterId)] = addressSet; _datacenterAddressSetById[@(datacenterId)] = addressSet;
[_keychain setObject:_datacenterAddressSetById forKey:@"datacenterAddressSetById" group:@"persistent"]; [_keychain setObject:_datacenterAddressSetById forKey:@"datacenterAddressSetById" group:@"persistent"];
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (MTWeakContextChangeListener *value in changeListeners) {
for (id<MTContextChangeListener> listener in currentListeners) id<MTContextChangeListener> listener = value.target;
{ if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterAddressSetUpdated:datacenterId:addressSet:)]) if ([listener respondsToSelector:@selector(contextDatacenterAddressSetUpdated:datacenterId:addressSet:)]) {
[listener contextDatacenterAddressSetUpdated:self datacenterId:datacenterId addressSet:addressSet]; [listener contextDatacenterAddressSetUpdated:self datacenterId:datacenterId addressSet:addressSet];
} }
} }
}
}
}]; }];
} }
@ -671,13 +713,14 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
[_keychain setObject:_datacenterAuthInfoById forKey:@"datacenterAuthInfoById" group:@"persistent"]; [_keychain setObject:_datacenterAuthInfoById forKey:@"datacenterAuthInfoById" group:@"persistent"];
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (MTWeakContextChangeListener *value in changeListeners) {
for (id<MTContextChangeListener> listener in currentListeners) id<MTContextChangeListener> listener = value.target;
{ if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterAuthInfoUpdated:datacenterId:authInfo:selector:)]) if ([listener respondsToSelector:@selector(contextDatacenterAuthInfoUpdated:datacenterId:authInfo:selector:)])
[listener contextDatacenterAuthInfoUpdated:self datacenterId:datacenterId authInfo:authInfo selector:selector]; [listener contextDatacenterAuthInfoUpdated:self datacenterId:datacenterId authInfo:authInfo selector:selector];
} }
}
if (wasNil && authInfo != nil && selector == MTDatacenterAuthInfoSelectorPersistent) { if (wasNil && authInfo != nil && selector == MTDatacenterAuthInfoSelectorPersistent) {
for (NSNumber *key in _datacenterAuthActions) { for (NSNumber *key in _datacenterAuthActions) {
@ -712,13 +755,15 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
{ {
[[MTContext contextQueue] dispatchOnQueue:^ [[MTContext contextQueue] dispatchOnQueue:^
{ {
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (MTWeakContextChangeListener *value in changeListeners) {
for (id<MTContextChangeListener> listener in currentListeners) id<MTContextChangeListener> listener = value.target;
{ if (listener) {
if ([listener respondsToSelector:@selector(contextIsPasswordRequiredUpdated:datacenterId:)]) if ([listener respondsToSelector:@selector(contextIsPasswordRequiredUpdated:datacenterId:)]) {
[listener contextIsPasswordRequiredUpdated:self datacenterId:datacenterId]; [listener contextIsPasswordRequiredUpdated:self datacenterId:datacenterId];
} }
}
}
}]; }];
} }
@ -738,17 +783,20 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
return current; return current;
}]; }];
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
if (MTLogEnabled()) { if (MTLogEnabled()) {
MTLog(@"[MTContext#%" PRIxPTR ": %@ transport scheme updated for %d: %@]", (intptr_t)self, media ? @"media" : @"generic", datacenterId, transportScheme); MTLog(@"[MTContext#%" PRIxPTR ": %@ transport scheme updated for %d: %@]", (intptr_t)self, media ? @"media" : @"generic", datacenterId, transportScheme);
} }
for (id<MTContextChangeListener> listener in currentListeners) { for (MTWeakContextChangeListener *value in changeListeners) {
id<MTContextChangeListener> listener = value.target;
if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterTransportSchemesUpdated:datacenterId:shouldReset:)]) if ([listener respondsToSelector:@selector(contextDatacenterTransportSchemesUpdated:datacenterId:shouldReset:)])
[listener contextDatacenterTransportSchemesUpdated:self datacenterId:datacenterId shouldReset:false]; [listener contextDatacenterTransportSchemesUpdated:self datacenterId:datacenterId shouldReset:false];
} }
} }
}
}]; }];
} }
@ -1011,19 +1059,26 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
_datacenterPublicKeysById[@(datacenterId)] = publicKeys; _datacenterPublicKeysById[@(datacenterId)] = publicKeys;
[_keychain setObject:_datacenterPublicKeysById forKey:@"datacenterPublicKeysById" group:@"ephemeral"]; [_keychain setObject:_datacenterPublicKeysById forKey:@"datacenterPublicKeysById" group:@"ephemeral"];
for (id<MTContextChangeListener> listener in _changeListeners) { for (MTWeakContextChangeListener *value in _changeListeners) {
id<MTContextChangeListener> listener = value.target;
if (listener) {
if ([listener respondsToSelector:@selector(contextDatacenterPublicKeysUpdated:datacenterId:publicKeys:)]) { if ([listener respondsToSelector:@selector(contextDatacenterPublicKeysUpdated:datacenterId:publicKeys:)]) {
[listener contextDatacenterPublicKeysUpdated:self datacenterId:datacenterId publicKeys:publicKeys]; [listener contextDatacenterPublicKeysUpdated:self datacenterId:datacenterId publicKeys:publicKeys];
} }
} }
} }
}
} synchronous:false]; } synchronous:false];
} }
- (void)publicKeysForDatacenterWithIdRequired:(NSInteger)datacenterId { - (void)publicKeysForDatacenterWithIdRequired:(NSInteger)datacenterId {
[[MTContext contextQueue] dispatchOnQueue:^{ [[MTContext contextQueue] dispatchOnQueue:^{
if (_fetchPublicKeysActions[@(datacenterId)] == nil) { if (_fetchPublicKeysActions[@(datacenterId)] == nil) {
for (id<MTContextChangeListener> listener in _changeListeners) { for (MTWeakContextChangeListener *value in _changeListeners) {
id<MTContextChangeListener> listener = value.target;
if (!listener) {
continue;
}
if ([listener respondsToSelector:@selector(fetchContextDatacenterPublicKeys:datacenterId:)]) { if ([listener respondsToSelector:@selector(fetchContextDatacenterPublicKeys:datacenterId:)]) {
MTSignal *signal = [listener fetchContextDatacenterPublicKeys:self datacenterId:datacenterId]; MTSignal *signal = [listener fetchContextDatacenterPublicKeys:self datacenterId:datacenterId];
if (signal != nil) { if (signal != nil) {
@ -1136,7 +1191,11 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
MTDatacenterAddressSet *addressSet = [[MTDatacenterAddressSet alloc] initWithAddressList:addressList]; MTDatacenterAddressSet *addressSet = [[MTDatacenterAddressSet alloc] initWithAddressList:addressList];
MTSignal *discoverSignal = [MTDiscoverConnectionSignals discoverSchemeWithContext:self datacenterId:datacenterId addressList:addressSet.addressList media:media isProxy:isProxy]; MTSignal *discoverSignal = [MTDiscoverConnectionSignals discoverSchemeWithContext:self datacenterId:datacenterId addressList:addressSet.addressList media:media isProxy:isProxy];
MTSignal *conditionSignal = [MTSignal single:@(true)]; MTSignal *conditionSignal = [MTSignal single:@(true)];
for (id<MTContextChangeListener> listener in _changeListeners) { for (MTWeakContextChangeListener *value in _changeListeners) {
id<MTContextChangeListener> listener = value.target;
if (!listener) {
continue;
}
if ([listener respondsToSelector:@selector(isContextNetworkAccessAllowed:)]) { if ([listener respondsToSelector:@selector(isContextNetworkAccessAllowed:)]) {
MTSignal *signal = [listener isContextNetworkAccessAllowed:self]; MTSignal *signal = [listener isContextNetworkAccessAllowed:self];
if (signal != nil) { if (signal != nil) {
@ -1338,10 +1397,12 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
[_authTokenById removeObjectForKey:@(datacenterId)]; [_authTokenById removeObjectForKey:@(datacenterId)];
[_keychain setObject:_authTokenById forKey:@"authTokenById" group:@"persistent"]; [_keychain setObject:_authTokenById forKey:@"authTokenById" group:@"persistent"];
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (MTWeakContextChangeListener *value in changeListeners) {
for (id<MTContextChangeListener> listener in currentListeners) id<MTContextChangeListener> listener = value.target;
{ if (!listener) {
continue;
}
if ([listener respondsToSelector:@selector(contextDatacenterAuthTokenUpdated:datacenterId:authToken:)]) if ([listener respondsToSelector:@selector(contextDatacenterAuthTokenUpdated:datacenterId:authToken:)])
[listener contextDatacenterAuthTokenUpdated:self datacenterId:datacenterId authToken:authToken]; [listener contextDatacenterAuthTokenUpdated:self datacenterId:datacenterId authToken:authToken];
} }
@ -1467,9 +1528,12 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
if (apiEnvironment != nil) { if (apiEnvironment != nil) {
_apiEnvironment = apiEnvironment; _apiEnvironment = apiEnvironment;
NSArray *currentListeners = [[NSArray alloc] initWithArray:_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:_changeListeners];
for (id<MTContextChangeListener> listener in currentListeners) for (MTWeakContextChangeListener *value in changeListeners) {
{ id<MTContextChangeListener> listener = value.target;
if (!listener) {
continue;
}
if ([listener respondsToSelector:@selector(contextApiEnvironmentUpdated:apiEnvironment:)]) { if ([listener respondsToSelector:@selector(contextApiEnvironmentUpdated:apiEnvironment:)]) {
[listener contextApiEnvironmentUpdated:self apiEnvironment:apiEnvironment]; [listener contextApiEnvironmentUpdated:self apiEnvironment:apiEnvironment];
} }
@ -1503,8 +1567,12 @@ static void copyKeychainDictionaryKey(NSString * _Nonnull group, NSString * _Non
} }
if ([isRemoved boolValue]) { if ([isRemoved boolValue]) {
NSArray *currentListeners = [[NSArray alloc] initWithArray:strongSelf->_changeListeners]; NSArray *changeListeners = [[NSArray alloc] initWithArray:strongSelf->_changeListeners];
for (id<MTContextChangeListener> listener in currentListeners) { for (MTWeakContextChangeListener *value in changeListeners) {
id<MTContextChangeListener> listener = value.target;
if (!listener) {
continue;
}
if ([listener respondsToSelector:@selector(contextLoggedOut:)]) if ([listener respondsToSelector:@selector(contextLoggedOut:)])
[listener contextLoggedOut:strongSelf]; [listener contextLoggedOut:strongSelf];
} }