From 19e956045e1af79729fc1715f01cd432106d68c9 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 21 Sep 2012 21:13:31 +0200 Subject: [PATCH 1/3] Fix for compiler warning about comparing NSInteger and NSUInteger Thanks to @pburleson --- Classes/BITCrashReportTextFormatter.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/BITCrashReportTextFormatter.m b/Classes/BITCrashReportTextFormatter.m index d66fc0445b..3d13b519ea 100644 --- a/Classes/BITCrashReportTextFormatter.m +++ b/Classes/BITCrashReportTextFormatter.m @@ -584,7 +584,7 @@ static NSInteger binaryImageSort(id binary1, id binary2, void *context) { /* Make sure UTF8/16 characters are handled correctly */ NSInteger offset = 0; - NSInteger index = 0; + NSUInteger index = 0; for (index = 0; index < [imageName length]; index++) { NSRange range = [imageName rangeOfComposedCharacterSequenceAtIndex:index]; if (range.length > 1) { From 80317fa538a6a60056d944226c52ad2112734790 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 21 Sep 2012 22:14:24 +0200 Subject: [PATCH 2/3] Fix checking validity of wrong identifier Thanks to @nano for the hint --- Classes/BITHockeyManager.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/BITHockeyManager.m b/Classes/BITHockeyManager.m index edeb584094..68d734d317 100644 --- a/Classes/BITHockeyManager.m +++ b/Classes/BITHockeyManager.m @@ -57,7 +57,7 @@ if (identifier) { NSCharacterSet *hexSet = [NSCharacterSet characterSetWithCharactersInString:@"0123456789abcdef"]; NSCharacterSet *inStringSet = [NSCharacterSet characterSetWithCharactersInString:identifier]; - result = ([_appIdentifier length] == 32) && ([hexSet isSupersetOfSet:inStringSet]); + result = ([identifier length] == 32) && ([hexSet isSupersetOfSet:inStringSet]); } return result; From 544e599eb3eed621bcbbc72e49f9026bae1dc56e Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 21 Sep 2012 22:20:31 +0200 Subject: [PATCH 3/3] Bump version to 2.5.3 --- README.md | 6 ++++++ Support/buildnumber.xcconfig | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 3c5c8147a2..2da1fa8bff 100644 --- a/README.md +++ b/README.md @@ -38,6 +38,12 @@ This documentation provides integrated help in Xcode for all public APIs and a s ## Changelog +### Version 2.5.3 + +- General: + + - Fix checking validity of live identifier not working correctly + ### Version 2.5.2 - General: diff --git a/Support/buildnumber.xcconfig b/Support/buildnumber.xcconfig index 26565c7557..578f418940 100644 --- a/Support/buildnumber.xcconfig +++ b/Support/buildnumber.xcconfig @@ -1,3 +1,3 @@ -BUILD_NUMBER = 4 -VERSION_STRING = 2.5.2 -GCC_PREPROCESSOR_DEFINITIONS = $(inherited) BITHOCKEY_VERSION="@\"2.5.2\"" +BUILD_NUMBER = 5 +VERSION_STRING = 2.5.3 +GCC_PREPROCESSOR_DEFINITIONS = $(inherited) BITHOCKEY_VERSION="@\"2.5.3\""