From 7a72c3a2dc04578882eca49c83b9b34571d86e22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Spie=C3=9F?= Date: Fri, 23 Oct 2015 09:58:21 +0200 Subject: [PATCH] Fix type comparison warnings --- Classes/BITCrashReportTextFormatter.m | 4 ++-- Classes/BITFeedbackListViewCell.m | 2 +- Classes/BITFeedbackListViewController.m | 2 +- Classes/BITImageAnnotationViewController.m | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Classes/BITCrashReportTextFormatter.m b/Classes/BITCrashReportTextFormatter.m index 1dd7cab44a..755686dba4 100644 --- a/Classes/BITCrashReportTextFormatter.m +++ b/Classes/BITCrashReportTextFormatter.m @@ -589,7 +589,7 @@ static const char *findSEL (const char *imageName, NSString *imageUUID, uint64_t #endif [text appendFormat: fmt, imageInfo.imageBaseAddress, - imageInfo.imageBaseAddress + (MAX(1, imageInfo.imageSize) - 1), // The Apple format uses an inclusive range + imageInfo.imageBaseAddress + (MAX(1U, imageInfo.imageSize) - 1), // The Apple format uses an inclusive range binaryDesignator, [imageInfo.imageName lastPathComponent], archName, @@ -817,7 +817,7 @@ static const char *findSEL (const char *imageName, NSString *imageUUID, uint64_t /* Make sure UTF8/16 characters are handled correctly */ NSInteger offset = 0; - NSInteger index = 0; + NSUInteger index = 0; for (index = 0; index < [imageName length]; index++) { NSRange range = [imageName rangeOfComposedCharacterSequenceAtIndex:index]; if (range.length > 1) { diff --git a/Classes/BITFeedbackListViewCell.m b/Classes/BITFeedbackListViewCell.m index 91dc8826bd..8e543e63be 100644 --- a/Classes/BITFeedbackListViewCell.m +++ b/Classes/BITFeedbackListViewCell.m @@ -359,7 +359,7 @@ - (void)imageButtonPressed:(id)sender { if ([self.delegate respondsToSelector:@selector(listCell:didSelectAttachment:)]) { - NSInteger index = [self.attachmentViews indexOfObject:sender]; + NSUInteger index = [self.attachmentViews indexOfObject:sender]; if (index != NSNotFound && [self.message previewableAttachments].count > index) { BITFeedbackMessageAttachment *attachment = [self.message previewableAttachments][index]; [self.delegate listCell:self didSelectAttachment:attachment]; diff --git a/Classes/BITFeedbackListViewController.m b/Classes/BITFeedbackListViewController.m index 8d2ef7a173..5291cd65f1 100644 --- a/Classes/BITFeedbackListViewController.m +++ b/Classes/BITFeedbackListViewController.m @@ -962,7 +962,7 @@ self.cachedPreviewItems = nil; NSMutableArray *collectedAttachments = [NSMutableArray new]; - for (int i = 0; i < self.manager.numberOfMessages; i++) { + for (uint i = 0; i < self.manager.numberOfMessages; i++) { BITFeedbackMessage *message = [self.manager messageAtIndex:i]; [collectedAttachments addObjectsFromArray:message.previewableAttachments]; } diff --git a/Classes/BITImageAnnotationViewController.m b/Classes/BITImageAnnotationViewController.m index 347ea21273..ba24fe34fe 100644 --- a/Classes/BITImageAnnotationViewController.m +++ b/Classes/BITImageAnnotationViewController.m @@ -301,7 +301,7 @@ typedef NS_ENUM(NSInteger, BITImageAnnotationViewControllerInteractionMode) { BITImageAnnotation *candidate = nil; BOOL validView = YES; - for ( int i = 0; i