ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-22 22:25:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix visibility assert on iOS 7

Browse Source 
It appears that didMoveToViewController: can be called with nil,
yet self.parentViewController will *not* be nil. This can result
in calling parent view controller's visibility depth. Instead of
asserting, these methods should return NSNotFound which also happens
to be a really large number, effectively infinite depth.
This commit is contained in:
Garrett Moon
2016-07-06 13:35:40 -07:00
parent c62a4d3e79
commit 8081123cb2
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
AsyncDisplayKit/ASNavigationController.m
View File

@@ -40,7 +40,10 @@ ASVisibilityDepthImplementation;
- (NSInteger)visibilityDepthOfChildViewController:(UIViewController *)childViewController
{
NSUInteger viewControllerIndex = [self.viewControllers indexOfObject:childViewController];
NSAssert(viewControllerIndex != NSNotFound, @"childViewController is not in the navigation stack.");
if (viewControllerIndex == NSNotFound) {
//If childViewController is not actually a child, return NSNotFound which is also a really large number.
return NSNotFound;
}
if (viewControllerIndex == self.viewControllers.count - 1) {
//view controller is at the top, just return our own visibility depth.