From 890e899589bb8cc50ca7f4ce6940bcdf66735d71 Mon Sep 17 00:00:00 2001
From: "Benjamin Scholtysik (Reimold)" <bereimol@microsoft.com>
Date: Tue, 6 Sep 2016 21:34:27 -0700
Subject: [PATCH] Removing synchronize calls as they are async anyway

check http://dscoder.com/defaults.html by the engineer who actually works on NSUserDefaults
---
 Classes/BITAuthenticator.m      | 1 -
 Classes/BITCrashManager.m       | 3 ---
 Classes/BITMetricsManager.m     | 2 --
 Classes/BITStoreUpdateManager.m | 2 --
 4 files changed, 8 deletions(-)

diff --git a/Classes/BITAuthenticator.m b/Classes/BITAuthenticator.m
index e5d226cf68..a7951554fe 100644
--- a/Classes/BITAuthenticator.m
+++ b/Classes/BITAuthenticator.m
@@ -960,7 +960,6 @@ static unsigned char kBITPNGEndChunk[4] = {0x49, 0x45, 0x4e, 0x44};
   } else {
     [defaults setObject:lastAuthenticatedVersion
                  forKey:kBITAuthenticatorLastAuthenticatedVersionKey];
-    [defaults synchronize];
   }
 }
 
diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m
index 26c69f3a42..d177463744 100644
--- a/Classes/BITCrashManager.m
+++ b/Classes/BITCrashManager.m
@@ -521,7 +521,6 @@ static void uncaught_cxx_exception_handler(const BITCrashUncaughtCXXExceptionInf
                                                                                              // we only need to log this once
                                                                                              if (!_didLogLowMemoryWarning) {
                                                                                                [[NSUserDefaults standardUserDefaults] setBool:YES forKey:kBITAppDidReceiveLowMemoryNotification];
-                                                                                               [[NSUserDefaults standardUserDefaults] synchronize];
                                                                                                _didLogLowMemoryWarning = YES;
                                                                                              }
                                                                                            }];
@@ -548,7 +547,6 @@ static void uncaught_cxx_exception_handler(const BITCrashUncaughtCXXExceptionInf
 - (void)leavingAppSafely {
   if (self.isAppNotTerminatingCleanlyDetectionEnabled) {
     [[NSUserDefaults standardUserDefaults] setBool:YES forKey:kBITAppWentIntoBackgroundSafely];
-    [[NSUserDefaults standardUserDefaults] synchronize];
   }
 }
 
@@ -1274,7 +1272,6 @@ static void uncaught_cxx_exception_handler(const BITCrashUncaughtCXXExceptionInf
 #endif
   
   [[NSUserDefaults standardUserDefaults] setBool:NO forKey:kBITAppDidReceiveLowMemoryNotification];
-  [[NSUserDefaults standardUserDefaults] synchronize];
   
   [self triggerDelayedProcessing];
   BITHockeyLogVerbose(@"VERBOSE: CrashManager startManager has finished.");
diff --git a/Classes/BITMetricsManager.m b/Classes/BITMetricsManager.m
index 406da4380d..912e24bc20 100644
--- a/Classes/BITMetricsManager.m
+++ b/Classes/BITMetricsManager.m
@@ -118,7 +118,6 @@ static NSString *const BITMetricsURLPathString = @"v2/track";
 
 - (void)updateDidEnterBackgroundTime {
   [self.userDefaults setDouble:[[NSDate date] timeIntervalSince1970] forKey:kBITApplicationDidEnterBackgroundTime];
-  [self.userDefaults synchronize];
 }
 
 - (void)startNewSessionIfNeeded {
@@ -150,7 +149,6 @@ static NSString *const BITMetricsURLPathString = @"v2/track";
   if (![self.userDefaults boolForKey:kBITApplicationWasLaunched]) {
     session.isFirst = @"true";
     [self.userDefaults setBool:YES forKey:kBITApplicationWasLaunched];
-    [self.userDefaults synchronize];
   } else {
     session.isFirst = @"false";
   }
diff --git a/Classes/BITStoreUpdateManager.m b/Classes/BITStoreUpdateManager.m
index cccc89185e..028296b921 100644
--- a/Classes/BITStoreUpdateManager.m
+++ b/Classes/BITStoreUpdateManager.m
@@ -165,8 +165,6 @@
         [self.userDefaults removeObjectForKey:kBITStoreUpdateLastStoreVersion];
         versionString = nil;
       }
-
-      [self.userDefaults synchronize];
     }
   }