From 6706778f5399698e32de4353de5d1d41a5be46d9 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 28 Sep 2012 12:34:26 +0200 Subject: [PATCH 1/5] Fix auto send button not persisting --- Classes/BITCrashManager.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index 3ce6d12725..1e530a3142 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -616,7 +616,8 @@ [self sendCrashReports]; break; case 2: { - [[NSUserDefaults standardUserDefaults] setBool:YES forKey:kBITCrashAutomaticallySendReports]; + _crashManagerStatus = BITCrashManagerStatusAutoSend; + [[NSUserDefaults standardUserDefaults] setInteger:_crashManagerStatus forKey:kBITCrashManagerStatus]; [[NSUserDefaults standardUserDefaults] synchronize]; if (self.delegate != nil && [self.delegate respondsToSelector:@selector(crashManagerWillSendCrashReportsAlways:)]) { [self.delegate crashManagerWillSendCrashReportsAlways:self]; From 6c913beac5706b3cf13cb1cee2908482a1e65afe Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 28 Sep 2012 12:35:01 +0200 Subject: [PATCH 2/5] Remove unused key --- Classes/BITCrashManager.m | 3 --- 1 file changed, 3 deletions(-) diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index 1e530a3142..cbe233a219 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -39,9 +39,6 @@ #include -// flags if the crashreporter should automatically send crashes without asking the user again -#define kBITCrashAutomaticallySendReports @"BITCrashAutomaticallySendReports" - // stores the set of crashreports that have been approved but aren't sent yet #define kBITCrashApprovedReports @"HockeySDKCrashApprovedReports" From 109e985fc9f11ba2548a6bcb30106320bcb7ce33 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 28 Sep 2012 19:09:14 +0200 Subject: [PATCH 3/5] Migrate previous crash AutoSend user setting --- Classes/BITCrashManager.m | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index cbe233a219..ff72aec7f5 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -95,6 +95,11 @@ if (testValue) { _crashManagerStatus = [[NSUserDefaults standardUserDefaults] integerForKey:kBITCrashManagerStatus]; } else { + // migrate previous setting if available + if ([[NSUserDefaults standardUserDefaults] boolForKey:@"BITCrashAutomaticallySendReports"]) { + _crashManagerStatus = BITCrashManagerStatusAutoSend; + [[NSUserDefaults standardUserDefaults] removeObjectForKey:@"BITCrashAutomaticallySendReports"]; + } [[NSUserDefaults standardUserDefaults] setInteger:_crashManagerStatus forKey:kBITCrashManagerStatus]; } From 53eb832bb65649c61e135feba61f703daa9ad2f6 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Fri, 28 Sep 2012 21:27:17 +0200 Subject: [PATCH 4/5] Remove header string for application log --- Classes/BITCrashManager.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index ff72aec7f5..38c614242c 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -566,7 +566,7 @@ } if ([applicationLog length] > 0) { - description = [NSString stringWithFormat:@"Log:\n%@", applicationLog]; + description = [NSString stringWithFormat:@"%@", applicationLog]; } [crashes appendFormat:@"%s%@%@%@%@%@%@%@%@%@", From 2aca4995a0b8d945f8bcd8b0bd5295c853b553d9 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Tue, 2 Oct 2012 13:20:45 +0100 Subject: [PATCH 5/5] Fix authorisation not being saved for a version and requesting on each cold app start again --- Classes/BITUpdateManager.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/BITUpdateManager.m b/Classes/BITUpdateManager.m index a9bd03a4ff..ee046e0f36 100644 --- a/Classes/BITUpdateManager.m +++ b/Classes/BITUpdateManager.m @@ -756,7 +756,7 @@ // store the new data [[NSUserDefaults standardUserDefaults] setObject:[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleVersion"] forKey:kBITUpdateAuthorizedVersion]; - [[NSUserDefaults standardUserDefaults] setObject:token forKey:kBITUpdateAuthorizedVersion]; + [[NSUserDefaults standardUserDefaults] setObject:token forKey:kBITUpdateAuthorizedToken]; [[NSUserDefaults standardUserDefaults] synchronize]; self.requireAuthorization = NO; @@ -772,7 +772,7 @@ // store the new data [[NSUserDefaults standardUserDefaults] setObject:[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleVersion"] forKey:kBITUpdateAuthorizedVersion]; - [[NSUserDefaults standardUserDefaults] setObject:token forKey:kBITUpdateAuthorizedVersion]; + [[NSUserDefaults standardUserDefaults] setObject:token forKey:kBITUpdateAuthorizedToken]; [[NSUserDefaults standardUserDefaults] synchronize]; [self showBlockingScreen:BITHockeyLocalizedString(@"UpdateAuthorizationDenied") image:@"authorize_denied.png"];