mirror of
https://github.com/Swiftgram/Telegram-iOS.git
synced 2025-12-24 07:05:35 +00:00
Unify boolean flag naming confention, getter spacing, and property attribute naming
Summary: * Fixes #3 * Ordering: atomicity, then [optional] readonly, then value semantics (retain/copy/assign) * Removed redundant `readwrite` * No spaces between "getter = name" ("getter=name" instead) * Property method overrides renamed as well * self.isBlah, while technically not entirely correct, still resolves to [self blah], so left alone (@kimon had advice on this sort of naming issue last summer), and largely inconsequential Test Plan: * Compile and run
This commit is contained in:
@@ -29,16 +29,16 @@
|
||||
- (id)initWithLayerClass:(Class)layerClass;
|
||||
|
||||
// If this view is strictly synchronous (ie wraps a non _ASDisplayView view)
|
||||
@property (nonatomic, readonly) BOOL isSynchronous;
|
||||
@property (nonatomic, readonly, assign, getter=isSynchronous) BOOL synchronous;
|
||||
|
||||
// The view property is lazily initialized, similar to UIViewController.
|
||||
// The first access to it must be on the main thread, and should only be used on the main thread thereafter as well.
|
||||
// To go the other direction, use ASViewToDisplayNode() in ASDisplayNodeExtras.h
|
||||
@property (nonatomic, readonly, retain) UIView *view;
|
||||
@property (atomic, readonly, assign) BOOL isViewLoaded; // Also YES if isLayerBacked == YES && self.layer != nil. Rename to isBackingLoaded?
|
||||
@property (atomic, readonly, assign, getter=isViewLoaded) BOOL viewLoaded; // Also YES if isLayerBacked == YES && self.layer != nil. Rename to isBackingLoaded?
|
||||
|
||||
// If this node does not have an associated view, instead relying directly upon a layer
|
||||
@property (nonatomic, assign) BOOL isLayerBacked;
|
||||
@property (nonatomic, assign, getter=isLayerBacked) BOOL layerBacked;
|
||||
// The same restrictions apply as documented above about the view property. To go the other direction, use ASLayerToDisplayNode() in ASDisplayNodeExtras.h
|
||||
@property (nonatomic, readonly, retain) CALayer *layer;
|
||||
|
||||
@@ -131,7 +131,7 @@
|
||||
|
||||
Note: this has nothing to do with CALayer@drawsAsynchronously
|
||||
*/
|
||||
@property (nonatomic) BOOL displaysAsynchronously;
|
||||
@property (nonatomic, assign) BOOL displaysAsynchronously;
|
||||
|
||||
/**
|
||||
@abstract
|
||||
|
||||
Reference in New Issue
Block a user