Improve and fix adjusting status bar style

- Only adjust the status bar style, if the navigation bar style is the default one
- Fix a bug not resetting the status bar style correctly when presenting the update view in a navigation bar stack
This commit is contained in:
Andreas Linde 2013-02-17 19:08:44 +01:00
parent b792ee9ccd
commit abc639c18c
2 changed files with 7 additions and 6 deletions

View File

@ -7,6 +7,7 @@
// //
#import "BITHockeyBaseViewController.h" #import "BITHockeyBaseViewController.h"
#import "HockeySDKPrivate.h"
@implementation BITHockeyBaseViewController { @implementation BITHockeyBaseViewController {
@ -65,13 +66,17 @@
[super viewWillAppear:animated]; [super viewWillAppear:animated];
_statusBarStyle = [[UIApplication sharedApplication] statusBarStyle]; _statusBarStyle = [[UIApplication sharedApplication] statusBarStyle];
[[UIApplication sharedApplication] setStatusBarStyle:(self.navigationController.navigationBar.barStyle == UIBarStyleDefault) ? UIStatusBarStyleDefault : UIStatusBarStyleBlackOpaque]; if ([self.navigationController.navigationBar.tintColor isEqual:BIT_RGBCOLOR(25, 25, 25)]) {
[[UIApplication sharedApplication] setStatusBarStyle:(self.navigationController.navigationBar.barStyle == UIBarStyleDefault) ? UIStatusBarStyleDefault : UIStatusBarStyleBlackOpaque];
}
} }
- (void)viewWillDisappear:(BOOL)animated { - (void)viewWillDisappear:(BOOL)animated {
[super viewWillDisappear:animated]; [super viewWillDisappear:animated];
[[UIApplication sharedApplication] setStatusBarStyle:_statusBarStyle]; if ([self.navigationController.navigationBar.tintColor isEqual:BIT_RGBCOLOR(25, 25, 25)]) {
[[UIApplication sharedApplication] setStatusBarStyle:_statusBarStyle];
}
} }

View File

@ -49,7 +49,6 @@
@implementation BITUpdateViewController { @implementation BITUpdateViewController {
BOOL _kvoRegistered; BOOL _kvoRegistered;
BOOL _showAllVersions; BOOL _showAllVersions;
UIStatusBarStyle _statusBarStyle;
BITAppStoreHeader *_appStoreHeader; BITAppStoreHeader *_appStoreHeader;
BITStoreButton *_appStoreButton; BITStoreButton *_appStoreButton;
@ -339,8 +338,6 @@
self.appStoreButtonState = AppStoreButtonStateOffline; self.appStoreButtonState = AppStoreButtonStateOffline;
_updateManager.currentHockeyViewController = self; _updateManager.currentHockeyViewController = self;
[super viewWillAppear:animated]; [super viewWillAppear:animated];
_statusBarStyle = [[UIApplication sharedApplication] statusBarStyle];
[[UIApplication sharedApplication] setStatusBarStyle:(self.navigationController.navigationBar.barStyle == UIBarStyleDefault) ? UIStatusBarStyleDefault : UIStatusBarStyleBlackOpaque];
[self redrawTableView]; [self redrawTableView];
} }
@ -349,7 +346,6 @@
//if the popover is still visible, dismiss it //if the popover is still visible, dismiss it
[_popOverController dismissPopoverAnimated:YES]; [_popOverController dismissPopoverAnimated:YES];
[super viewWillDisappear:animated]; [super viewWillDisappear:animated];
[[UIApplication sharedApplication] setStatusBarStyle:_statusBarStyle];
} }
- (void)redrawTableView { - (void)redrawTableView {