ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-22 14:20:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unit tests for batch fetching

Browse Source
This commit is contained in:
Ryan Nystrom
2015-02-12 16:09:50 -08:00
parent 1f8001a104
commit b3ae15858a
11 changed files with 248 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
AsyncDisplayKit/ASCollectionView.mm
View File

@@ -13,6 +13,7 @@
#import "ASRangeController.h"
#import "ASDataController.h"
#import "ASDisplayNodeInternal.h"
#import "ASBatchFetching.h"
const static NSUInteger kASCollectionViewAnimationNone = 0;
@@ -144,6 +145,8 @@ static BOOL _isInterceptedSelector(SEL sel)
_batchContext = [[ASBatchContext alloc] init];
_leadingScreensForBatching = 1.0;
_proxyDelegate = [[_ASCollectionViewProxy alloc] initWithTarget:nil interceptor:self];
super.delegate = (id<UICollectionViewDelegate>)_proxyDelegate;
@@ -386,7 +389,8 @@ static BOOL _isInterceptedSelector(SEL sel)
if ([self.asyncDelegate respondsToSelector:@selector(shouldBatchFetchForCollectionView:)]) {
return [self.asyncDelegate shouldBatchFetchForCollectionView:self];
} else {
return YES;
// if the delegate does not respond to this method, there is no point in starting to fetch
return [self.asyncDelegate respondsToSelector:@selector(collectionView:beginBatchFetchingWithContext:)];
}
}
@@ -394,32 +398,11 @@ static BOOL _isInterceptedSelector(SEL sel)
{
ASDisplayNodeAssert(_batchContext != nil, @"Batch context should exist");
// Bail if we are already fetching, the delegate doesn't care, or we're told not to fetch
if ([_batchContext isFetching] ||
![self.asyncDelegate respondsToSelector:@selector(collectionView:beginBatchFetchingWithContext:)] ||
![self shouldFetchBatch]) {
if (![self shouldFetchBatch]) {
return;
}
ASScrollDirection scrollDirection = [self scrollDirection];
CGFloat viewSize, offset, contentSize;
if (scrollDirection == ASScrollDirectionUp) {
viewSize = CGRectGetHeight(self.bounds);
offset = targetOffset.y;
contentSize = self.contentSize.height;
} else { // horizontal
viewSize = CGRectGetWidth(self.bounds);
offset = targetOffset.x;
contentSize = self.contentSize.width;
}
CGFloat triggerDistance = viewSize * _leadingScreensForBatching;
// Determine if the offset that we are headed to is within the number of screens we have defined
// ASCollectionView supports tail loading only currently, hence the check against Up and Left
BOOL supportedBatchScrollDirection = scrollDirection == ASScrollDirectionUp || ASScrollDirectionLeft;
if (supportedBatchScrollDirection && contentSize - (viewSize + offset) <= triggerDistance) {
if (ASDisplayShouldFetchBatchForContext(_batchContext, [self scrollDirection], self.bounds, self.contentSize, targetOffset, _leadingScreensForBatching)) {
[_batchContext beginBatchFetching];
[self.asyncDelegate collectionView:self beginBatchFetchingWithContext:_batchContext];
}