From b77522bf4fde2cf9fe7cb9951538812fd8cbd453 Mon Sep 17 00:00:00 2001 From: Huy Nguyen Date: Mon, 26 Oct 2015 07:40:54 +0200 Subject: [PATCH] Remove debugging names of ASDisplayNode and _ASDisplayLayer - They are neither considered internally nor in tests. And when they are accidently considered, they cause tests to fail. - Developers can easily set debugging names themselves whenever needed. --- AsyncDisplayKit/ASDisplayNode.mm | 4 +--- AsyncDisplayKit/Details/_ASDisplayLayer.mm | 5 ----- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/AsyncDisplayKit/ASDisplayNode.mm b/AsyncDisplayKit/ASDisplayNode.mm index c47cc01840..c299cb0d9c 100644 --- a/AsyncDisplayKit/ASDisplayNode.mm +++ b/AsyncDisplayKit/ASDisplayNode.mm @@ -460,9 +460,7 @@ static ASDisplayNodeMethodOverrides GetASDisplayNodeMethodOverrides(Class c) _layer = _view.layer; } _layer.asyncdisplaykit_node = self; -#if DEBUG - _layer.name = self.description; -#endif + self.asyncLayer.asyncDelegate = self; { diff --git a/AsyncDisplayKit/Details/_ASDisplayLayer.mm b/AsyncDisplayKit/Details/_ASDisplayLayer.mm index 1d9b023983..99e4bf68e8 100644 --- a/AsyncDisplayKit/Details/_ASDisplayLayer.mm +++ b/AsyncDisplayKit/Details/_ASDisplayLayer.mm @@ -36,11 +36,6 @@ _displaySentinel = [[ASSentinel alloc] init]; self.opaque = YES; - -#if DEBUG - // This is too expensive to do in production on all layers. - self.name = [NSString stringWithFormat:@"%@ (%p)", NSStringFromClass([self class]), self]; -#endif } return self; }