Merge pull request #1729 from levi/reverseFlatten

[Tests] Update FBSnapshotTestCase and generate @3x images

AsyncDisplayKit.xcodeproj/xcshareddata/xcschemes/AsyncDisplayKit.xcscheme

@@ -85,6 +85,13 @@
             ReferencedContainer = "container:AsyncDisplayKit.xcodeproj">
          </BuildableReference>
       </MacroExpansion>
+      <EnvironmentVariables>
+         <EnvironmentVariable
+            key = "FB_REFERENCE_IMAGE_DIR"
+            value = "$(SOURCE_ROOT)/$(PROJECT_NAME)Tests/ReferenceImages"
+            isEnabled = "YES">
+         </EnvironmentVariable>
+      </EnvironmentVariables>
       <AdditionalOptions>
       </AdditionalOptions>
    </LaunchAction>

AsyncDisplayKitTests/ASCenterLayoutSpecSnapshotTests.mm

@@ -21,12 +21,6 @@ static const ASSizeRange kSize = {{100, 120}, {320, 160}};
 
 @implementation ASCenterLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testWithOptions
 {
   [self testWithCenteringOptions:ASCenterLayoutSpecCenteringNone sizingOptions:{}];

AsyncDisplayKitTests/ASInsetLayoutSpecSnapshotTests.mm

@@ -45,12 +45,6 @@ static NSString *nameForInsets(UIEdgeInsets insets)
 
 @implementation ASInsetLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testInsetsWithVariableSize
 {
   for (NSUInteger combination = 0; combination < 16; combination++) {

AsyncDisplayKitTests/ASLayoutSpecSnapshotTestsHelper.m

@@ -20,6 +20,12 @@
 
 @implementation ASLayoutSpecSnapshotTestCase
 
+- (void)setUp
+{
+  [super setUp];
+  self.recordMode = NO;
+}
+
 - (void)testLayoutSpec:(ASLayoutSpec *)layoutSpec
              sizeRange:(ASSizeRange)sizeRange
               subnodes:(NSArray *)subnodes

AsyncDisplayKitTests/ASOverlayLayoutSpecSnapshotTests.mm

@@ -20,12 +20,6 @@ static const ASSizeRange kSize = {{320, 320}, {320, 320}};
 
 @implementation ASOverlayLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testOverlay
 {
   ASDisplayNode *backgroundNode = ASDisplayNodeWithBackgroundColor([UIColor blueColor]);

AsyncDisplayKitTests/ASRatioLayoutSpecSnapshotTests.mm

@@ -19,12 +19,6 @@ static const ASSizeRange kFixedSize = {{0, 0}, {100, 100}};
 
 @implementation ASRatioLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testRatioLayoutSpecWithRatio:(CGFloat)ratio childSize:(CGSize)childSize identifier:(NSString *)identifier
 {
   ASStaticSizeDisplayNode *subnode = ASDisplayNodeWithBackgroundColor([UIColor greenColor]);

AsyncDisplayKitTests/ASRelativeLayoutSpecSnapshotTests.mm

@@ -21,12 +21,6 @@ static const ASSizeRange kSize = {{100, 120}, {320, 160}};
 
 @implementation ASRelativeLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testWithOptions
 {
 

AsyncDisplayKitTests/ASStackLayoutSpecSnapshotTests.mm

@@ -21,12 +21,6 @@
 
 @implementation ASStackLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 #pragma mark - Utility methods
 
 static NSArray *defaultSubnodes()

AsyncDisplayKitTests/ASStaticLayoutSpecSnapshotTests.m

@@ -16,12 +16,6 @@
 
 @implementation ASStaticLayoutSpecSnapshotTests
 
-- (void)setUp
-{
-  [super setUp];
-  self.recordMode = NO;
-}
-
 - (void)testSizingBehaviour
 {
   [self testWithSizeRange:ASSizeRangeMake(CGSizeMake(150, 200), CGSizeMake(FLT_MAX, FLT_MAX))

AsyncDisplayKitTests/ASTextKitTests.mm

@@ -81,7 +81,7 @@ static BOOL checkAttributes(const ASTextKitAttributes &attributes, const CGSize
   FBSnapshotTestController *controller = [[FBSnapshotTestController alloc] init];
   UIImage *labelImage = UITextViewImageWithAttributes(attributes, constrainedSize, linkTextAttributes);
   UIImage *textKitImage = ASTextKitImageWithAttributes(attributes, constrainedSize);
-  return [controller compareReferenceImage:labelImage toImage:textKitImage error:nil];
+  return [controller compareReferenceImage:labelImage toImage:textKitImage tolerance:0.0 error:nil];
 }
 
 @implementation ASTextKitTests