From c2250f3b8093b8b9cf83a5f84ec1b0edef5734ff Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Thu, 6 Dec 2012 18:12:27 +0100 Subject: [PATCH] Make sure crash reports incident identifier and key don't have special [] chars and some value The previously shows [] as part of [TODO], since PLCrashReporter didn't fill them out. Having the incident identifier showing a [ or ] char made it impossible to drag it into the Organizer to get it symbolicated in there --- Classes/BITCrashReportTextFormatter.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Classes/BITCrashReportTextFormatter.m b/Classes/BITCrashReportTextFormatter.m index db6754e2d4..e1abddeeb0 100644 --- a/Classes/BITCrashReportTextFormatter.m +++ b/Classes/BITCrashReportTextFormatter.m @@ -173,14 +173,14 @@ static NSInteger binaryImageSort(id binary1, id binary2, void *context) { } { - NSString *reportGUID = @"[TODO]"; + NSString *reportGUID = @"TODO"; if ([report respondsToSelector:@selector(reportInfo)]) { if (report.hasReportInfo && report.reportInfo.reportGUID != nil) reportGUID = report.reportInfo.reportGUID; } - NSString *reporterKey = @"[TODO]"; - if (crashReporterKey) + NSString *reporterKey = @"TODO"; + if (crashReporterKey && [crashReporterKey length] > 0) reporterKey = crashReporterKey; NSString *hardwareModel = @"???";