Make yoga & layout specs faster by eliminating some copies (#1128)

This commit is contained in:
Adlai Holler
2018-09-18 07:26:29 -07:00
committed by Huy Nguyen
parent 47e2b9c0de
commit d2984ced8d
7 changed files with 39 additions and 22 deletions

View File

@@ -12,6 +12,7 @@
#import <numeric>
#import <vector>
#import <AsyncDisplayKit/ASCollections.h>
#import <AsyncDisplayKit/ASDimension.h>
#import <AsyncDisplayKit/ASLayout.h>
#import <AsyncDisplayKit/ASLayoutElement.h>
@@ -151,12 +152,14 @@
self.style.ascender = stackChildren.front().style.ascender;
self.style.descender = stackChildren.back().style.descender;
}
const auto sublayouts = [[NSMutableArray<ASLayout *> alloc] init];
ASLayout *rawSublayouts[positionedLayout.items.size()];
int i = 0;
for (const auto &item : positionedLayout.items) {
[sublayouts addObject:item.layout];
rawSublayouts[i++] = item.layout;
}
let sublayouts = [NSArray<ASLayout *> arrayByTransferring:rawSublayouts count:i];
return [ASLayout layoutWithLayoutElement:self size:positionedLayout.size sublayouts:sublayouts];
}