From de5414b683782356cb14e067166876acb086f94e Mon Sep 17 00:00:00 2001 From: "Benjamin Scholtysik (Reimold)" Date: Tue, 25 Jul 2017 16:46:37 -0700 Subject: [PATCH] Use copy attribute for properties of type NSString --- Classes/BITAuthenticator.h | 2 +- Classes/BITCrashDetails.h | 18 +++++++++--------- Classes/BITCrashManager.m | 4 ++-- Classes/BITCrashManagerPrivate.h | 4 ++-- Classes/BITFeedbackActivity.h | 2 +- Classes/BITFeedbackComposeViewController.m | 2 +- Classes/BITFeedbackManager.m | 2 +- Classes/BITFeedbackManagerPrivate.h | 2 +- Classes/BITFeedbackMessageAttachment.m | 4 ++-- Classes/BITHockeyAttachment.h | 4 ++-- Classes/BITHockeyBaseManagerPrivate.h | 2 +- Classes/BITHockeyManager.h | 2 +- Classes/BITHockeyManager.m | 4 ++-- Classes/BITPersistencePrivate.h | 2 +- Classes/BITStoreUpdateManager.h | 2 +- Classes/BITStoreUpdateManager.m | 6 +++--- Classes/BITUpdateManager.m | 12 ++++++------ Classes/BITUpdateManagerPrivate.h | 6 +++--- 18 files changed, 40 insertions(+), 40 deletions(-) diff --git a/Classes/BITAuthenticator.h b/Classes/BITAuthenticator.h index df64cf3de6..a1eaac1ad6 100644 --- a/Classes/BITAuthenticator.h +++ b/Classes/BITAuthenticator.h @@ -230,7 +230,7 @@ typedef NS_ENUM(NSUInteger, BITAuthenticatorAppRestrictionEnforcementFrequency) * @see identificationType * @see handleOpenURL:sourceApplication:annotation: */ -@property (nonatomic, strong) NSString *urlScheme; +@property (nonatomic, copy) NSString *urlScheme; /** Should be used by the app-delegate to forward handle application:openURL:sourceApplication:annotation: calls. diff --git a/Classes/BITCrashDetails.h b/Classes/BITCrashDetails.h index 9021a312ce..be2d62fa3a 100644 --- a/Classes/BITCrashDetails.h +++ b/Classes/BITCrashDetails.h @@ -36,27 +36,27 @@ /** * UUID for the crash report */ -@property (nonatomic, readonly, strong) NSString *incidentIdentifier; +@property (nonatomic, readonly, copy) NSString *incidentIdentifier; /** * UUID for the app installation on the device */ -@property (nonatomic, readonly, strong) NSString *reporterKey; +@property (nonatomic, readonly, copy) NSString *reporterKey; /** * Signal that caused the crash */ -@property (nonatomic, readonly, strong) NSString *signal; +@property (nonatomic, readonly, copy) NSString *signal; /** * Exception name that triggered the crash, nil if the crash was not caused by an exception */ -@property (nonatomic, readonly, strong) NSString *exceptionName; +@property (nonatomic, readonly, copy) NSString *exceptionName; /** * Exception reason, nil if the crash was not caused by an exception */ -@property (nonatomic, readonly, strong) NSString *exceptionReason; +@property (nonatomic, readonly, copy) NSString *exceptionReason; /** * Date and time the app started, nil if unknown @@ -71,14 +71,14 @@ /** * Operation System version string the app was running on when it crashed. */ -@property (nonatomic, readonly, strong) NSString *osVersion; +@property (nonatomic, readonly, copy) NSString *osVersion; /** * Operation System build string the app was running on when it crashed * * This may be unavailable. */ -@property (nonatomic, readonly, strong) NSString *osBuild; +@property (nonatomic, readonly, copy) NSString *osBuild; /** * CFBundleShortVersionString value of the app that crashed @@ -86,12 +86,12 @@ * Can be `nil` if the crash was captured with an older version of the SDK * or if the app doesn't set the value. */ -@property (nonatomic, readonly, strong) NSString *appVersion; +@property (nonatomic, readonly, copy) NSString *appVersion; /** * CFBundleVersion value of the app that crashed */ -@property (nonatomic, readonly, strong) NSString *appBuild; +@property (nonatomic, readonly, copy) NSString *appBuild; /** * Identifier of the app process that crashed diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index b3db4ff367..7643f388de 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -187,8 +187,8 @@ __attribute__((noreturn)) static void uncaught_cxx_exception_handler(const BITCr @property (nonatomic, strong) NSMutableDictionary *approvedCrashReports; @property (nonatomic, strong) NSMutableArray *crashFiles; -@property (nonatomic, strong) NSString *settingsFile; -@property (nonatomic, strong) NSString *analyzerInProgressFile; +@property (nonatomic, copy) NSString *settingsFile; +@property (nonatomic, copy) NSString *analyzerInProgressFile; @property (nonatomic) BOOL crashIdenticalCurrentVersion; @property (nonatomic) BOOL sendingInProgress; @property (nonatomic) BOOL isSetup; diff --git a/Classes/BITCrashManagerPrivate.h b/Classes/BITCrashManagerPrivate.h index 75ecf3ce64..0add0c801d 100644 --- a/Classes/BITCrashManagerPrivate.h +++ b/Classes/BITCrashManagerPrivate.h @@ -68,12 +68,12 @@ @property (nonatomic, copy, setter = setAlertViewHandler:) BITCustomAlertViewHandler alertViewHandler; -@property (nonatomic, strong) NSString *crashesDir; +@property (nonatomic, copy) NSString *crashesDir; #if HOCKEYSDK_FEATURE_AUTHENTICATOR // Only set via BITAuthenticator -@property (nonatomic, strong) NSString *installationIdentification; +@property (nonatomic, copy) NSString *installationIdentification; // Only set via BITAuthenticator @property (nonatomic) BITAuthenticatorIdentificationType installationIdentificationType; diff --git a/Classes/BITFeedbackActivity.h b/Classes/BITFeedbackActivity.h index f9289c8df0..44c08a985c 100644 --- a/Classes/BITFeedbackActivity.h +++ b/Classes/BITFeedbackActivity.h @@ -70,6 +70,6 @@ @see customActivityImage */ -@property (nonatomic, strong) NSString *customActivityTitle; +@property (nonatomic, copy) NSString *customActivityTitle; @end diff --git a/Classes/BITFeedbackComposeViewController.m b/Classes/BITFeedbackComposeViewController.m index 4ac7a374ad..385d5a1396 100644 --- a/Classes/BITFeedbackComposeViewController.m +++ b/Classes/BITFeedbackComposeViewController.m @@ -57,7 +57,7 @@ @property (nonatomic, strong) UIButton *addPhotoButton; -@property (nonatomic, strong) NSString *text; +@property (nonatomic, copy) NSString *text; @property (nonatomic, strong) NSMutableArray *attachments; @property (nonatomic, strong) NSMutableArray *imageAttachments; diff --git a/Classes/BITFeedbackManager.m b/Classes/BITFeedbackManager.m index 07ad8d426a..bbaa53cdd8 100644 --- a/Classes/BITFeedbackManager.m +++ b/Classes/BITFeedbackManager.m @@ -62,7 +62,7 @@ typedef void (^BITLatestImageFetchCompletionBlock)(UIImage *_Nonnull latestImage @interface BITFeedbackManager () @property (nonatomic, strong) NSFileManager *fileManager; -@property (nonatomic, strong) NSString *settingsFile; +@property (nonatomic, copy) NSString *settingsFile; @property (nonatomic, weak) id appDidBecomeActiveObserver; @property (nonatomic, weak) id appDidEnterBackgroundObserver; @property (nonatomic, weak) id networkDidBecomeReachableObserver; diff --git a/Classes/BITFeedbackManagerPrivate.h b/Classes/BITFeedbackManagerPrivate.h index e89c235792..f59fe47c31 100644 --- a/Classes/BITFeedbackManagerPrivate.h +++ b/Classes/BITFeedbackManagerPrivate.h @@ -58,7 +58,7 @@ extern NSString *const kBITFeedbackUpdateAttachmentThumbnail; @property (nonatomic, strong) NSMutableArray *feedbackList; -@property (nonatomic, strong) NSString *token; +@property (nonatomic, copy) NSString *token; // used by BITHockeyManager if disable status is changed diff --git a/Classes/BITFeedbackMessageAttachment.m b/Classes/BITFeedbackMessageAttachment.m index f8fb86b5e8..1ea27ed79d 100644 --- a/Classes/BITFeedbackMessageAttachment.m +++ b/Classes/BITFeedbackMessageAttachment.m @@ -43,8 +43,8 @@ @property (nonatomic, strong) NSMutableDictionary *thumbnailRepresentations; @property (nonatomic, strong) NSData *internalData; @property (nonatomic, copy) NSString *filename; -@property (nonatomic, strong) NSString *tempFilename; -@property (nonatomic, strong) NSString *cachePath; +@property (nonatomic, copy) NSString *tempFilename; +@property (nonatomic, copy) NSString *cachePath; @property (nonatomic, strong) NSFileManager *fm; @end diff --git a/Classes/BITHockeyAttachment.h b/Classes/BITHockeyAttachment.h index b788ed9154..ec6cd02df4 100644 --- a/Classes/BITHockeyAttachment.h +++ b/Classes/BITHockeyAttachment.h @@ -40,7 +40,7 @@ /** The filename the attachment should get */ -@property (nonatomic, readonly, strong) NSString *filename; +@property (nonatomic, readonly, copy) NSString *filename; /** The attachment data as NSData object @@ -50,7 +50,7 @@ /** The content type of your data as MIME type */ -@property (nonatomic, readonly, strong) NSString *contentType; +@property (nonatomic, readonly, copy) NSString *contentType; /** Create an BITHockeyAttachment instance with a given filename and NSData object diff --git a/Classes/BITHockeyBaseManagerPrivate.h b/Classes/BITHockeyBaseManagerPrivate.h index b65e16e6af..2438791932 100644 --- a/Classes/BITHockeyBaseManagerPrivate.h +++ b/Classes/BITHockeyBaseManagerPrivate.h @@ -35,7 +35,7 @@ @interface BITHockeyBaseManager() -@property (nonatomic, strong) NSString *appIdentifier; +@property (nonatomic, copy) NSString *appIdentifier; @property (nonatomic, assign, readonly) BITEnvironment appEnvironment; diff --git a/Classes/BITHockeyManager.h b/Classes/BITHockeyManager.h index fd673f26f5..485fc726a9 100644 --- a/Classes/BITHockeyManager.h +++ b/Classes/BITHockeyManager.h @@ -226,7 +226,7 @@ NS_ASSUME_NONNULL_BEGIN @warning This property needs to be set before calling `startManager` */ -@property (nonatomic, strong) NSString *serverURL; +@property (nonatomic, copy) NSString *serverURL; #if HOCKEYSDK_FEATURE_CRASH_REPORTER diff --git a/Classes/BITHockeyManager.m b/Classes/BITHockeyManager.m index 41b978fd9a..9f5e0a8fbc 100644 --- a/Classes/BITHockeyManager.m +++ b/Classes/BITHockeyManager.m @@ -81,8 +81,8 @@ static bitstadium_info_t bitstadium_library_info __attribute__((section("__TEXT, - (BOOL)shouldUseLiveIdentifier; -@property (nonatomic, strong) NSString *appIdentifier; -@property (nonatomic, strong) NSString *liveIdentifier; +@property (nonatomic, copy) NSString *appIdentifier; +@property (nonatomic, copy) NSString *liveIdentifier; @property (nonatomic) BOOL validAppIdentifier; @property (nonatomic) BOOL startManagerIsInvoked; @property (nonatomic) BOOL startUpdateManagerIsInvoked; diff --git a/Classes/BITPersistencePrivate.h b/Classes/BITPersistencePrivate.h index 30374beda0..9bba4df43e 100644 --- a/Classes/BITPersistencePrivate.h +++ b/Classes/BITPersistencePrivate.h @@ -37,7 +37,7 @@ FOUNDATION_EXPORT NSString *const BITPersistenceSuccessNotification; */ @property (nonatomic, assign) NSUInteger maxFileCount; -@property (nonatomic, strong) NSString *appHockeySDKDirectoryPath; +@property (nonatomic, copy) NSString *appHockeySDKDirectoryPath; /** * An array with all file paths, that have been requested by the sender. If the sender diff --git a/Classes/BITStoreUpdateManager.h b/Classes/BITStoreUpdateManager.h index 1b081b719f..b7b01d0233 100644 --- a/Classes/BITStoreUpdateManager.h +++ b/Classes/BITStoreUpdateManager.h @@ -120,7 +120,7 @@ typedef NS_ENUM(NSInteger, BITStoreUpdateSetting) { @see checkForUpdateOnLaunch @see checkForUpdate */ -@property (nonatomic, strong) NSString *countryCode; +@property (nonatomic, copy) NSString *countryCode; /** diff --git a/Classes/BITStoreUpdateManager.m b/Classes/BITStoreUpdateManager.m index 8979ac0628..c58e2d36bb 100644 --- a/Classes/BITStoreUpdateManager.m +++ b/Classes/BITStoreUpdateManager.m @@ -40,9 +40,9 @@ @interface BITStoreUpdateManager () -@property (nonatomic, strong) NSString *latestStoreVersion; -@property (nonatomic, strong) NSString *appStoreURLString; -@property (nonatomic, strong) NSString *currentUUID; +@property (nonatomic, copy) NSString *latestStoreVersion; +@property (nonatomic, copy) NSString *appStoreURLString; +@property (nonatomic, copy) NSString *currentUUID; @property (nonatomic) BOOL updateAlertShowing; @property (nonatomic) BOOL lastCheckFailed; @property (nonatomic, weak) id appDidBecomeActiveObserver; diff --git a/Classes/BITUpdateManager.m b/Classes/BITUpdateManager.m index 4beb2d1965..446967c798 100644 --- a/Classes/BITUpdateManager.m +++ b/Classes/BITUpdateManager.m @@ -54,14 +54,14 @@ typedef NS_ENUM(NSInteger, BITUpdateAlertViewTag) { @interface BITUpdateManager () -@property (nonatomic, strong) NSString *currentAppVersion; +@property (nonatomic, copy) NSString *currentAppVersion; @property (nonatomic) BOOL dataFound; @property (nonatomic) BOOL showFeedback; @property (nonatomic) BOOL updateAlertShowing; @property (nonatomic) BOOL lastCheckFailed; @property (nonatomic, strong) NSFileManager *fileManager; -@property (nonatomic, strong) NSString *updateDir; -@property (nonatomic, strong) NSString *usageDataFile; +@property (nonatomic, copy) NSString *updateDir; +@property (nonatomic, copy) NSString *usageDataFile; @property (nonatomic, weak) id appDidBecomeActiveObserver; @property (nonatomic, weak) id appDidEnterBackgroundObserver; @property (nonatomic, weak) id networkDidBecomeReachableObserver; @@ -69,9 +69,9 @@ typedef NS_ENUM(NSInteger, BITUpdateAlertViewTag) { @property (nonatomic) BOOL didEnterBackgroundState; @property (nonatomic) BOOL firstStartAfterInstall; @property (nonatomic, strong) NSNumber *versionID; -@property (nonatomic, strong) NSString *versionUUID; -@property (nonatomic, strong) NSString *uuid; -@property (nonatomic, strong) NSString *blockingScreenMessage; +@property (nonatomic, copy) NSString *versionUUID; +@property (nonatomic, copy) NSString *uuid; +@property (nonatomic, copy) NSString *blockingScreenMessage; @property (nonatomic, strong) NSDate *lastUpdateCheckFromBlockingScreen; @end diff --git a/Classes/BITUpdateManagerPrivate.h b/Classes/BITUpdateManagerPrivate.h index c23bf40803..5c0a3d2fb6 100644 --- a/Classes/BITUpdateManagerPrivate.h +++ b/Classes/BITUpdateManagerPrivate.h @@ -74,11 +74,11 @@ @property (nonatomic, strong) UIView *blockingView; -@property (nonatomic, strong) NSString *companyName; +@property (nonatomic, copy) NSString *companyName; -@property (nonatomic, strong) NSString *installationIdentification; +@property (nonatomic, copy) NSString *installationIdentification; -@property (nonatomic, strong) NSString *installationIdentificationType; +@property (nonatomic, copy) NSString *installationIdentificationType; @property (nonatomic) BOOL installationIdentified;