From de211b2d6ef13bb848627e2190fc3421970fad64 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Tue, 10 Jun 2014 15:53:21 +0200 Subject: [PATCH] Fix unit tests --- Classes/BITCrashManagerPrivate.h | 2 +- Support/HockeySDKTests/BITCrashManagerTests.m | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Classes/BITCrashManagerPrivate.h b/Classes/BITCrashManagerPrivate.h index f42062d07b..9c9194f93e 100644 --- a/Classes/BITCrashManagerPrivate.h +++ b/Classes/BITCrashManagerPrivate.h @@ -76,7 +76,7 @@ - (void)handleCrashReport; - (BOOL)hasPendingCrashReport; -- (BOOL)hasNonApprovedCrashReports; +- (NSString *)firstNotApprovedCrashReport; - (void)persistUserProvidedMetaData:(BITCrashMetaData *)userProvidedMetaData; - (void)persistAttachment:(BITCrashAttachment *)attachment withFilename:(NSString *)filename; diff --git a/Support/HockeySDKTests/BITCrashManagerTests.m b/Support/HockeySDKTests/BITCrashManagerTests.m index e276813017..0cb0840dca 100644 --- a/Support/HockeySDKTests/BITCrashManagerTests.m +++ b/Support/HockeySDKTests/BITCrashManagerTests.m @@ -209,9 +209,9 @@ assertThatBool([_sut hasPendingCrashReport], equalToBool(NO)); } -- (void)testHasNonApprovedCrashReportsWithNoFiles { +- (void)testFirstNotApprovedCrashReportWithNoFiles { _sut.crashManagerStatus = BITCrashManagerStatusAutoSend; - assertThatBool([_sut hasNonApprovedCrashReports], equalToBool(NO)); + assertThat([_sut firstNotApprovedCrashReport], equalTo(nil)); } @@ -247,7 +247,7 @@ // No files at startup assertThatBool([_sut hasPendingCrashReport], equalToBool(NO)); - assertThatBool([_sut hasNonApprovedCrashReports], equalToBool(NO)); + assertThat([_sut firstNotApprovedCrashReport], equalTo(nil)); [_sut invokeDelayedProcessing]; @@ -258,7 +258,7 @@ // we should have 0 pending crash report assertThatBool([_sut hasPendingCrashReport], equalToBool(NO)); - assertThatBool([_sut hasNonApprovedCrashReports], equalToBool(NO)); + assertThat([_sut firstNotApprovedCrashReport], equalTo(nil)); [_sut cleanCrashReports]; @@ -272,7 +272,7 @@ // we should have now 1 pending crash report assertThatBool([_sut hasPendingCrashReport], equalToBool(YES)); - assertThatBool([_sut hasNonApprovedCrashReports], equalToBool(YES)); + assertThat([_sut firstNotApprovedCrashReport], notNilValue()); // this is currently sending blindly, needs refactoring to test properly [_sut sendNextCrashReport]; @@ -287,7 +287,7 @@ // we should have now 1 pending crash report assertThatBool([_sut hasPendingCrashReport], equalToBool(YES)); - assertThatBool([_sut hasNonApprovedCrashReports], equalToBool(YES)); + assertThat([_sut firstNotApprovedCrashReport], notNilValue()); [_sut cleanCrashReports]; }