From e1597f902ae0742f45a6f3351b03cd0e2ff54237 Mon Sep 17 00:00:00 2001 From: Scott Goodson Date: Tue, 16 Feb 2016 22:19:27 -0800 Subject: [PATCH] Increase default value for leadingScreensForBatching to 2.0, as 1.0 is not enough for most network conditions / backend performance. --- AsyncDisplayKit/ASCollectionView.h | 2 +- AsyncDisplayKit/ASCollectionView.mm | 2 +- AsyncDisplayKit/ASTableView.h | 2 +- AsyncDisplayKit/ASTableView.mm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/AsyncDisplayKit/ASCollectionView.h b/AsyncDisplayKit/ASCollectionView.h index 6b4f8a38c6..f1475156e4 100644 --- a/AsyncDisplayKit/ASCollectionView.h +++ b/AsyncDisplayKit/ASCollectionView.h @@ -102,7 +102,7 @@ NS_ASSUME_NONNULL_BEGIN /** * The number of screens left to scroll before the delegate -collectionView:beginBatchFetchingWithContext: is called. * - * Defaults to one screenful. + * Defaults to two screenfuls. */ @property (nonatomic, assign) CGFloat leadingScreensForBatching; diff --git a/AsyncDisplayKit/ASCollectionView.mm b/AsyncDisplayKit/ASCollectionView.mm index eda88bf79f..b9f58ee5ff 100644 --- a/AsyncDisplayKit/ASCollectionView.mm +++ b/AsyncDisplayKit/ASCollectionView.mm @@ -180,7 +180,7 @@ static NSString * const kCellReuseIdentifier = @"_ASCollectionViewCell"; _batchContext = [[ASBatchContext alloc] init]; - _leadingScreensForBatching = 1.0; + _leadingScreensForBatching = 2.0; _asyncDataFetchingEnabled = NO; _asyncDataSourceLocked = NO; diff --git a/AsyncDisplayKit/ASTableView.h b/AsyncDisplayKit/ASTableView.h index b21d2ac94a..c2c50cab4a 100644 --- a/AsyncDisplayKit/ASTableView.h +++ b/AsyncDisplayKit/ASTableView.h @@ -106,7 +106,7 @@ NS_ASSUME_NONNULL_BEGIN /** * The number of screens left to scroll before the delegate -tableView:beginBatchFetchingWithContext: is called. * - * Defaults to one screenful. + * Defaults to two screenfuls. */ @property (nonatomic, assign) CGFloat leadingScreensForBatching; diff --git a/AsyncDisplayKit/ASTableView.mm b/AsyncDisplayKit/ASTableView.mm index 111e5afe18..477c6ff4a3 100644 --- a/AsyncDisplayKit/ASTableView.mm +++ b/AsyncDisplayKit/ASTableView.mm @@ -162,7 +162,7 @@ static NSString * const kCellReuseIdentifier = @"_ASTableViewCell"; _asyncDataFetchingEnabled = NO; _asyncDataSourceLocked = NO; - _leadingScreensForBatching = 1.0; + _leadingScreensForBatching = 2.0; _batchContext = [[ASBatchContext alloc] init]; _automaticallyAdjustsContentOffset = NO;