ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-09-06 04:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable ASRangeControllerUpdateRangeProtocol by default if view controller or node support it. (#2133)

Browse Source
This commit is contained in:
Garrett Moon 2016-08-25 21:18:04 -07:00 committed by Adlai Holler
parent 04ecd4180e
commit e3091737ca
2 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
AsyncDisplayKit/ASViewController.h
View File

@ -68,7 +68,7 @@ typedef ASTraitCollection * _Nonnull (^ASDisplayTraitsForTraitWindowSizeBlock)(C
* Automatically adjust range mode based on view events. If you set this to YES, the view controller or its node * Automatically adjust range mode based on view events. If you set this to YES, the view controller or its node
* must conform to the ASRangeControllerUpdateRangeProtocol. * must conform to the ASRangeControllerUpdateRangeProtocol.
* *
* Default value is NO. * Default value is YES *if* node or view controller conform to ASRangeControllerUpdateRangeProtocol otherwise it is NO.
*/ */
@property (nonatomic, assign) BOOL automaticallyAdjustRangeModeBasedOnViewEvents; @property (nonatomic, assign) BOOL automaticallyAdjustRangeModeBasedOnViewEvents;

19
AsyncDisplayKit/ASViewController.mm
View File

@ -29,7 +29,6 @@
NSInteger _visibilityDepth; NSInteger _visibilityDepth;
BOOL _selfConformsToRangeModeProtocol; BOOL _selfConformsToRangeModeProtocol;
BOOL _nodeConformsToRangeModeProtocol; BOOL _nodeConformsToRangeModeProtocol;
BOOL _didCheckRangeModeProtocolConformance;
} }
- (instancetype)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil - (instancetype)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil
@ -54,7 +53,9 @@
ASDisplayNodeAssertTrue(!node.layerBacked); ASDisplayNodeAssertTrue(!node.layerBacked);
_node = node; _node = node;
_automaticallyAdjustRangeModeBasedOnViewEvents = NO; _selfConformsToRangeModeProtocol = [self conformsToProtocol:@protocol(ASRangeControllerUpdateRangeProtocol)];
_nodeConformsToRangeModeProtocol = [_node conformsToProtocol:@protocol(ASRangeControllerUpdateRangeProtocol)];
_automaticallyAdjustRangeModeBasedOnViewEvents = _selfConformsToRangeModeProtocol || _nodeConformsToRangeModeProtocol;
return self; return self;
} }
@ -168,22 +169,18 @@ ASVisibilityDepthImplementation;
- (void)setAutomaticallyAdjustRangeModeBasedOnViewEvents:(BOOL)automaticallyAdjustRangeModeBasedOnViewEvents - (void)setAutomaticallyAdjustRangeModeBasedOnViewEvents:(BOOL)automaticallyAdjustRangeModeBasedOnViewEvents
{ {
if (automaticallyAdjustRangeModeBasedOnViewEvents != _automaticallyAdjustRangeModeBasedOnViewEvents) {
if (automaticallyAdjustRangeModeBasedOnViewEvents && _selfConformsToRangeModeProtocol == NO && _nodeConformsToRangeModeProtocol == NO) {
NSLog(@"Warning: automaticallyAdjustRangeModeBasedOnViewEvents set to YES in %@, but range mode updating is not possible because neither view controller nor node %@ conform to ASRangeControllerUpdateRangeProtocol.", self, _node);
}
_automaticallyAdjustRangeModeBasedOnViewEvents = automaticallyAdjustRangeModeBasedOnViewEvents; _automaticallyAdjustRangeModeBasedOnViewEvents = automaticallyAdjustRangeModeBasedOnViewEvents;
} }
}
- (void)updateCurrentRangeModeWithModeIfPossible:(ASLayoutRangeMode)rangeMode - (void)updateCurrentRangeModeWithModeIfPossible:(ASLayoutRangeMode)rangeMode
{ {
if (!_automaticallyAdjustRangeModeBasedOnViewEvents) { return; } if (!_automaticallyAdjustRangeModeBasedOnViewEvents) { return; }
if (!_didCheckRangeModeProtocolConformance) {
_selfConformsToRangeModeProtocol = [self conformsToProtocol:@protocol(ASRangeControllerUpdateRangeProtocol)];
_nodeConformsToRangeModeProtocol = [_node conformsToProtocol:@protocol(ASRangeControllerUpdateRangeProtocol)];
_didCheckRangeModeProtocolConformance = YES;
if (!_selfConformsToRangeModeProtocol && !_nodeConformsToRangeModeProtocol) {
NSLog(@"Warning: automaticallyAdjustRangeModeBasedOnViewEvents set to YES in %@, but range mode updating is not possible because neither view controller nor node %@ conform to ASRangeControllerUpdateRangeProtocol.", self, _node);
}
}
if (_selfConformsToRangeModeProtocol) { if (_selfConformsToRangeModeProtocol) {
id<ASRangeControllerUpdateRangeProtocol> rangeUpdater = (id<ASRangeControllerUpdateRangeProtocol>)self; id<ASRangeControllerUpdateRangeProtocol> rangeUpdater = (id<ASRangeControllerUpdateRangeProtocol>)self;
[rangeUpdater updateCurrentRangeWithMode:rangeMode]; [rangeUpdater updateCurrentRangeWithMode:rangeMode];