From f1ba1b092baf998c5e3c6661a9237a76a1d782e9 Mon Sep 17 00:00:00 2001 From: Stephan Diederich Date: Thu, 20 Jun 2013 14:24:44 +0200 Subject: [PATCH] fix analyzer warning it's somewhat more clear to release and set to nil, then store a new reference directly in the ivar. --- Classes/BITAttributedLabel.m | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Classes/BITAttributedLabel.m b/Classes/BITAttributedLabel.m index a06dda6fc3..dcf222fd3b 100755 --- a/Classes/BITAttributedLabel.m +++ b/Classes/BITAttributedLabel.m @@ -271,11 +271,16 @@ static inline NSAttributedString * NSAttributedStringBySettingColorFromContext(N - (CTFramesetterRef)framesetter { if (_needsFramesetter) { @synchronized(self) { - if (_framesetter) CFRelease(_framesetter); - if (_highlightFramesetter) CFRelease(_highlightFramesetter); + if (_framesetter) { + CFRelease(_framesetter); + _framesetter = nil; + } + if (_highlightFramesetter) { + CFRelease(_highlightFramesetter); + _highlightFramesetter = nil; + } - self.framesetter = CTFramesetterCreateWithAttributedString((__bridge CFAttributedStringRef)self.renderedAttributedText); - self.highlightFramesetter = nil; + _framesetter = CTFramesetterCreateWithAttributedString((__bridge CFAttributedStringRef)self.renderedAttributedText); _needsFramesetter = NO; } }