Fix Xcode 8 errors

This commit is contained in:
Michael Schneider
2016-07-08 08:05:44 -07:00
parent 8e1c8acb54
commit f25e0f0d01
3 changed files with 16 additions and 8 deletions

View File

@@ -39,6 +39,10 @@ NSInteger const ASDefaultDrawingPriority = ASDefaultTransactionPriority;
NSString * const ASRenderingEngineDidDisplayScheduledNodesNotification = @"ASRenderingEngineDidDisplayScheduledNodes"; NSString * const ASRenderingEngineDidDisplayScheduledNodesNotification = @"ASRenderingEngineDidDisplayScheduledNodes";
NSString * const ASRenderingEngineDidDisplayNodesScheduledBeforeTimestamp = @"ASRenderingEngineDidDisplayNodesScheduledBeforeTimestamp"; NSString * const ASRenderingEngineDidDisplayNodesScheduledBeforeTimestamp = @"ASRenderingEngineDidDisplayNodesScheduledBeforeTimestamp";
// Forward declare CALayerDelegate protocol as the iOS 10 SDK moves CALayerDelegate from a formal delegate to a protocol.
// We have to forward declare the protocol as this place otherwise it will not compile compiling with an Base SDK < iOS 10
@protocol CALayerDelegate;
@interface ASDisplayNode () <UIGestureRecognizerDelegate, _ASDisplayLayerDelegate, _ASTransitionContextCompletionDelegate> @interface ASDisplayNode () <UIGestureRecognizerDelegate, _ASDisplayLayerDelegate, _ASTransitionContextCompletionDelegate>
/** /**
@@ -493,7 +497,8 @@ static ASDisplayNodeMethodOverrides GetASDisplayNodeMethodOverrides(Class c)
if (isLayerBacked) { if (isLayerBacked) {
TIME_SCOPED(_debugTimeToCreateView); TIME_SCOPED(_debugTimeToCreateView);
_layer = [self _layerToLoad]; _layer = [self _layerToLoad];
_layer.delegate = self; // Surpress warning for Base SDK > 10.0
_layer.delegate = (id<CALayerDelegate>)self;
} else { } else {
TIME_SCOPED(_debugTimeToCreateView); TIME_SCOPED(_debugTimeToCreateView);
_view = [self _viewToLoad]; _view = [self _viewToLoad];

View File

@@ -223,9 +223,12 @@ NSAttributedString *ASCleanseAttributedStringOfCoreTextAttributes(NSAttributedSt
// kCTParagraphStyleSpecifierLineSpacing -> lineSpacing // kCTParagraphStyleSpecifierLineSpacing -> lineSpacing
// Note that kCTParagraphStyleSpecifierLineSpacing is deprecated and will die soon. We should not be using it. // Note that kCTParagraphStyleSpecifierLineSpacing is deprecated and will die soon. We should not be using it.
CGFloat lineSpacing; #pragma clang diagnostic push
if (CTParagraphStyleGetValueForSpecifier(coreTextParagraphStyle, kCTParagraphStyleSpecifierLineSpacing, sizeof(lineSpacing), &lineSpacing)) #pragma clang diagnostic ignored "-Wdeprecated-declarations"
newParagraphStyle.lineSpacing = lineSpacing; CGFloat lineSpacing;
if (CTParagraphStyleGetValueForSpecifier(coreTextParagraphStyle, kCTParagraphStyleSpecifierLineSpacing, sizeof(lineSpacing), &lineSpacing))
newParagraphStyle.lineSpacing = lineSpacing;
#pragma clang diagnostic pop
// kCTParagraphStyleSpecifierParagraphSpacing -> paragraphSpacing // kCTParagraphStyleSpecifierParagraphSpacing -> paragraphSpacing
CGFloat paragraphSpacing; CGFloat paragraphSpacing;

View File

@@ -160,7 +160,7 @@ for (ASDisplayNode *n in @[ nodes ]) {\
@end @end
@interface UIResponderNodeTestView : _ASDisplayView @interface UIResponderNodeTestView : _ASDisplayView
@property(nonatomic) BOOL isFirstResponder; @property(nonatomic) BOOL testIsFirstResponder;
@end @end
@implementation UIDisplayNodeTestView @implementation UIDisplayNodeTestView
@@ -192,7 +192,7 @@ for (ASDisplayNode *n in @[ nodes ]) {\
@implementation UIResponderNodeTestView @implementation UIResponderNodeTestView
- (BOOL)becomeFirstResponder { - (BOOL)becomeFirstResponder {
self.isFirstResponder = YES; self.testIsFirstResponder = YES;
return YES; return YES;
} }
@@ -202,8 +202,8 @@ for (ASDisplayNode *n in @[ nodes ]) {\
- (BOOL)resignFirstResponder { - (BOOL)resignFirstResponder {
[super resignFirstResponder]; [super resignFirstResponder];
if (self.isFirstResponder) { if (self.testIsFirstResponder) {
self.isFirstResponder = NO; self.testIsFirstResponder = NO;
return YES; return YES;
} }
return NO; return NO;