add comments to deprecated getter methods, remove extraneous if statements

This commit is contained in:
Hannah Trosi
2016-07-05 21:30:09 -07:00
parent 3994f2089c
commit f6d30b668d
3 changed files with 8 additions and 12 deletions

View File

@@ -126,6 +126,10 @@ typedef NS_ENUM(NSUInteger, ASCellNodeVisibilityEvent) {
@interface ASCellNode (Deprecated) @interface ASCellNode (Deprecated)
/**
* Previous versions of ASDK did not include "is" in the name of the getter for these properties.
* These older accessor methods don't match UIKit naming, and will be removed in a future version.
*/
- (BOOL)selected ASDISPLAYNODE_DEPRECATED; - (BOOL)selected ASDISPLAYNODE_DEPRECATED;
- (BOOL)highlighted ASDISPLAYNODE_DEPRECATED; - (BOOL)highlighted ASDISPLAYNODE_DEPRECATED;

View File

@@ -42,12 +42,8 @@ static NSString * const kCellReuseIdentifier = @"_ASCollectionViewCell";
- (void)setNode:(ASCellNode *)node - (void)setNode:(ASCellNode *)node
{ {
_node = node; _node = node;
if (node.selected != self.selected) { [node __setSelectedFromUIKit:self.selected];
[node __setSelectedFromUIKit:self.selected]; [node __setHighlightedFromUIKit:self.highlighted];
}
if (node.highlighted != self.highlighted) {
[node __setHighlightedFromUIKit:self.highlighted];
}
} }
- (void)setSelected:(BOOL)selected - (void)setSelected:(BOOL)selected

View File

@@ -67,12 +67,8 @@ static NSString * const kCellReuseIdentifier = @"_ASTableViewCell";
- (void)setNode:(ASCellNode *)node - (void)setNode:(ASCellNode *)node
{ {
_node = node; _node = node;
if (node.selected != self.selected) { [node __setSelectedFromUIKit:self.selected];
[node __setSelectedFromUIKit:self.selected]; [node __setHighlightedFromUIKit:self.highlighted];
}
if (node.highlighted != self.highlighted) {
[node __setHighlightedFromUIKit:self.highlighted];
}
} }
- (void)setSelected:(BOOL)selected animated:(BOOL)animated - (void)setSelected:(BOOL)selected animated:(BOOL)animated