[#trivial] fixes rendered image quality on networked image nodes which have their image directly set. (#826)

This commit is contained in:
Garrett Moon 2018-03-08 16:21:54 -08:00 committed by GitHub
parent d70ab3e43c
commit f99dd68a9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions

View File

@ -120,13 +120,19 @@ NS_ASSUME_NONNULL_BEGIN
@property (nonatomic, assign, readwrite) BOOL shouldRenderProgressImages;
/**
* The image quality of the current image. This is a number between 0 and 1 and can be used to track
* The image quality of the current image.
*
* If the URL is set, this is a number between 0 and 1 and can be used to track
* progressive progress. Calculated by dividing number of bytes / expected number of total bytes.
* This is zero until the first progressive render or the final display.
*
* If the URL is unset, this is 1 if defaultImage or image is set to non-nil.
*
*/
@property (nonatomic, assign, readonly) CGFloat currentImageQuality;
/**
* The image quality (value between 0 and 1) of the last image that completed displaying.
* The currentImageQuality (value between 0 and 1) of the last image that completed displaying.
*/
@property (nonatomic, assign, readonly) CGFloat renderedImageQuality;

View File

@ -141,6 +141,11 @@
[self _locked_cancelDownloadAndClearImageWithResumePossibility:NO];
}
// If our image is being set externally, the image quality is 100%
if (imageWasSetExternally) {
[self _setCurrentImageQuality:1.0];
}
[self _locked__setImage:image];
}
@ -227,7 +232,6 @@
if (!_imageLoaded) {
[self _setCurrentImageQuality:((_URL == nil) ? 0.0 : 1.0)];
[self _locked__setImage:defaultImage];
}
}