From fdb54a02d94fbbede7c97ef67b9554bf3ee00074 Mon Sep 17 00:00:00 2001 From: Adlai Holler Date: Mon, 17 Apr 2017 11:38:07 -0700 Subject: [PATCH] Fix case where we forget to unlock in ASNetworkImagenode (#17) --- Source/ASNetworkImageNode.mm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Source/ASNetworkImageNode.mm b/Source/ASNetworkImageNode.mm index fe1d08b714..04ddd1b931 100755 --- a/Source/ASNetworkImageNode.mm +++ b/Source/ASNetworkImageNode.mm @@ -403,7 +403,7 @@ static const CGSize kMinReleaseImageOnBackgroundSize = {20.0, 20.0}; - (void)handleProgressImage:(UIImage *)progressImage progress:(CGFloat)progress downloadIdentifier:(nullable id)downloadIdentifier { - __instanceLock__.lock(); + ASDN::MutexLocker l(__instanceLock__); // Getting a result back for a different download identifier, download must not have been successfully canceled if (ASObjectIsEqual(_downloadIdentifier, downloadIdentifier) == NO && downloadIdentifier != nil) { @@ -412,8 +412,6 @@ static const CGSize kMinReleaseImageOnBackgroundSize = {20.0, 20.0}; [self _locked_setCurrentImageQuality:progress]; [self _locked__setImage:progressImage]; - - __instanceLock__.unlock(); } - (void)_updateProgressImageBlockOnDownloaderIfNeeded