From c3d3713c1cf41b92c39194396df0f20902822326 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Spie=C3=9F?= Date: Tue, 20 Oct 2015 15:28:47 +0200 Subject: [PATCH] Fix bug where setUserID never works Previously, this was always overwritten by the installationIdentifier --- Classes/BITCrashManager.m | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Classes/BITCrashManager.m b/Classes/BITCrashManager.m index d9f83b4b28..7305f6329c 100644 --- a/Classes/BITCrashManager.m +++ b/Classes/BITCrashManager.m @@ -583,9 +583,7 @@ static void uncaught_cxx_exception_handler(const BITCrashUncaughtCXXExceptionInf * @return The userID value */ - (NSString *)userIDForCrashReport { - // first check the global keychain storage - NSString *userID = [self stringValueFromKeychainForKey:kBITHockeyMetaUserID] ?: @""; - + NSString *userID; #if HOCKEYSDK_FEATURE_AUTHENTICATOR // if we have an identification from BITAuthenticator, use this as a default. if (( @@ -597,13 +595,19 @@ static void uncaught_cxx_exception_handler(const BITCrashUncaughtCXXExceptionInf } #endif + // first check the global keychain storage + NSString *userIdFromKeychain = [self stringValueFromKeychainForKey:kBITHockeyMetaUserID]; + if (userIdFromKeychain) { + userID = userIdFromKeychain; + } + if ([[BITHockeyManager sharedHockeyManager].delegate respondsToSelector:@selector(userIDForHockeyManager:componentManager:)]) { userID = [[BITHockeyManager sharedHockeyManager].delegate userIDForHockeyManager:[BITHockeyManager sharedHockeyManager] - componentManager:self] ?: @""; + componentManager:self]; } - return userID; + return userID ?: @""; } /**