ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2025-12-24 07:05:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Minor Breaking API] Make deallocation queues more reliable (#651)

Browse Source 
* Make our async deallocation functions take a double pointer, so we can be sure we've released before the queue drains

* Make it a class property

* Fix the return type

* Use a locker

* Improve release notes
This commit is contained in:
Adlai Holler
2017-11-02 10:45:34 -07:00
committed by GitHub
parent 64b6242b9c
commit ff608c92bf
13 changed files with 45 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
Source/ASDisplayNodeExtras.mm
View File

@@ -23,8 +23,7 @@
#import <queue>
#import <AsyncDisplayKit/ASRunLoopQueue.h>
extern void ASPerformMainThreadDeallocation(_Nullable id object)
{
extern void ASPerformMainThreadDeallocation(id _Nullable __strong * _Nonnull objectPtr) {
/**
* UIKit components must be deallocated on the main thread. We use this shared
* run loop queue to gradually deallocate them across many turns of the main run loop.
@@ -35,8 +34,14 @@ extern void ASPerformMainThreadDeallocation(_Nullable id object)
queue = [[ASRunLoopQueue alloc] initWithRunLoop:CFRunLoopGetMain() retainObjects:YES handler:nil];
queue.batchSize = 10;
});
if (object != nil) {
[queue enqueue:object];
if (objectPtr != NULL && *objectPtr != nil) {
// Lock queue while enqueuing and releasing, so that there's no risk
// that the queue will release before we get a chance to release.
[queue lock];
[queue enqueue:*objectPtr]; // Retain, +1
*objectPtr = nil; // Release, +0
[queue unlock]; // (After queue drains), release, -1
}
}