45 Commits

Author SHA1 Message Date
Hannah Troisi
2834ba3490 [ASPagerNode] Fix ASPagerNodeProxy to use collectionNode (#2475)
* Fix ASProxyDelegate to use collectionNode

* fix constrainedSize...issue
2016-10-24 16:10:56 -07:00
Hannah Troisi
f7b30577b8 Pager Node Should Implement New ASCollectionDataSource/Delegate Methods (#2466) 2016-10-24 10:58:04 -07:00
Adlai Holler
c2ea7cfeac [Umbrella] ASCollectionView -> ASCollectionNode Migration, Separate Index Spaces (#2372)
* Separate dataSource & UIKit index spaces

Beef up our supplementary node support

Make the API way better

Go nuts

Add a unit test for UICollectionView's handling of reloadData inside batch updates

Wrap indexPathForNode: in a cache

Convert index paths in delegate methods

Go back on table view

Put collection view back

Switch up the API

Move most ASCollectionView API to ASCollectionNode

Move most table logic over to ASTableNode

Do the things

More conversion work

Keep on keepin' on

Get table view delegate API done

More porting

Simplify

Clear the delegate

More cleanup

Move more stuff around

Remove pointless file

Re-add some API

Put back more API

Use the right flag

* Some cleanup

* Remove incorrect comment

* Tweak the API

* Put back a couple methods

* update example projects (note: ASCollectionView deprecation warnings expected)

* change reloadDataWithCompletion:nil --> reloadData

* Clean up rebase

* Make deprecated numberOfItemsInSection methods optional

* Use the right flag

* Address nits

* update ASDKTube, ASDKgram & ASViewController examples
2016-10-14 17:21:16 -07:00
Adlai Holler
33a680255c [ASDisplayNode] Add Convenience Interface State Accessors (#2168)
* Finish renaming fetchData range, add convenience accessors

* Update example

* Update new tests
2016-09-01 16:44:16 -07:00
Adlai Holler
fa3a988b54 [ASPagerNode] Rename constrainedSizeForNodeAtIndexPath: to constrainedSizeForNodeAtIndex: for consistency (#2097) 2016-08-19 11:47:56 -07:00
Michael Schneider
365f739ce7 Fix ASPagerNode delegate and data source warning (#2076) 2016-08-15 20:58:50 -07:00
Michael Schneider
067e4998e2 Fix methods from ASCollectionDelegate are not passed through to pager delegate (#2074) 2016-08-15 17:23:39 -07:00
Michael Schneider
93be894e0c [ASCollectionView / ASPagerNode] Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate (#2065)
* Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate in ASCollectionView and ASPagerNode

* Fix ASPagerNode declaration of dataSource and delegate

As ASPagerDataSource does not inherit from ASCollectionDataSource it's not possible to declare it as property.

* Update comment
2016-08-12 15:37:23 -07:00
appleguy
3b2af7eb6d [Build] Remove Unused Imports across all of AsyncDisplayKit. This uses a feature of AppCode. (#1875)
Details on the tool are here: https://www.jetbrains.com/help/idea/2016.1/optimizing-imports.html
2016-07-09 17:20:59 -07:00
Kiel Gillard
6a15ab6130 * Tidy the header imports, forward declaring classes and protocols where appropriate to avoid import cycles and using the framework/system header notation for imports occuring in .h files.
* Perhaps controversially, decomposing ASRangeControllerUpdateRangeProtocol+Beta.h such that the categories on various classes are defined in the classes themselves since that's where the implementation of those categories is provided.
* Updating unit tests and import other headers the tests took for granted. The tests could probably import the umbrella header and not have to worry about this.
* Updating the "Life without Cocoapods" sample to build and run dependent on ASDK as a static library.
* Added a "Life With Frameworks" sample app to build and run dependent on ASDK as a framework, proving the framework targets work.
2016-07-07 15:12:19 +10:00
Levi McCallum
53bc126ae5 Add implementation of nodeForPageAtIndex: 2016-07-01 09:42:39 -07:00
Hannah Troisi
c857e809f4 Clean up header comments (for consistent Facebook licensing info) (#1741)
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
Michael Schneider
3e8ea64a1b Update to latest state 2016-06-09 15:46:08 -07:00
Michael Schneider
1c6686e5d6 Improve rotation support for ASPagerNode 2016-06-09 15:46:08 -07:00
Michael Schneider
298b9a2be7 Fix ASPagerNode data source and delegate inconsistencies
- Change ASPagerNodeDataSource -> ASPagerDataSource
- Add ASPagerDelegate
2016-05-04 21:03:13 -07:00
Levi McCallum
66c8c8f47d Add rotation support to ASPagerNode 2016-02-12 13:45:22 -08:00
Huy Nguyen
5b135e1837 ASPagerNode uses its view's size for node constrained sizes 2016-02-11 23:59:41 -08:00
Huy Nguyen
3e56a327c7 Add constrainedSizeForNodeAtIndexPath to ASPagerNodeDataSource 2016-02-11 10:47:27 -08:00
Rahul Malik
3e5daf4ccd Update data source protocols to make synchronous node creation api methods optional. 2016-02-09 22:47:43 -08:00
Rahul Malik
6c240a2fce ASPagerNode's api was not updated while addressing comments on the initial
ASCellNode background allocation PR. This change fixes that issue.
2016-02-05 15:09:08 -08:00
appleguy
1655d0a0c7 Merge pull request #1178 from nguyenhuy/range_tuning_params_follow_up
More on range mode and range controller
2016-02-04 16:59:42 -08:00
Rahul Malik
c4f489b074 Address comments. 2016-02-04 16:56:29 -08:00
Huy Nguyen
79f7450742 ASPagerNode less aggressively pre-renders 2016-02-04 16:53:53 -08:00
Huy Nguyen
4cf0e3e380 Update range tunining params for ASPagerNode 2016-02-04 15:44:47 -08:00
Rahul Malik
521c3fa1c1 Move ASCellNode allocation off the main thread by the addition of a node block
API in ASDataController. Move allocations and loaded node layouts to occur
during batch layout phase.
2016-02-04 10:38:59 -08:00
appleguy
ccbf38c72e Merge pull request #1096 from facebook/pr/1059
[tvOS] Initial changes to support building AsyncDisplayKit for tvOS.
2016-01-23 12:28:43 -08:00
Scott Goodson
e92a1360e7 Ensure new ASPagerNode has a weak reference to the data source. 2016-01-14 21:43:46 -08:00
Aaron Schubert
cc4f604ea3 [tvOS] Initial commit to make build run. 2016-01-12 14:43:30 +00:00
Scott Goodson
b273f358f5 [ASRangeController] Initial implementation of functional-style, ASInterfaceState-based range controller. 2016-01-01 00:48:44 -08:00
Scott Goodson
ffcddf36e2 Ensure that ASRangeController immediately removes any deleted nodes from its range state. 2015-12-30 22:42:11 -08:00
Scott Goodson
051f1f6cdd Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit. 2015-12-29 22:24:44 -08:00
Scott Goodson
1870208153 [ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten. 2015-12-29 20:46:42 -08:00
Scott Goodson
a2cf2a88e6 Overhaul header files / includes to eliminate circular references that Xcode 7 is angry about. 2015-12-25 19:22:00 -08:00
Scott Goodson
f902b4bdc7 Replace property declaration with method overrides for -dataSource. 2015-12-24 22:47:54 -08:00
Scott Goodson
a0e4484ef7 Declare ASPagerNode dataSource property as @dynamic so that it can be a different type than ASCollectionNode. 2015-12-24 22:27:52 -08:00
Scott Goodson
7ece41ff64 Delegate definition tweaks for Table and Collection; ensure Table tests run with ARC enabled. 2015-12-24 21:41:12 -08:00
Scott Goodson
27c151095b [ASPagerNode] New API tweaks. Support setting delegate + dataSource on ASCollectionNode and ASTableNode without triggering view creation. 2015-12-24 17:06:57 -08:00
Scott Goodson
928c440b4c Several small optimizations, especially to _ASPendingState and other hot paths. 2015-12-23 16:38:33 -08:00
Levi McCallum
10030dfe70 Add scroll to page helper to ASPagerNode 2015-12-21 09:07:48 -06:00
Levi McCallum
ad4db73b95 Add tuning params method forwards to ASCollectionNode 2015-12-21 09:01:19 -06:00
Levi McCallum
2bb7fc43f5 Add reloadData forward methods to ASCollectionNode 2015-12-21 08:58:55 -06:00
Levi McCallum
63b493a95b Increase preload tuning param range in pager node 2015-12-21 08:54:13 -06:00
Levi McCallum
53d2af6ca1 Move PagerNode setup into didLoad 2015-12-21 08:52:41 -06:00
Levi McCallum
669fd38dd4 Fix project includes for ASPagerNode 2015-12-16 17:53:21 -08:00
Levi McCallum
aea5a3318e Implement simple horizontal paging node 2015-12-16 17:53:21 -08:00