Michael Schneider
70b647c2b9
Add support for setting a static image to ASNetworkImageNode
2016-12-05 16:43:46 -08:00
Michael Schneider
143abdaa96
Change Header of ASImageNode+Private
2016-12-05 16:43:46 -08:00
Michael Schneider
9adb6554fc
Add assertion against externally setting .image in specific ASImageNode subclasses
2016-12-05 16:43:46 -08:00
Adlai Holler
45c69ada36
Add some index path validation to avoid production crashes ( #2716 )
2016-12-05 16:37:44 -08:00
Adlai Holler
42c7bb291e
Merge pull request #2715 from facebook/AHMoreBatchFetching
...
Ensure Batch Fetching Includes Leading Screens, Even if Not Scrolling
2016-12-05 16:27:01 -08:00
Adlai Holler
20c66f1025
Beef up the tests
2016-12-05 15:37:49 -08:00
Adlai Holler
9bc58dc024
When not visible, only batch fetch to fill visible area
2016-12-05 15:00:39 -08:00
Adlai Holler
21cad90355
Ensure we always fill leading screens for batching
2016-12-05 14:51:07 -08:00
Benjamin Scholtysik (Reimold)
05768216a2
Merge remote-tracking branch 'Public/release/4.1.3' into feature/persian-localization
2016-12-05 13:14:45 -08:00
Benjamin Scholtysik (Reimold)
0e2f4701ce
Merge branch 'fix/check-if-strongSelf-is-not-null' into release/4.1.3
2016-12-05 13:11:49 -08:00
Adlai Holler
b775a1a8eb
Merge pull request #2712 from facebook/AHFixAssertionMacros
...
Improve Assertion Macros
2016-12-05 12:54:14 -08:00
Adlai Holler
19b97a68af
Fix our assertion macros
2016-12-05 11:42:26 -08:00
Michael Schneider
a2e75152f8
[ASDisplayNode] Fix flickering for nodes that support range managed interface state ( #2710 )
...
* Fix flickering for range managed nodes
* Go back to old behavior to check for range managed before calling didExitPreloadState in interface state change
2016-12-05 10:34:03 -08:00
Michael Schneider
e361d00a73
Our calculated layout is suitable for this constrainedSize, so keep using it and invalidate any pending layout that has been generated in the past. ( #2706 )
2016-12-02 16:17:14 -08:00
Benjamin Scholtysik (Reimold)
105eeb04ac
Update the readme.
2016-12-02 14:34:18 -08:00
Benjamin Scholtysik (Reimold)
133e520d3c
Updated Changelog template
2016-12-02 14:30:28 -08:00
Benjamin Scholtysik (Reimold)
6b3e29e07a
fix a typo
2016-12-02 14:18:00 -08:00
Benjamin Scholtysik (Reimold)
ed83c5b4f4
Bump version in xcconfig.
2016-12-02 14:16:51 -08:00
Benjamin Scholtysik (Reimold)
7dbf453b87
Update podspecs
2016-12-02 14:09:34 -08:00
Benjamin Scholtysik (Reimold)
9c7af91cc3
remove unused xcconfig
2016-12-02 14:06:52 -08:00
Adlai Holler
1997073802
Address Misc Warnings ( #2698 )
...
* Address compiler warnings
* Typo
2016-12-02 14:04:05 -08:00
Garrett Moon
9706b85145
Remove files that no longer exist from podfile exclusion ( #2697 )
...
* Remove files that no longer exist from podfile exclusion
* Missed some references to dealloc2main
2016-12-02 13:29:16 -08:00
Andrew Yates
8ab83504e3
Update Readme logo ( #2691 )
2016-12-02 13:14:53 -08:00
Benjamin Scholtysik (Reimold)
f6435e9aef
null check strongSelf before deref in [BITChannel startTimer] #90
2016-12-02 12:44:32 -08:00
Garrett Moon
d9209e69c2
Update to RC 1 ( #2695 )
2016-12-02 10:00:15 -08:00
Adlai Holler
40a8769217
Filter out extra items when querying collection view layout ( #2693 )
2016-12-02 08:48:46 -08:00
Adlai Holler
8e90a31cc1
Merge pull request #2687 from maicki/MSBetterErrorMessageForDeallocatedDisplayNodeInLayout
...
Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode
2016-12-01 17:39:56 -08:00
Adlai Holler
051b738236
Inject data source class name into update validation exceptions, deprecate suppression flag ( #2692 )
2016-12-01 17:30:36 -08:00
Garrett Moon
8f7a632f4c
Add the slack channel to the issue template. ( #2690 )
2016-12-01 14:00:36 -08:00
Garrett Moon
ba2268ac99
2611 rename fetch data ( #2689 )
...
* Replace fetch data with preload terminology
- Deprecate `-fetchData` and `-clearFetchedData` in favor of `-preload` and `-clearPreloadedData`
- Move `-setNeedsPreload`, `-recursivelyPreload` and `-recursivelyClearPreloadedData` to ASDisplayNode+FrameworkPrivate.h
- Update internal implementation, comments and tests
* Folllow up on #2642 :
- Remove -preload and -clearPreloadedData in favor of -didEnterPreloadState and -didExitPreloadState.
- -didEnterPreloadState and -didExitPreloadState call the deprecated -fetchData and -clearFetchedData methods if they are overriden.
* Missed one in a test
* Get rid of behavior change for now.
* Revert more behavior changes, fix tests.
* Don't need these anymore.
2016-12-01 13:41:22 -08:00
Michael Schneider
c7ea15a5e4
Misc improvements to ASViewController ( #2653 )
...
- Remove layoutThatFit: call in viewWillAppear:
- Deprecate nodeConstrainedSize
- Use the view’s bounds to layout the node
2016-12-01 09:56:41 -08:00
Michael Schneider
66acd69e22
Better error message if a display node is created in layoutSpecThatFits: and deallocated before it was added to a subnode
2016-12-01 07:03:39 -08:00
Benjamin Scholtysik (Reimold)
81ef0681c2
Merge remote-tracking branch 'Public/develop' into feature/persian-localization
2016-11-30 13:30:15 -08:00
Benjamin Scholtysik (Reimold)
3eb6e430e4
Merge remote-tracking branch 'Public/develop' into feature/persian-localization
2016-11-30 13:25:48 -08:00
Benjamin Scholtysik (Reimold)
ffdfac2ac3
Merge pull request #359 from tabuchid/new-thread
...
Force New Feedback thread
2016-11-30 13:20:45 -08:00
Adlai Holler
b075aa2851
Merge pull request #2682 from facebook/AHFixMoreDeallocVisibleCases
...
Fix Edge Cases of Table Cell Nodes Deallocated While Visible
2016-11-30 09:01:01 -08:00
Adlai Holler
81a04bc93b
Remove magic number
2016-11-30 09:00:48 -08:00
Doug Tabuchi
8c398689cb
Merge pull request #1 from TroubleMakerBen/new-thread
...
New thread
2016-11-30 12:56:01 +01:00
Benjamin Scholtysik (Reimold)
b5cc5dc4e9
Fix copyright notice
2016-11-29 17:18:58 -08:00
Benjamin Scholtysik (Reimold)
15607295eb
Use FeedbackManagerDelegate to add forse a new feedback thread.
2016-11-29 17:16:19 -08:00
Adlai Holler
361f7be6ed
Merge pull request #2681 from facebook/2.0-beta.3
...
Update podspec to beta 3
2016-11-29 17:05:56 -08:00
Adlai Holler
98ef8c00de
Reduce cleverness
2016-11-29 16:27:33 -08:00
Adlai Holler
3fe87ffb64
Add a test replicating Issue 2252
2016-11-29 16:19:48 -08:00
Adlai Holler
bb8d7d1be9
Modify ASTableView range code to fix interface state issues with grouped tables
2016-11-29 15:42:00 -08:00
Garrett Moon
7c685620aa
Update podspec to beta 3
2016-11-29 14:58:41 -08:00
Adlai Holler
df497b82c2
Improve Batch Fetching Call Pattern to Reduce Fetch Calls ( #2675 )
...
* Test & tweak batch fetching implementation
* Tighten the test
* Stop batch fetching at the end of range controller pass
* Clean up the test
* Still check for batch fetching after each frame when scrolling
* Ensure batch fetching happens for empty collection/table
2016-11-29 13:40:03 -08:00
appleguy
aa9dff00de
Merge pull request #2672 from facebook/AHRemoveVCFetch
...
[ASViewController] Remove Extra recursivelyFetchData Call
2016-11-29 10:46:22 -08:00
appleguy
7861c63a68
Merge pull request #2676 from maicki/MSRevertConstrainedSizeChanges
...
Revert constrainedSize changes that should have never made it in
2016-11-28 17:23:50 -08:00
Michael Schneider
52bb2a3a6e
Revert constrainedSize changes that should have never made it in
2016-11-28 17:20:26 -08:00
Adlai Holler
b00365ac59
Remove explicit recursivelyFetchData call from ASViewController
2016-11-28 15:34:46 -08:00
