Commit Graph

13022 Commits

Author SHA1 Message Date
Yue-Wang-Google
a38f3db6b0 set the right attributes for block properties. (#2113)
* set the right attributes for block properties.

* oops. should remove strong.

* Update ASImageNode.mm

* revert to use copy for blocks. See apple documentation below

https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW12

* make the block properties nonatomic.
2016-08-21 13:06:21 -07:00
Yue-Wang-Google
1951954ba5 remove non unicode char (#2109)
see https://github.com/facebook/AsyncDisplayKit/issues/2108
2016-08-19 17:51:41 -07:00
Adlai Holler
69e73065e5 Avoid accessing itemCountsFromDataSource off-main (#2106) 2016-08-19 12:10:19 -07:00
Adlai Holler
fa3a988b54 [ASPagerNode] Rename constrainedSizeForNodeAtIndexPath: to constrainedSizeForNodeAtIndex: for consistency (#2097) 2016-08-19 11:47:56 -07:00
Adlai Holler
0bd664f9ed Remove numberOfSectionsForSupplementaryNodeOfKind: Method (#2102)
* Add unit test to confirm that supplementary items must be contained within actual sections

* [ASLayoutInspecting] Deprecate collectionView:numberOfSectionsForSupplementaryNodeOfKind:

* Add another test to dig deeper into UICollectionView
2016-08-19 11:18:31 -07:00
Peter
ebad7614d1 no message 2016-08-19 16:22:12 +03:00
Peter
d52005a3f2 no message 2016-08-19 16:20:44 +03:00
Peter
e32d035f94 no message 2016-08-19 16:20:23 +03:00
Peter
0eb6029dc9 no message 2016-08-19 16:20:03 +03:00
Peter
7cad465acf no message 2016-08-19 16:19:48 +03:00
Peter
d957d51b7c no message 2016-08-19 16:19:30 +03:00
Peter
d51b7e9c54 no message 2016-08-19 16:19:11 +03:00
Brandon Withrow
529b485454 Added Taxonomy file 2016-08-18 16:07:08 -07:00
Michael Schneider
cbec803b31 Merge pull request #2103 from facebook/newlines
[Build settings] add missing newlines at end of file
2016-08-18 15:31:52 -07:00
Hannah Trosi
971d43ad4d [Build settings] add missing newlines at end of file 2016-08-18 15:01:41 -07:00
Michael Schneider
c409e79714 Fix accessibleElements warning in _ASDisplayView (#2100) 2016-08-18 13:12:19 -07:00
Adlai Holler
85f2a2a128 Remove reference to gone file ASLayoutSpec+Private.h (#2101) 2016-08-18 13:08:30 -07:00
Adlai Holler
f61b7d5d5d [ASDisplayView] Remove some gunk (#2095) 2016-08-18 10:16:09 -07:00
Adlai Holler
00af76226d [ASDisplayNode] Clarify logic around calling setNeedsDisplay (#2094) 2016-08-18 09:45:43 -07:00
Adlai Holler
4baffea8f6 [ASTableView] Ignore table view cell layouts when there's no node assigned (#2091) 2016-08-17 19:58:40 -07:00
Garrett Moon
86d2ab617e I didn't really understand NSProxy (#2089)
* I didn't really understand NSProxy

But I think I do now :)

Previously I inherited from NSObject because I didn't think I needed
anything fancy, but it turns out NSProxy is *less* fancy than NSObject
and allows for overriding more methods. This change is probably purely
academic in that we don't use this class to forward NSObject specific
messages, but I believe this is the 'right thing'.

* Update comment, thanks @maicki!
2016-08-17 17:59:28 -07:00
Adlai Holler
99574a728c Make our snapshot testing possible without framework-private access, simplify (#2083) 2016-08-17 17:42:37 -07:00
Garrett Moon
7d21ccc184 [_ASDisplayViewAccessiblity] Fix accessibility in scroll views (#2079)
* Fixes issues with accessibility elements in scroll views

There are two changes here:

1. Because we can't reliably update the screen positions of accessibility elements
contained within a scroll view, we need to calculate them on demand, so we override
the accessibilityFrame method to do that.

2. Throwing away our calculated accessibility elements on frame change seemed to
cause the accessibility system to be confused.

Combining these two fixes together results in success, yay!

* Don't set the accessibilityFrame, getter is overridden.
2016-08-16 17:01:06 -07:00
Brandon Withrow
5a32c0282d Completion Block 2016-08-16 16:59:03 -07:00
Adlai Holler
05dba2263c Make ASWeakSet and NSArray+Diffing public, add support for large arrays (#2078) 2016-08-16 16:47:26 -07:00
Michael Schneider
ba27d6845c Merge pull request #2081 from garrettmoon/fixASCellNodeTransition
ASCellNode was overriding old deprecated methods
2016-08-16 16:40:58 -07:00
Garrett Moon
eb497b7db1 ASCellNode was overriding old deprecated methods
It needs to override the new signatures as well.
2016-08-16 15:40:55 -07:00
Brandon Withrow
6b675964ea Merge pull request #1 from brandon-withrow/btw/lotte/ellipse
Btw/lotte/ellipse
2016-08-16 15:30:23 -07:00
Brandon Withrow
fc77bffe3f Removed layer 2016-08-16 15:29:47 -07:00
Brandon Withrow
cbf43d35ae Add gitignore, updated ellipse draw 2016-08-16 15:27:35 -07:00
Brandon Withrow
7b6c0c6a7a Work on stroke issues, rewrite ellipse creation 2016-08-16 15:22:49 -07:00
Michael Schneider
c65b2efed7 [_ASDisplayViewAccessiblity] Improve accessibility support (#2060)
* First approach to improve accessiblity

* Clear accessibleElements in addSubview: and willRemoveSubview:

* Adjust comments and rename viewNode to node

* Create new accessible elements if screen coordinates of view changes

* Remove legacy clearing of accessibleElements

* Performance improvements

* Use bounds for screenFrame calculation and indexOfObjectIdentical: in indexOfAccessiblityElement:

* Add ASDK_ACCESSIBILITY_DISABLE compiler flag to disable custom accessibility code in ASDK

* No need to set a frame if a subnode view is an accessibility element and not layer backed
2016-08-16 10:27:14 -07:00
Hannah Troisi
14ccb0b886 [ASTextNode] placeholder image shouldn't draw for zero area strings (#2069)
* placeholder should not draw if area is zero

* styling fix

* super precision
2016-08-16 10:20:59 -07:00
Adlai Holler
56ee00986f [Architecture] Add plans for new Section Info Objects (#2067)
* [section-infos-api] Add ASSectionInfo.h

* Create Processes.md

* Update ASSectionInfo.h

* Update ASSectionInfo.h

* Add more changes/info

* More stuff

* More updates

* Make it a protocol

* Update things

* Oops

* Update Misc.m

* Update Overview.md

* Update ASCollectionSection.h

* Update ASCollectionSection.h
2016-08-16 10:19:58 -07:00
Nikita Lutsenko
2091df9607 [ASTextNode] Fix highlighting when textContainerInsets are set. (#2073)
* [ASTextNode] Fix highlighting when textContainerInsets are set.

* Add ASTextNodeSnapshotTests to xcodeproj.

* Add snapshot test for container inset and highlighting.
2016-08-16 10:18:51 -07:00
Peter
b80238c9cf no message 2016-08-16 14:13:42 +03:00
Peter
3d1b271f31 no message 2016-08-16 14:06:15 +03:00
Peter
48b6f08a47 no message 2016-08-16 14:06:01 +03:00
Peter
7a41d7071f no message 2016-08-16 14:05:47 +03:00
Peter
d403d674e1 no message 2016-08-16 14:05:28 +03:00
Peter
766fcbbb95 no message 2016-08-16 14:02:36 +03:00
Michael Schneider
365f739ce7 Fix ASPagerNode delegate and data source warning (#2076) 2016-08-15 20:58:50 -07:00
Michael Schneider
067e4998e2 Fix methods from ASCollectionDelegate are not passed through to pager delegate (#2074) 2016-08-15 17:23:39 -07:00
Michael Schneider
ee87695fc8 Don't use the default layout transition animation of no animation is wanted (#2075) 2016-08-15 17:23:02 -07:00
Adlai Holler
05ebbdc8ed Increase timeout for flaky image download test 2016-08-15 13:07:49 -07:00
Michael Schneider
11215bf97f [Automatic Hierarchy Management] Rename IHM to automatic hierarchy management and move out of beta header (#2066)
* Rename automaticHierarchy to automaticallyManagesSubnodes

* Comment adjustments
2016-08-15 12:06:06 -07:00
David Rodrigues
f05ccea860 Fix wrong annotation which is causing a warning at compile time (#2072) 2016-08-15 11:26:10 -07:00
Michael Schneider
adcc9afb5a [Layout Transition] Add default fade in / out layout transition (#2052)
* Add default fade in / out layout transition

* Add example for layout transition

* Update for recent layout transition API changes

* To be able to do a layoutTransition the node needs to be loaded

* Rename layoutTransitionDuration to defaultLayoutTransitionDuration

* Expose default layout transition duration delay and options

* Use `UIViewAnimationOptionBeginFromCurrentState` for initial defaultLayoutTransitionOptions
2016-08-13 17:35:20 -07:00
Maximilian Szengel
43370fe6ff Expose AVPlayerLayer on ASVideoNode (#2028)
The playerLayer is needed for picture in picture support on the iPad (AVPictureInPictureController).
2016-08-13 17:28:19 -07:00
Michael Schneider
93be894e0c [ASCollectionView / ASPagerNode] Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate (#2065)
* Move constrainedSizeForNodeAtIndexPath from the DataSource to the Delegate in ASCollectionView and ASPagerNode

* Fix ASPagerNode declaration of dataSource and delegate

As ASPagerDataSource does not inherit from ASCollectionDataSource it's not possible to declare it as property.

* Update comment
2016-08-12 15:37:23 -07:00