Michael Schneider
8f1beb8bf6
Addressed comments
...
- Use memset to clear flags
- Fix check for asyncDataSourceNodeForItemAtIndexPath
- Fix selector for asyncDelegateCollectionViewDidEndDisplayingNodeForItemAtIndexPath
- Fix multiple collectionViewWillEditCellsAtIndexPaths:batched: calls
2016-04-19 16:13:30 -07:00
Michael Schneider
d9f16e0acf
Use _performingBatchUpdates for _layoutFacilitator batched parameter
2016-04-19 16:13:30 -07:00
Michael Schneider
3a20c6a1f4
Add caching for delegate and datasource calls in ASCollectionView and ASTableView
2016-04-19 16:13:30 -07:00
Michael Schneider
42174210c5
Follow up for ASCollectionNode and ASTableNode background color fix
2016-04-19 16:07:42 -07:00
Michael Schneider
68de6a6391
Fix "[NSProxy methodSignatureForSelector:] called!" crash
2016-04-19 15:06:00 -07:00
Garrett Moon
0fc39d1ccd
Follow up to animated GIF PR
2016-04-19 13:43:41 -07:00
Eric Jensen
4a010337f6
Limit resuming of buffering videos to those that are visible
2016-04-19 13:21:06 -07:00
Eric Jensen
f01ceab3e7
Reuse the existing AVPlayer when it's available in fetchData
2016-04-19 13:04:35 -07:00
appleguy
39da0987a3
Merge pull request #1537 from maicki/FixASCollectionNodeASTableNodeBackgroundColor
...
Fix ASTableNode / ASCollectionNode backgroundColor does not apply correctly.
2016-04-19 12:30:54 -07:00
appleguy
4973cd5cd0
Merge pull request #1553 from ejensen/video-state-cleanup
...
[ASVideoNode] State observing cleanup
2016-04-19 12:17:19 -07:00
appleguy
23faa99b40
Merge pull request #1555 from vivqu/support_ios7
...
Update ASSentinel to use OSAtomicAdd32 to support iOS7.0
2016-04-19 12:01:02 -07:00
Michael Schneider
3793dc024e
Improve setting special properties for certain classes directly to the UIView
...
- Remove duplicated code in ASCollectionNode and ASTableNode
- Fix setting the pending state to the view if applying the pending state to the view
2016-04-19 10:50:22 -07:00
Vivian Qu
ccb5860c78
Update ASSentinel to use OSAtomicAdd32 to support iOS7.0
2016-04-19 10:46:55 -07:00
Aaron Schubert
21abe8f899
Fix merge conflicts
2016-04-19 09:02:07 +01:00
Eric Jensen
a49d620771
Replace dispatch_async(dispatch_get_main_queue... with ASPerformBlockOnMainThread
2016-04-18 23:08:57 -07:00
Eric Jensen
6a4bc3fd5b
Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict
2016-04-18 22:30:32 -07:00
Eric Jensen
a2b03d6e90
Change ASContentModeFromVideoGravity's default to UIViewContentModeScaleAspectFit
2016-04-18 22:13:49 -07:00
Eric Jensen
b5c3b15069
Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying
2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502
Simplified and improved video node's handling of state changes:
...
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
appleguy
33e36de5dc
Merge pull request #1552 from chourobin/feature/hls
...
[ASVideoNode] Re-enables HLS support
2016-04-18 22:09:43 -07:00
appleguy
f9d00eea93
Merge pull request #1550 from maicki/FixArrayDiffStaticAnalyzer
...
[NSArray+Diffing] Static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
2016-04-18 22:01:29 -07:00
appleguy
8d0fe9650b
Merge pull request #1549 from ejensen/video-fixes-rebase
...
[ASVideoNode] Several small bug fixes, improved code quality, added more tests.
2016-04-18 21:56:57 -07:00
Hannah Troisi
2658cf429e
Merge remote-tracking branch 'facebook/master'
2016-04-18 21:06:56 -07:00
Robin Chou
bdd4baf933
Re-enables HLS support (can't use AVAsset for HTTP live stream media).
2016-04-18 22:38:47 -04:00
Lukas Spieß
a707e22544
Add link to Slack channel to Readme
2016-04-19 01:35:31 +02:00
Lukas Spieß
5502776fd1
Prefix category on NSData to prevent symbol collisions
2016-04-19 01:16:01 +02:00
Lukas Spieß
0c866466d7
Update changelog
2016-04-19 01:13:16 +02:00
Lukas Spieß
24d87e1aee
Update changelog
2016-04-19 01:06:24 +02:00
Michael Schneider
8d20321d67
Fix ASTableNode / ASCollectionNode backgroundColor does not work
...
If the background color is applied via the pending state it's applied to the layer of the UICollectionView / UITableview. Unfortunately UITableView / UICollectionView does not consider using the layer backgroundColor property as it's background color, so it needs to be applied to the view after the ASCollectionNode / ASTableNode did load and the view is available
2016-04-18 15:52:22 -07:00
Michael Schneider
9d07336c75
Fix static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
...
The issue was: The left operand of '>=' is a garbage value in else if check for lengths[i+1][j] ... I had to rewrite the algorithm to quiet the static analyzer.
2016-04-18 14:38:32 -07:00
Eric Jensen
c1c1358baf
Fix video stalling by pausing the video after backgrounding the application
2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49
Replacing ASVideoNode's playButton now cleans-up the previous button's state
2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1
Correct mismatch between video gravity and placeholder image content mode
2016-04-18 13:53:43 -07:00
Eric Jensen
651a6bb3e4
Add nullability annotations and documentation comments to ASVideoNode
2016-04-18 13:53:43 -07:00
appleguy
103506beec
Merge pull request #1534 from hannahmbanana/mapSnapshotBug
...
[ASMapNode] Defer snapshots triggered before layout occurs to reduce unnecessary snapshots.
2016-04-18 13:34:56 -07:00
Hannah Troisi
4395af015d
Removing _site files that accidently snuck into commit.
2016-04-18 10:12:58 -07:00
Lukas Spieß
07d5e41d42
Minor Readme updates
2016-04-18 16:14:26 +02:00
Lukas Spieß
1e46b95ae1
Merge pull request #262 from bitstadium/feature/carthage-support
...
Add Carthage support
2016-04-18 16:06:40 +02:00
Hannah Troisi
1b3ca72877
Fix preexisting code - missing super call
2016-04-17 22:49:14 -07:00
appleguy
2a1617d80c
Merge pull request #1545 from facebook/Video
...
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 22:08:17 -07:00
Hannah Troisi
1ff07b2233
Changed comment for clarity.
2016-04-17 21:53:01 -07:00
Scott Goodson
cd25facda5
[Build] Addressing some linker warnings in the test target.
2016-04-17 21:07:35 -07:00
Hannah Troisi
354b972e73
Renamed instance variable & improved comment per request
2016-04-17 20:45:50 -07:00
appleguy
322d85e738
Merge pull request #1511 from maicki/ASLayoutSpecOptimizations
...
[ASLayoutSpec] Improvements for ASLayoutSpec's internal implementation of child / children properties.
2016-04-17 20:26:54 -07:00
appleguy
9c26ebdec9
Merge pull request #1524 from ejensen/node-traversal-nullability
...
[ASDisplayNodeExtras] Include __kindof in nullability annotations for hierarchy traversal methods.
2016-04-17 20:20:17 -07:00
Scott Goodson
53d010b055
[ASVideoNode, Build / Framework] Ensure ASVideoNode.mm is in the framework target.
2016-04-17 20:16:53 -07:00
Scott Goodson
11744b7f31
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 20:12:37 -07:00
appleguy
94d0d908dc
Merge pull request #1323 from gazreese/AVPlayerItem-construction
...
[ASVideoNode] Add support for HTTP Live Streaming Video
2016-04-17 19:30:23 -07:00
Peter
c73133e709
Merge commit 'f9620a013c2b8f35a206b917c58c0634062bfbf5'
2016-04-18 01:46:58 +03:00
Peter
cd9b012ccf
no message
2016-04-18 01:30:55 +03:00