Adlai Holler
b5b5f9f559
Some clean up
2016-02-20 15:40:47 -08:00
Adlai Holler
99b674c346
Lay some foundation for our new pending state controller
2016-02-20 15:40:47 -08:00
Rahul Malik
19cc368d15
In addition to allocating nodes in the background, perform that operation concurrently in ASDataController
2016-02-17 22:30:58 -08:00
Levi McCallum
b267821d4c
Wrap implicit node hierarchy management behind feature flag property
2016-02-10 19:21:29 -08:00
appleguy
07adec12a0
Merge pull request #1183 from levi/layoutTransition
...
[ASLayoutSpec] Add API to animate layout spec transitions, with implicit subnode management.
2016-02-10 15:30:49 -08:00
Levi McCallum
8238da8d00
Fix node deletion and flatten identification issues
2016-02-10 11:44:11 -08:00
Levi McCallum
6a2903f2ec
Revert "Update LCS diffing to support insertions before deletions"
...
This reverts commit 8d90f1bccda0b7d99639085e0bfa3488c3c01dbe.
2016-02-10 11:44:10 -08:00
Levi McCallum
8f3788d0b2
Update LCS diffing to support insertions before deletions
2016-02-10 11:44:10 -08:00
Levi McCallum
a2045f19c5
Add test for complete reordering of LCS diff
2016-02-10 11:44:10 -08:00
Garrett Moon
5a4e4dcac4
Add default PINRemoteImageDownloader
2016-02-08 16:00:19 -08:00
Rahul Malik
6c240a2fce
ASPagerNode's api was not updated while addressing comments on the initial
...
ASCellNode background allocation PR. This change fixes that issue.
2016-02-05 15:09:08 -08:00
Rahul Malik
c4f489b074
Address comments.
2016-02-04 16:56:29 -08:00
Rahul Malik
521c3fa1c1
Move ASCellNode allocation off the main thread by the addition of a node block
...
API in ASDataController. Move allocations and loaded node layouts to occur
during batch layout phase.
2016-02-04 10:38:59 -08:00
appleguy
f15bd92df1
Merge pull request #1156 from levi/implicitNodeMembership
...
[ASDisplayNode] Implicit node hierarchy handling with ASLayouts
2016-02-01 18:33:32 -08:00
Levi McCallum
d168ec78ce
Implement simple, in-order add/remove subnode support when changing layout specs
2016-02-01 17:49:48 -08:00
Levi McCallum
9f25b54f9e
Support insertion on first layout of display node
2016-02-01 17:49:48 -08:00
Levi McCallum
e852cb612c
Simplify usage of diffing API
2016-02-01 17:49:47 -08:00
Levi McCallum
7a3987a467
Add tests to LCS array category
2016-02-01 17:49:47 -08:00
Luke Parham
2313b32406
removed comment
2016-01-29 16:31:54 -08:00
appleguy
2c194fd924
Merge pull request #1140 from rcancro/textNodeWordSpacing
...
[ASTextNode] Added ASTextNodeWordKerner support
2016-01-28 15:38:00 -08:00
rcancro
7f6f2fed11
Added ASTextNodeWordKerner support to ASTextNode
...
* Added a member to `ASTextKitAttributes` that is an optional delegate to the struct's NSLayoutManager.
* Changed ASTextNode to set this delegate to an instance of ASTextNodeWordKerner.
* Updated init method of `ASTextKitContext` to take an optional NSLayoutManager delegate
* Added the files in TextKit folder to the public headers (so we can include ASTextNodeTypes.h)
2016-01-28 08:38:22 -08:00
Samuel Hsiung
8c963bd13c
Fix attribute value setting in testLinkInTextUsesForegroundColor in ASTextKitTests
2016-01-27 23:51:44 -08:00
appleguy
e22c50101a
Merge pull request #1134 from bimawa/ASTextNodeAddTestCase
...
Added additionalTruncationMessage Unit test
2016-01-27 22:45:19 -08:00
appleguy
5b9be8a8c3
Merge pull request #1127 from samhsiung/foreground_color_link
...
[ASTextKit] Use NSForegroundColorAttributeName for links in ASTextKitRenderer
2016-01-27 22:42:04 -08:00
Maxim Bunkov
8a8843a32a
Added additionalTruncationMessage Unit test
2016-01-28 10:27:58 +05:00
Samuel Hsiung
90ac40020f
Use NSForegroundColorAttributeName for links in ASTextNodes by subclassing NSLayoutManager
2016-01-27 21:13:28 -08:00
Levi McCallum
411d0b3deb
Add tests for setNeedsDataFetch and out of range fetch behavior
2016-01-27 18:24:59 -08:00
yury
a0b7254213
[text] Fix crash when highlighted range exceeds truncation range
2016-01-26 22:37:44 +03:00
Huy Nguyen
3bb8967b96
Enable ASCollectionViewTests:testCollectionViewController
2016-01-25 22:26:30 -08:00
Luke Parham
41721aa42a
merged with master
2016-01-24 23:14:43 -06:00
Luke Parham
98fb2e46d4
wip but currently adding first frame as placeholder until it should play and removed extraneous 'pause'
2016-01-24 23:13:17 -06:00
Scott Goodson
9ddf68fa96
[ASTextNode] Optimize handling of constrained size to almost never recreate NSLayoutManager
...
This also fixes two fairly subtle but serious bugs, #1076 and #1046 .
2016-01-24 00:50:43 -08:00
Luke Parham
d9559111a0
renamed nic cage sample, added redundancy for loading player in case its nil when visible, added video tests, disabled assert for new range controller
2016-01-14 02:39:36 -06:00
Luke Parham
579313f086
Merge branch 'master' into ASVideoNode
2016-01-13 12:22:55 -06:00
Scott Goodson
55861b3de1
Update the expectations of the tests now that the clearContents behavior is corrected.
2015-12-27 16:37:33 -08:00
Scott Goodson
44feece701
Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases.
2015-12-26 23:05:34 -08:00
Luke Parham
5fbf39644b
merged upstream
2015-12-26 01:33:34 -06:00
Scott Goodson
882d4b336e
Merge branch 'master' into pr/664
2015-12-25 14:32:41 -08:00
Scott Goodson
7ece41ff64
Delegate definition tweaks for Table and Collection; ensure Table tests run with ARC enabled.
2015-12-24 21:41:12 -08:00
Scott Goodson
ca57059322
New ASDelegateProxy class to unify logic for Table & Collection forwarding. Fix dealloc-during-animation crash.
2015-12-23 20:01:52 -08:00
Scott Goodson
38d9ceb230
Fix corrupted project file from merge.
2015-12-23 12:52:38 -08:00
Scott Goodson
9944305cfd
Fix tests to avoid newly deprecated ASCollectionView init variant with asyncDataFetching argument.
2015-12-22 23:36:29 -08:00
Luke Parham
6dc15ffd44
added delegate method for video did finish, moved layer creation to after view displays, rearranged spinner logic, added tests
2015-12-22 15:34:11 -06:00
Luke Parham
e318285089
merged master
2015-12-22 02:17:28 -06:00
Luke Parham
4602e4e9eb
wip fixing pr comments
2015-12-22 02:15:25 -06:00
Adlai Holler
69767d558e
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/Private/ASDisplayNode+FrameworkPrivate.h
2015-12-22 00:28:21 -05:00
Scott Goodson
b8602d1073
Fix ASBasicImageDownloader tests - prevent use of init / new instead of +sharedImageDownloader.
2015-12-20 15:42:57 -08:00
Scott Goodson
92126f0d66
Support surprisingly nice automatic behavior for the unsupported case of view-backed nodes as children of layer-backed ones.
2015-12-19 20:33:28 -08:00
Luke Parham
c69e18bc6e
refactored test
2015-12-19 00:14:17 -06:00
Scott Goodson
ee152eadf1
Remove CALayer and UIView implementations of "name" property.
...
This avoids CoreAnimation from capturing the name from a background thread deep within the internals
of AVPlayerLayer, which commits transactions off the main thread. If the main thread is also accessing
properties that require the lock, in very specific app architectures relying on AVPlayerLayer, this
can cause a deadlock.
The "name" property is primarily used by ASDK's unit test infrastructure, so I'm leaving it in place for
that purpose - and it may still be used for debugging, if someone wants to set it. It will remain
possible to get the node from a layer or view with asyncdisplaykit_node, and access name from there.
2015-12-18 16:01:19 -08:00
