Connor Montgomery
800aa05c35
Revert "Merge pull request #1162 from maicki/controlnode-init-optimization"
...
This reverts commit 35a4b268d64e922b3928f247614b664a9413ad3b, reversing
changes made to 4201df5f31077ea31bf014fc01828c065bd31c1c.
2016-02-05 13:49:00 -05:00
Michael Schneider
597aa02c8e
Remove target added state and and instead check _controlEventDispatchTable if a target was added
2016-02-03 18:53:20 -08:00
Michael Schneider
12e2b535db
Use instance variable for tracking if a target was added to ASControlNode
2016-02-02 08:30:52 -08:00
Michael Schneider
ddf50b20bd
Use is target added state additionally to the enabled state to check if touches should be tracked
2016-02-01 20:13:23 -08:00
Michael Schneider
89eae1213d
Delay set userInteractionEnabled to NO until didLoad
2016-02-01 20:09:26 -08:00
Viet Hoa Dinh
dbe068c970
Fixed behavior of ASControlNode when -touchesEnded:withEvent: sometimes firing twice.
2016-01-13 19:06:01 -08:00
Bin Liu
4435405cbb
Make ASControlState imitate UIControlState
...
- selected state isn't implicitly controlled by ASControlNode anymore
- highlighted state can be overriden by users
- Decouple ASButtonNode's state from control events
2016-01-06 12:17:52 -08:00
Bin Liu
6bb51063f9
Replace ASButtonState with ASControlState
2016-01-05 17:07:44 -08:00
Rajinder Ramgarhia
688e8d27de
Add comment explaning the change
2016-01-03 11:02:33 -05:00
Rajinder Ramgarhia
73373ee17b
Fix ASControlNode mutation crash
2016-01-01 22:27:08 -05:00
Scott Goodson
928c440b4c
Several small optimizations, especially to _ASPendingState and other hot paths.
2015-12-23 16:38:33 -08:00
rlasante
04ec602500
Don’t retain an action’s target in ASControlNode
...
- addTarget:action:forControlEvents: should not retain the target. If it does
then there is a very high likelihood of a retain cycle.
2015-05-01 13:04:26 -04:00
Ryan Nystrom
29a360d562
Allow double-tap gestures on text nodes
2015-03-26 17:22:22 -07:00
Ryan Nystrom
d8f5d135b0
Revert ASControlNode to previous touch/gesture handling
2015-02-18 17:51:18 -08:00
Ryan Nystrom
52cbbd3d3c
Allow all gestures through ASControlNode
...
fixes #305
2015-02-11 17:00:44 -08:00
Brian Amerige
b3e9b7845f
Fix ASControlNode Event Dispatch Table Memory Semantics
...
Summary: `weakToStrong` where the keys are NSNumbers that aren't strongly held by anyone means the events in the table get removed almost immediately. Derp.
Test Plan: Confirm that events are not dropped from the table after they're added. Confirm that the "Search" button actually works in the Share Sheet.
Reviewers: suv, zsh, nyn531, kimon, bcunning, sma, grp, nadi, b3ll
Reviewed By: b3ll
Differential Revision: https://phabricator.fb.com/D1819759
Tasks: 6137402
Signature: t1:1819759:1422918745:bf25bc2662f767fec3a78fc0c7702c591ed17064
2015-02-02 17:30:27 -08:00
Nadine Salter
d5f18f7637
Merge pull request #270 from facebook/issue-268
...
Track control node touches
2015-01-27 16:16:27 -08:00
Ryan Nystrom
76b3d1310f
Track control node touches
...
Tested with custom `ASTextNode` subclass. No targets added, but tracking events are still received upon touches.
fixes #268
2015-01-27 15:47:05 -08:00
Ryan Nystrom
ea6c29fb7f
Compile for extensions
2015-01-27 09:30:09 -08:00
林藍東
faab914a08
Fix issue #61
2014-10-17 19:22:17 +08:00
Nadine Salter
20631a632f
Fix unsafe unretained references in ASControlNode.
...
Fix regression from the ARC conversion. Change the raw, unretained
pointers in ASControlNode to weak references. Use NSMapTable instead of
the pointer-as-NSValue system.
2014-09-30 14:26:08 -07:00
Nadine Salter
803585164c
Convert AsyncDisplayKit to ARC.
2014-09-23 15:30:30 -07:00
Nadine Salter
15565873c9
Initial commit.
2014-06-26 22:32:55 -07:00
