Commit Graph

3364 Commits

Author SHA1 Message Date
Garrett Moon
24c26014a7 Fix example builds 2016-04-13 14:23:02 -07:00
Garrett Moon
b56e20853b Prevent retain cycle, clear out animatedImage on _clearImage. 2016-04-13 14:23:02 -07:00
Garrett Moon
59b18efc76 Needs to be named Sample.xcodeproj 2016-04-13 14:23:02 -07:00
Garrett Moon
2e30091236 Didn't mean to change this. 2016-04-13 14:23:02 -07:00
Garrett Moon
e9b57d9da4 Address comments and cleanup 2016-04-13 14:23:02 -07:00
Garrett Moon
f4b526a8db Fix non example build 2016-04-13 14:23:02 -07:00
Garrett Moon
1b316217ef Downstream ASAnimatedImage 2016-04-13 14:23:02 -07:00
Garrett Moon
beba9031ef Expose public properties properly
Reviewers: rmalik

Reviewed By: rmalik

Differential Revision: https://phabricator.pinadmin.com/D82227
2016-04-13 14:23:02 -07:00
Garrett Moon
3bcbfb149d Add support for animated GIFs
Summary:
Use NSData as key

Add chunking of files

Add support for Animated Images

This adds support for GIF playback in ASDK. It's not currently ready
for merging to public ASDK – for one the GIF decompression may make
more sense in PINRemoteImage.

Removed duration as it wasn't used

Make cover image lazily loaded

Differential Revision: https://phabricator.pinadmin.com/D82033
2016-04-13 14:23:02 -07:00
Eric Jensen
527397ba7e Replace id with instancetype in initializers 2016-04-13 11:20:05 -07:00
Steffen Matthischke
e08c3e7cac Replace FLAnimatedImage with PINRemoteImage in the comment 2016-04-13 17:27:33 +02:00
Steffen Matthischke
75e5171ba8 Add Core subspec. Add all mandatory files to the Core subspec. 2016-04-13 13:28:39 +02:00
Adlai Holler
140ca717b1 [ASMultiplexImageNode] Do not eagerly cancel image downloads 2016-04-12 22:14:34 -07:00
appleguy
5fc307f0bc Merge pull request #1521 from levi/update-asdk
Add Profile build configuration to ASDK
2016-04-12 19:02:18 -07:00
appleguy
1006c8ad16 Merge pull request #1523 from maicki/FixBatchFetchLoop
[ASBatchContext] If API adoption is incomplete, protect against repeat fetching at end of content.
2016-04-12 18:51:59 -07:00
Adlai Holler
60c3ed27ff Fix more indentation 2016-04-12 17:46:44 -07:00
Adlai Holler
faf29dd978 Fix indentation 2016-04-12 17:45:40 -07:00
Adlai Holler
7128f69678 [ASMultiplexImageNode] Avoid deadlock by reading our interface state earlier 2016-04-12 17:35:46 -07:00
Eric Jensen
fcab11ee8d Use __kindof annotation for subside traversal methods that filter based on class 2016-04-12 17:24:28 -07:00
Eric Jensen
2d86dd8ead Correct nullability annotations of node traversal helpers 2016-04-12 17:15:36 -07:00
Michael Schneider
d0023a97f7 Fix fetching will continually trigger in a loop after reaching end of content
Don't schedule a new check for a batch fetch if no data changed previous batch fetch
2016-04-12 17:14:43 -07:00
Adlai Holler
0022cad000 [ASMultiplexImageNode] Copy recent changes made to ASNetworkImageNode for progress image handling 2016-04-12 14:34:11 -07:00
Adlai Holler
362c41ae80 [ASNetworkImageNode] Attach progress image handler even if download starts while already visible 2016-04-12 14:17:41 -07:00
Adlai Holler
37c7f6f849 [ASNetworkImageNode] Remove retain 2016-04-12 14:17:41 -07:00
Adlai Holler
11461f415f [ASNetworkImageNode] Improve readability, resolve self retain, reduce locking 2016-04-12 14:17:41 -07:00
Levi McCallum
74c3403e94 Add Profile build configuration to ASDK
Summary: Fixes client Profile build

Reviewers: scottg

Differential Revision: https://phabricator.pinadmin.com/D84475
2016-04-12 12:57:49 -07:00
appleguy
364013a333 Merge pull request #1457 from hannahmbanana/500pxgram
[New Example] ASDKgram - a social app (500px browser) to demonstrate AsyncDisplayKit patterns alongside a UIKit implementation
2016-04-12 00:51:44 -07:00
Scott Goodson
8ccef1e99f [ASEnvironment] Fix incomplete gating of upward propagation of layout properties (disabled for now). 2016-04-11 20:34:24 -07:00
Hannah Troisi
23d00d40e1 [New Example] 500pxgram
- added UIActivityMonitor
- added simple NSCache for UIKit tab
2016-04-11 19:04:05 -07:00
Scott Goodson
1b7b1f3991 Merge branch 'master' of https://github.com/facebook/AsyncDisplayKit 2016-04-11 17:47:15 -07:00
appleguy
74407d50c4 Merge pull request #1513 from maicki/NodesLayerInLayerAccessiblity
[ASDisplayNode] Add handling layer backed accessibility elements within layer backed nodes
2016-04-11 17:46:19 -07:00
appleguy
97c7e4cdef Merge pull request #1514 from maicki/FixDisabledStatePropagationFinalLayoutable
[ASEnvironment] Fix disabled state propagation for final layoutable
2016-04-11 17:46:06 -07:00
Michael Schneider
45d50624d1 Fix disabled state propagation for final layoutable 2016-04-11 17:41:48 -07:00
Hannah Troisi
89ab6b38fc [New Example] 500pxgram updates
- added UIKit autolayout to UIKit PhotoTableViewCell
2016-04-11 13:31:31 -07:00
Michael Schneider
2fade63f1b Add handling layer backed accessibility elements within layer backed nodes 2016-04-11 12:59:04 -07:00
Scott Goodson
a305d409ad [Podspec] Bump to 1.9.7.2 2016-04-11 12:55:10 -07:00
Hannah Troisi
44d483b7fe [New Example] 500pxgram updates
- addressed all comments in PR except autolayout of UIKit code
2016-04-10 23:34:41 -07:00
Hannah Troisi
16ece60a3e Merge remote-tracking branch 'facebook/master' into 500pxgram 2016-04-10 21:47:28 -07:00
Hannah Troisi
decb623d38 Merge remote-tracking branch 'facebook/master' into 500pxgram 2016-04-10 21:46:51 -07:00
appleguy
a6e66fa5d7 Merge pull request #1510 from lappp9/readme-update
Readme update
2016-04-10 17:16:56 -07:00
appleguy
87320c295c Merge pull request #1509 from facebook/ASLayoutValidation
[ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
2016-04-10 17:16:12 -07:00
Luke Parham
c6e78eb5dc Merge branch 'master' into readme-update 2016-04-10 18:53:06 -05:00
Luke Parham
32dade53d5 link doesnt work with trailing slash 2016-04-10 18:51:24 -05:00
Scott Goodson
678c201dbc [ASLayout] Add additional validation step to intercept incorrect values in production and safely zero them out.
These conditions already had assertions, but at runtime, an insufficiently tested and incorrect ASLayoutSpec could
generate values that cause UIKit to enter an infinite loop (e.g. inside of UICollectionView layout validation).
2016-04-10 16:42:22 -07:00
Luke Parham
5c7d43551e updated links in readme 2016-04-10 18:40:07 -05:00
appleguy
c94490f7bb Merge pull request #1508 from lappp9/readme-update
[AsyncDisplayKit.org] Updated links in readme
2016-04-10 16:39:31 -07:00
appleguy
c17c21545e Merge pull request #1506 from maicki/ASEnvironmentPropagationSwitch
[ASEnvironment] Add switch to enable / disable propagation of layout option properties
2016-04-10 15:06:26 -07:00
Michael Schneider
ed0ed74b72 Add switch to enable / disable layout option properties 2016-04-10 15:04:49 -07:00
appleguy
d64ca2267e Merge pull request #1505 from maicki/RemoveLoggingMessage
Remove batch logging message
2016-04-10 14:37:59 -07:00
Michael Schneider
3c66013088 Remove logging message 2016-04-10 14:23:33 -07:00