Commit Graph

3364 Commits

Author SHA1 Message Date
Nadine Salter
7344cb98bb Remove ASImageNode's tint property.
ASImageNodeTint is inflexible (your options are "no tint" and "use
`[UIColor grayColor]`") and needlessly complicates the ASImageNode
implementation.  Use ASImageNodeTintColorModificationBlock() instead.
Closes #383.
2015-03-20 12:37:27 -07:00
Nadine Salter
1dc4b42dce Merge pull request #382 from facebook/longer-async-wait
Longer timeout for async tests
2015-03-17 12:01:39 -07:00
Ryan Nystrom
7117548bc1 Longer timeout for async tests 2015-03-17 11:44:10 -07:00
Nadine Salter
1a39f412d5 Merge pull request #381 from facebook/suspended-range
Enable nodes entering the visible range to display
2015-03-17 11:20:18 -07:00
Ryan Nystrom
cd3ad1c86f Enable nodes entering the visible range to display 2015-03-17 10:52:32 -07:00
Ryan Nystrom
fa2f36004b Merge pull request #375 from facebook/issue-374
Stretchy or mod block images
2015-03-15 15:59:38 -07:00
Ryan Nystrom
59c9fc8819 Stretchy or mod block images
fixes #374
2015-03-12 14:41:11 -07:00
Ryan Nystrom
1278fe2cf0 Merge pull request #373 from facebook/issue-349
Remove the nil-asyncDelegate proxy.
2015-03-12 14:29:28 -07:00
Nadine Salter
7fa5aa5e01 Merge pull request #371 from facebook/working-window
Working range window
2015-03-11 18:02:20 -07:00
Ryan Nystrom
0b19be0f85 Working range window
This brings back the concept of a window store for nodes that are in the working range (reverting #127). It turns out that due to the system architecture if there are nodes who fetch remote content (e.g. `ASNetworkImageNode`), calls to `-display` will occur before fetching has been completed. The next chance the nodes have to decode and display content is then when they are actually on the screen, thus defeating the purpose of a working range.

With the reintroduction of the working range window, nodes are "stored" in the window and when content is finished being fetched, CA triggers `-display` since they are part of a view hierarchy.

This can be tested in the Kittens project by insuring that before `ASRangeController` adds a node to [a visible view](https://github.com/facebook/AsyncDisplayKit/blob/master/AsyncDisplayKit/Details/ASRangeController.mm#L57) that the image node (with remote content) has set its layer's contents.
2015-03-11 17:59:03 -07:00
Nadine Salter
de14f220c3 Merge pull request #367 from facebook/issue-364
Thread safe creation and canceling of download tasks
2015-03-11 17:57:52 -07:00
Nadine Salter
a79b771a85 Remove the nil-asyncDelegate proxy.
Fixes #349.
2015-03-11 17:43:45 -07:00
Ryan Nystrom
db8bbcfd0e Thread safe creation and canceling of download tasks
fixes #364
2015-03-11 16:52:14 -07:00
Nadine Salter
ac9337a629 Merge pull request #372 from bdaz/master
Support Forwarding Responder-Chain Actions to Node from its View
2015-03-11 14:39:44 -07:00
Brian Amerige
9019233c68 Support Forwarding Responder-Chain Actions to Node from its View
Summary:
What it says on the tin. This allows Nodes to effectively participate in the responder chain.

Caveat: see note in implementation below. Would have been nice to use `-targetForAction:withSender:` the way the docs imply you can, but alas.

Test Plan: Observe a node in the responder chain get invoked to handle an action it implements.

Reviewers: bcunning, zsh, sma, jpasqualini, suv, nyn531, b3ll, aaronpang, kimon, grp, jonathan, rnystrom, nadi

Reviewed By: nadi

Subscribers: trunkagent, rnystrom

Differential Revision: https://phabricator.fb.com/D1894023

Signature: t1:1894023:1426026643:203945b6a7c318f6d2c9b94d876da61da31327bd
2015-03-11 14:37:17 -07:00
Nadine Salter
862c8f2991 Merge pull request #355 from facebook/text-placeholders
Text placeholders snap to pixels
2015-03-11 14:15:20 -07:00
Ryan Nystrom
b6dea69070 Text placeholders snap to pixels 2015-03-11 13:56:12 -07:00
Nadine Salter
c7e04c84f1 [travis] Disable iOS 7.1 testing.
Travis CI's buildbots no longer have the iOS 7.x runtimes installed:

    == Runtimes ==
    iOS 7.0 (7.0 - Unknown) (com.apple.CoreSimulator.SimRuntime.iOS-7-0) (unavailable, runtime path not found)
    iOS 7.1 (7.1 - Unknown) (com.apple.CoreSimulator.SimRuntime.iOS-7-1) (unavailable, runtime path not found)
    iOS 8.1 (8.1 - 12B411) (com.apple.CoreSimulator.SimRuntime.iOS-8-1)

Disable iOS 7.1 testing.
2015-03-11 13:51:58 -07:00
Nadine Salter
a40c8172ac Merge pull request #365 from facebook/issue-363
Range handlers use recursive actions
2015-03-09 12:37:17 -07:00
Ryan Nystrom
5e7755fac0 Range handlers use recursive actions
fixes #363
2015-03-09 12:33:02 -07:00
Nadine Salter
afb0aa41b7 Merge pull request #360 from lxcid/bug/block-copy
Block should always be declared using the copy attribute.
2015-03-07 14:47:57 -08:00
Nadine Salter
860a8783b4 Merge pull request #356 from nguyenhuy/master
Fix method documentation in ASCollectionView.
2015-03-07 14:46:55 -08:00
Nadine Salter
42e9e049a9 Merge pull request #354 from 343max/retuned-processed-image
return the processed image instead of the original image when it's being stretched
2015-03-07 14:40:00 -08:00
Stan Chang Khin Boon
7c5b31e419 Block should always be declared using the copy attribute. 2015-03-08 01:54:02 +08:00
Huy Nguyen
6a13703932 Fix method documentation in ASCollectionView. 2015-03-06 12:29:59 +02:00
Max von Webel
086af4f99c I’m not completly sure, but shouldn’t this be “result” instead of “image”? 2015-03-05 14:35:40 -08:00
appleguy
10adca52d0 Merge pull request #351 from facebook/stricter-flags
Stricter build flags for ASDK and tests
2015-03-04 12:59:08 -08:00
Ryan Nystrom
47b53d9293 Stricter build flags for ASDK and tests 2015-03-04 11:09:02 -08:00
Nadine Salter
2e5b7a689a Merge pull request #350 from facebook/optional-locking
Make data locking API optional
2015-03-04 10:55:48 -08:00
Ryan Nystrom
6588e7b665 Make data locking API optional 2015-03-04 10:13:32 -08:00
Ryan Nystrom
69dbbae91c Fix miscellaneous build failures. 2015-03-02 16:44:25 -08:00
Nadine Salter
3c822fe698 Merge pull request #312 from facebook/batch-api
Batch Fetching API
2015-02-26 22:54:43 -08:00
Ryan Nystrom
c657411a2e Batch fetch with small data sets 2015-02-26 22:29:13 -08:00
Ryan Nystrom
8d7fe334e2 Revisions based on feedback 2015-02-26 22:29:13 -08:00
Ryan Nystrom
b3ae15858a Unit tests for batch fetching 2015-02-26 22:26:25 -08:00
Ryan Nystrom
1f8001a104 ASCollectionView batch API 2015-02-26 22:24:46 -08:00
Ryan Nystrom
09ade3dd00 ASTableView batch API and context object 2015-02-26 22:23:32 -08:00
Nadine Salter
caf168a6a5 Merge pull request #285 from facebook/nix-layout-working
Custom Ranges Mechanism
2015-02-26 22:08:13 -08:00
Ryan Nystrom
599bf42675 Revisions based on feedback 2015-02-26 15:41:32 -08:00
Ryan Nystrom
4fa03a01d1 Functioning Preload range
Refactor how we do ranges so they can be arbitrarily managed. Introduce the concept of a preload range.
2015-02-26 15:41:32 -08:00
Ryan Nystrom
9c877c51af Support for dynamic ranges
This refactors how we do ranges and implements tuning parameters for a "Render" range and a "Preload" range
2015-02-26 15:40:21 -08:00
Ryan Nystrom
43be3294bc Remove "working range" from flow layout
This is a step towards a preloading range. We first want to migrate towards arbitrary ranges instead of being coupled to the notion of a single "working range".
2015-02-26 15:40:21 -08:00
Nadine Salter
9477114c86 Merge pull request #340 from facebook/fix_locking
Fix function call on lock/unlock api
2015-02-25 21:13:47 -08:00
Li Tan
88f77e5d52 Fix function call on lock/unlock api 2015-02-25 21:01:59 -08:00
Nadine Salter
8097a6edf1 Merge pull request #323 from facebook/issue-282
Change placeholder boolean to time interval
2015-02-25 20:54:19 -08:00
Li Tan
9d5d586aa4 Merge pull request #339 from facebook/fix_unlock_assertion
Fix wrong assertion
2015-02-25 20:07:11 -08:00
Li Tan
e862e04b05 Fix wrong assertion 2015-02-25 19:37:22 -08:00
Nadine Salter
ea13585ab0 Merge pull request #329 from ocrickard/master
Fix text node positioning for non-left alignment
2015-02-24 12:02:03 -08:00
Oliver Clark Rickard
582c11d447 Fix text node positioning for non-left alignment 2015-02-24 14:31:08 -05:00
Nadine Salter
2397bd0db6 Merge pull request #325 from facebook/fix_data_fetching
Sort array before data fetching
2015-02-24 11:09:51 -08:00